References: <20200911115916.16117-1-gert@...1296...> <9d04cb8e-83a5-505a-9031-44b0d9bf9331@...2181...> <20200917070157.GP976@...1296...> From: Antonio Quartulli Message-ID: Date: Thu, 17 Sep 2020 09:23:47 +0200 MIME-Version: 1.0 In-Reply-To: <20200917070157.GP976@...1296...> Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH] If IPv6 pool specification sets pool start to ::0 address, increment. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Gert Doering Cc: openvpn-devel Hi, On 17/09/2020 09:01, Gert Doering wrote: > We look at "base", which is only the host part, but "at most 32 bits of > the host part". > > (This is *your* code...!) (self-shaming dance mode=ON) Riiight, then drop this comment. The patch looks good, except for the comment that needs more verbosity. > > gert > -- Antonio Quartulli