From: Maarten Lankhorst Subject: Re: [PATCH 07/10] drm/i915: Remove crtc->config dereferences in intel_modeset_setup_hw_state Date: Tue, 16 Oct 2018 15:57:49 +0200 Message-ID: References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com> <20181011100457.8776-8-maarten.lankhorst@linux.intel.com> <20181011115911.GD9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF1656E237 for ; Tue, 16 Oct 2018 13:57:50 +0000 (UTC) In-Reply-To: <20181011115911.GD9144@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTEtMTAtMTggb20gMTM6NTkgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVGh1LCBP Y3QgMTEsIDIwMTggYXQgMTI6MDQ6NTRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFRoZSBDUlRDIGlzIGlkbGUgYXQgdGhpcyBwb2ludCwgc28gd2UgY2FuIGRlcmVmZXJlbmNl IGNydGMtPnN0YXRlIHNhZmVseS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMSArKysrKysrLS0tLQo+PiAgMSBmaWxl IGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBpbmRleCAxOWQ3NzE0ZGYwMjEuLmNiZTcwYmM0ZDAy ZCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiBAQCAtMTU5MzQs NiArMTU5MzQsNyBAQCBpbnRlbF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsCj4+ICB7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g dG9faTkxNShkZXYpOwo+PiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+PiArCXN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+IENhbiBiZSBtb3ZlZCBpbnRvIG5hcnJvd2Vy IHNjb3BlLgoyIHBsYWNlcyB1c2UgaXQsIHRoZSBwb3dlciBkb21haW5zIGFuZCB0aGUgZHVtcF9w aXBlX2NvbmZpZywgYmVjYXVzZSBvZiB0aGlzCkkga2VwdCBpdCBhcyB0b3Agc2NvcGUuIDopCgpU aGFua3MsIHB1c2hlZCBwYXRjaCAyLTkuIEhvcGluZyB0byBnZXQgYSByZXZpZXdlciBmb3IgMSwg YW5kIHdpbGwgcmVzdWJtaXQgMTAvMTAgd2l0aAphIHBhdGNoIGRvaW5nIHRoZSBwcm9wb3NlZCBp bnRlbF93YWl0X2Zvcl92YmxhbmtfaWZfYWN0aXZlKCkgY2hhbmdlcy4KCj4+ICAJc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXI7Cj4+ICAJaW50IGk7Cj4+ICAKPj4gQEAgLTE1OTUyLDcgKzE1 OTUzLDcgQEAgaW50ZWxfbW9kZXNldF9zZXR1cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+PiAgCWZvcl9lYWNoX2ludGVsX2NydGMoJmRldl9wcml2LT5kcm0sIGNydGMpIHsKPj4g IAkJZHJtX2NydGNfdmJsYW5rX3Jlc2V0KCZjcnRjLT5iYXNlKTsKPj4gIAo+PiAtCQlpZiAoY3J0 Yy0+YWN0aXZlKQo+PiArCQlpZiAoY3J0Yy0+YmFzZS5zdGF0ZS0+YWN0aXZlKQo+PiAgCQkJZHJt X2NydGNfdmJsYW5rX29uKCZjcnRjLT5iYXNlKTsKPj4gIAl9Cj4+ICAKPj4gQEAgLTE1OTYxLDkg KzE1OTYyLDEwIEBAIGludGVsX21vZGVzZXRfc2V0dXBfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwKPj4gIAlmb3JfZWFjaF9pbnRlbF9lbmNvZGVyKGRldiwgZW5jb2RlcikKPj4gIAkJ aW50ZWxfc2FuaXRpemVfZW5jb2RlcihlbmNvZGVyKTsKPj4gIAo+PiAtCWZvcl9lYWNoX2ludGVs X2NydGMoJmRldl9wcml2LT5kcm0sIGNydGMpIHsKPj4gKwlmb3JfZWFjaF9pbnRlbF9jcnRjKGRl diwgY3J0Yykgewo+IEknZCBrZWVwIHRoZSBkZXZfcHJpdi0+ZHJtLCBiZWNhdXNlIHdlIHNob3Vs ZCBqdXN0IGNoYW5nZSB0aGUgZnVuY3Rpb24KPiB0byB0YWtlIHRoZSBkZXZfcHJpdiBkaXJlY3Rs eS4KPgo+IEFwYXJ0IGZyb20gdGhvc2UKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=