From: Julien Grall Subject: Re: [PATCH v4 5/8] ARM: VGIC: factor out vgic_connect_hw_irq() Date: Tue, 6 Feb 2018 14:21:06 +0000 Message-ID: References: <20180205161925.11054-1-andre.przywara@arm.com> <20180205161925.11054-6-andre.przywara@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ej47g-0002k0-03 for xen-devel@lists.xenproject.org; Tue, 06 Feb 2018 14:21:24 +0000 In-Reply-To: <20180205161925.11054-6-andre.przywara@arm.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andre Przywara , Stefano Stabellini Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org SGkgQW5kcmUsCgpPbiAwMi8wNS8yMDE4IDA0OjE5IFBNLCBBbmRyZSBQcnp5d2FyYSB3cm90ZToK PiBBdCB0aGUgbW9tZW50IHdlIGhhcHBpbHkgYWNjZXNzIFZHSUMgaW50ZXJuYWwgZGF0YSBzdHJ1 Y3R1cmVzIGxpa2UKPiB0aGUgcmFuayBhbmQgc3RydWN0IHBlbmRpbmdfaXJxIGluIGdpYy5jLCB3 aGljaCBzaG91bGQgYmUgVkdJQyBhZ25vc3RpYy4KPiAKPiBGYWN0b3Igb3V0IGEgbmV3IGZ1bmN0 aW9uIHZnaWNfY29ubmVjdF9od19pcnEoKSwgd2hpY2ggYWxsb3dzIGEgdmlydHVhbAo+IElSUSB0 byBiZSBjb25uZWN0ZWQgdG8gYSBoYXJkd2FyZSBJUlEgKHVzaW5nIHRoZSBodyBiaXQgaW4gdGhl IExSKS4KPiAKPiBUaGlzIHJlbW92ZXMgc2FpZCBhY2Nlc3NlcyB0byBWR0lDIGRhdGEgc3RydWN0 dXJlcyBhbmQgaW1wcm92ZXMgYWJzdHJhY3Rpb24uCgpJIHdhcyBleHBlY3Rpbmcgc29tZSBleHBs YW5hdGlvbiByZWdhcmRpbmcgdGhlIG5ldyBsb2NraW5nIG9yZGVyIGluIHRoZSAKY29tbWl0IG1l c3NhZ2UuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2Fy YUBhcm0uY29tPgo+IC0tLQo+ICAgeGVuL2FyY2gvYXJtL2dpYy12Z2ljLmMgICAgfCAzNiArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIHhlbi9hcmNoL2FybS9naWMuYyAg ICAgICAgIHwgNDQgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K PiAgIHhlbi9pbmNsdWRlL2FzbS1hcm0vdmdpYy5oIHwgIDIgKysKPiAgIDMgZmlsZXMgY2hhbmdl ZCwgNDggaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3hl bi9hcmNoL2FybS9naWMtdmdpYy5jIGIveGVuL2FyY2gvYXJtL2dpYy12Z2ljLmMKPiBpbmRleCAx ZDU3NDRlY2M4Li5mZmY3YzAxZWU4IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9naWMtdmdp Yy5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2dpYy12Z2ljLmMKPiBAQCAtMzk3LDYgKzM5Nyw0MiBA QCB2b2lkIGdpY19kdW1wX3ZnaWNfaW5mbyhzdHJ1Y3QgdmNwdSAqdikKPiAgICAgICAgICAgcHJp bnRrKCJQZW5kaW5nIGlycT0lZFxuIiwgcC0+aXJxKTsKPiAgIH0KPiAgIAo+ICtpbnQgdmdpY19j b25uZWN0X2h3X2lycShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQg aW50IHZpcnEsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBpcnFfZGVzYyAqZGVz YywgYm9vbCBjb25uZWN0KQo+ICt7Cj4gKyAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICsgICAg LyogVXNlIHZjcHUwIHRvIHJldHJpZXZlIHRoZSBwZW5kaW5nX2lycSBzdHJ1Y3QuIEdpdmVuIHRo YXQgd2Ugb25seQo+ICsgICAgICogcm91dGUgU1BJcyB0byBndWVzdHMsIGl0IGRvZXNuJ3QgbWFr ZSBhbnkgZGlmZmVyZW5jZS4gKi8KClBsZWFzZSBmaXggdGhlIGNvZGluZyBzdHlsZSBhcyByZXF1 ZXN0ZWQgaW4gdjMuCgo+ICsgICAgc3RydWN0IHZjcHUgKnZfdGFyZ2V0ID0gdmdpY19nZXRfdGFy Z2V0X3ZjcHUoZC0+dmNwdVswXSwgdmlycSk7Cj4gKyAgICBzdHJ1Y3QgdmdpY19pcnFfcmFuayAq cmFuayA9IHZnaWNfcmFua19pcnEodl90YXJnZXQsIHZpcnEpOwo+ICsgICAgc3RydWN0IHBlbmRp bmdfaXJxICpwID0gaXJxX3RvX3BlbmRpbmcodl90YXJnZXQsIHZpcnEpOwo+ICsgICAgaW50IHJl dCA9IDA7Cj4gKwo+ICsgICAgQVNTRVJUKGNvbm5lY3QgJiYgZGVzYyk7CgpJIGFtIG5vdCBzdXJl IHdoeSB5b3UgYWxsb3cgZGVzYyB0byBiZSBub24tTlVMTCB3aGVuIGRpc2Nvbm5lY3RpbmcgaXQg CihzZWUgbW9yZSBiZWxvdykuCgo+ICsKPiArICAgIC8qIFdlIGFyZSB0YWtpbmcgdG8gcmFuayBs b2NrIHRvIHByZXZlbnQgcGFyYWxsZWwgY29ubmVjdGlvbnMuICovCj4gKyAgICB2Z2ljX2xvY2tf cmFuayh2X3RhcmdldCwgcmFuaywgZmxhZ3MpOwo+ICsKPiArICAgIGlmICggY29ubmVjdCApCj4g KyAgICB7Cj4gKyAgICAgICAgLyogVGhlIFZJUlEgc2hvdWxkIG5vdCBiZSBhbHJlYWR5IGVuYWJs ZWQgYnkgdGhlIGd1ZXN0ICovCj4gKyAgICAgICAgaWYgKCAhcC0+ZGVzYyAmJgo+ICsgICAgICAg ICAgICAgIXRlc3RfYml0KEdJQ19JUlFfR1VFU1RfRU5BQkxFRCwgJnAtPnN0YXR1cykgKQo+ICsg ICAgICAgICAgICBwLT5kZXNjID0gZGVzYzsKPiArICAgICAgICBlbHNlCj4gKyAgICAgICAgICAg IHJldCA9IC1FQlVTWTsKPiArICAgIH0KPiArICAgIGVsc2UKPiArICAgIHsKPiArICAgICAgICBp ZiAoICFkZXNjIHx8IHAtPmRlc2MgPT0gZGVzYyApCgogRnJvbSBhIHF1aWNrIGdsYW5jZSwgbm8g Y2FsbGVyIHdpbGwgaGF2ZSBkZXNjIGlzIE5VTEwuIEV2ZW4gaWYgaXQgd2FzLCAKaXQgd2lsbCBu b3QgaGFybSBiZWNhdXNlIHAtPmRlc2Mgd2lsbCBiZSBzZXQgdG8gTlVMTC4KCj4gKyAgICAgICAg ICAgIHAtPmRlc2MgPSBOVUxMOwo+ICsgICAgfQpCdXQgbGlrZWx5IHlvdSB3YW50IHRvIHJldHVy biBhbiBlcnJvciBpZiBwLT5kZXNjICE9IGRlc2MgYXMgdGhpcyBpcyBhIAp1c2VyIGlucHV0IGVy cm9yLiBJZ25vcmluZyBpdCBpcyBhIHByZXR0eSBiYWQuCgo+ICsKPiArICAgIHZnaWNfdW5sb2Nr X3Jhbmsodl90YXJnZXQsIHJhbmssIGZsYWdzKTsKPiArCj4gKyAgICByZXR1cm4gcmV0Owo+ICt9 Cj4gKwo+ICAgLyoKPiAgICAqIExvY2FsIHZhcmlhYmxlczoKPiAgICAqIG1vZGU6IEMKCkNoZWVy cywKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94 ZW4tZGV2ZWw=