From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Use memset64() to align the ring with MI_NOOP Date: Wed, 25 Apr 2018 15:14:55 +0100 Message-ID: References: <20180425123718.16366-1-chris@chris-wilson.co.uk> <152466539413.12387.6614376748083817525@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DFE389E63 for ; Wed, 25 Apr 2018 14:14:58 +0000 (UTC) In-Reply-To: <152466539413.12387.6614376748083817525@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI1LzA0LzIwMTggMTU6MDksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA0LTI1IDE1OjAwOjQzKQo+Pgo+PiBPbiAyNS8wNC8yMDE4IDEzOjM3 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBXaGVuIGZpbGxpbmcgdGhlIHJpbmcgdG8gYWxpZ24g dGhlIGVtaXQgcG9pbnRlciB0byB0aGUgbmV4dCBjYWNoZWxpbmUsCj4+PiB1c2UgbWVtc2V0NjQo KSByYXRoZXIgdGhhbiBvcGVuLWNvZGluZyBpdC4gQXMgd2Uga25vdyB0aGF0IHdlIGFsd2F5cwo+ Pj4gaGF2ZSBhbiBldmVuIG51bWJlciBvZiBkd29yZHMsIHdlIGNhbiByZXBsYWNlIHRoZSBkd29y ZCBsb29wIHdpdGggdGhlCj4+PiBxd29yZCBlcXVpdmFsZW50Lgo+Pj4KPj4+IFNpZ25lZC1vZmYt Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4gLS0tCj4+PiAg ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAxNCArKysrKysrKy0t LS0tLQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMo LSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+PiBpbmRl eCBjNjhhYzYwNWI4YTkuLjA3YTlhMmI0YmViNyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4+PiBAQCAtMTcxNywyMiArMTcxNywyNCBAQCB1MzIgKmlu dGVsX3JpbmdfYmVnaW4oc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsIHVuc2lnbmVkIGludCBudW1f ZHdvcmRzKQo+Pj4gICAgLyogQWxpZ24gdGhlIHJpbmcgdGFpbCB0byBhIGNhY2hlbGluZSBib3Vu ZGFyeSAqLwo+Pj4gICAgaW50IGludGVsX3JpbmdfY2FjaGVsaW5lX2FsaWduKHN0cnVjdCBpOTE1 X3JlcXVlc3QgKnJxKQo+Pj4gICAgewo+Pj4gLSAgICAgaW50IG51bV9kd29yZHMgPSAocnEtPnJp bmctPmVtaXQgJiAoQ0FDSEVMSU5FX0JZVEVTIC0gMSkpIC8gc2l6ZW9mKHUzMik7Cj4+PiAtICAg ICB1MzIgKmNzOwo+Pj4gKyAgICAgaW50IG51bV9kd29yZHM7Cj4+PiArICAgICB2b2lkICpjczsK Pj4+ICAgIAo+Pj4gKyAgICAgbnVtX2R3b3JkcyA9IChycS0+cmluZy0+ZW1pdCAmIChDQUNIRUxJ TkVfQllURVMgLSAxKSkgLyBzaXplb2YodTMyKTsKPj4+ICAgICAgICBpZiAobnVtX2R3b3JkcyA9 PSAwKQo+Pj4gICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+PiAgICAKPj4+IC0gICAgIG51bV9k d29yZHMgPSBDQUNIRUxJTkVfQllURVMgLyBzaXplb2YodTMyKSAtIG51bV9kd29yZHM7Cj4+PiAr ICAgICBudW1fZHdvcmRzID0gQ0FDSEVMSU5FX0RXT1JEUyAtIG51bV9kd29yZHM7Cj4+PiArICAg ICBHRU1fQlVHX09OKG51bV9kd29yZHMgJiAxKTsKPj4+ICsKPj4+ICAgICAgICBjcyA9IGludGVs X3JpbmdfYmVnaW4ocnEsIG51bV9kd29yZHMpOwo+Pj4gICAgICAgIGlmIChJU19FUlIoY3MpKQo+ Pj4gICAgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIoY3MpOwo+Pj4gICAgCj4+PiAtICAgICB3 aGlsZSAobnVtX2R3b3Jkcy0tKQo+Pj4gLSAgICAgICAgICAgICAqY3MrKyA9IE1JX05PT1A7Cj4+ PiAtCj4+Cj4+IEJVSUxEX0JVR19PTihNSV9OT09QICE9IDApIGZvciBwYXJhbm9pZCBmdXR1cmUg cHJvb2ZpbmcsIHNpbmNlIE1JX05PT1AKPj4gaXMgbm93IG5vdCBtZW50aW9uZWQgaW4gdGhpcyBm dW5jdGlvbiwgYnV0IGlzIG1lYW50Lgo+IAo+ICgodTY0KU1JX05PT1AgPDwgMzIgfCBNSV9OT09Q KSA/CgpUaGF0IGFsc28gd29ya3MsIGNhbiBrZWVwIHRoZSByLWIuCgpSZWdhcmRzLAoKVHZydGtv Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=