From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/2] drm/amdgpu: Remove the sriov checking and add firmware checking Date: Thu, 16 Aug 2018 15:17:20 +0200 Message-ID: References: <1534424701-6723-1-git-send-email-Emily.Deng@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1534424701-6723-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Emily Deng , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMTYuMDguMjAxOCB1bSAxNTowNSBzY2hyaWViIEVtaWx5IERlbmc6Cj4gVW5pZnkgYmFyZSBt ZXRhbCBhbmQgc3Jpb3YsIGFuZCBhZGQgZmlybXdhcmUgY2hlY2tpbmcgZm9yCj4gcmVnIHdyaXRl IGFuZCByZWcgd2FpdCB1bmlmeSBjb21tYW5kLgo+Cj4gU2lnbmVkLW9mZi1ieTogRW1pbHkgRGVu ZyA8RW1pbHkuRGVuZ0BhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2dmeC5oIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2dm eF92OV8wLmMgICB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAgMiBm aWxlcyBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dmeC5oIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dmeC5oCj4gaW5kZXggNTNlOWUyYS4uZjE3MmU5MiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2Z4LmgKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2Z4LmgKPiBAQCAtMjc0LDYg KzI3NCw4IEBAIHN0cnVjdCBhbWRncHVfZ2Z4IHsKPiAgIAl1aW50MzJfdAkJCXJsY19zcmxzX2Zl YXR1cmVfdmVyc2lvbjsKPiAgIAl1aW50MzJfdAkJCW1lY19mZWF0dXJlX3ZlcnNpb247Cj4gICAJ dWludDMyX3QJCQltZWMyX2ZlYXR1cmVfdmVyc2lvbjsKPiArCWJvb2wJCQkJbWVjX2Z3X3dyaXRl X3dhaXQ7Cj4gKwlib29sCQkJCW1lX2Z3X3dyaXRlX3dhaXQ7Cj4gICAJc3RydWN0IGFtZGdwdV9y aW5nCQlnZnhfcmluZ1tBTURHUFVfTUFYX0dGWF9SSU5HU107Cj4gICAJdW5zaWduZWQJCQludW1f Z2Z4X3JpbmdzOwo+ICAgCXN0cnVjdCBhbWRncHVfcmluZwkJY29tcHV0ZV9yaW5nW0FNREdQVV9N QVhfQ09NUFVURV9SSU5HU107Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2dmeF92OV8wLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9nZnhfdjlfMC5jCj4g aW5kZXggNzZkOTc5ZS4uNzZlODk3MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9nZnhfdjlfMC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZ2Z4 X3Y5XzAuYwo+IEBAIC00ODIsNiArNDgyLDQ3IEBAIHN0YXRpYyB2b2lkIGdmeF92OV8wX2luaXRf cmxjX2V4dF9taWNyb2NvZGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICAJCQlsZTMy X3RvX2NwdShybGNfaGRyLT5yZWdfbGlzdF9mb3JtYXRfZGlyZWN0X3JlZ19saXN0X2xlbmd0aCk7 Cj4gICB9Cj4gICAKPiArc3RhdGljIHZvaWQgZ2Z4X3Y5XzBfY2hlY2tfZndfd3JpdGVfd2FpdChz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiArewo+ICsJYWRldi0+Z2Z4Lm1lX2Z3X3dyaXRl X3dhaXQgPSBmYWxzZTsKPiArCWFkZXYtPmdmeC5tZWNfZndfd3JpdGVfd2FpdCA9IGZhbHNlOwo+ ICsKPiArCXN3aXRjaCAoYWRldi0+YXNpY190eXBlKSB7Cj4gKwljYXNlIENISVBfVkVHQTEwOgo+ ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3ZlcnNpb24gPj0gMHgwMDAwMDA5YykgJiYgKGFkZXYt PmdmeC5tZV9mZWF0dXJlX3ZlcnNpb24gPj0gNDIpICYmCj4gKwkJCShhZGV2LT5nZngucGZwX2Z3 X3ZlcnNpb24gPj0gIDB4MDAwMDAwYjEpICYmIChhZGV2LT5nZngucGZwX2ZlYXR1cmVfdmVyc2lv biA+PSA0MikpCj4gKwkJCQlhZGV2LT5nZngubWVfZndfd3JpdGVfd2FpdCA9IHRydWU7CgpXZWxs IHRoYXQgbG9va3MgbGlrZSB0aGUgY29ycmVjdCBzb2x1dGlvbiB0byBtZS4gT25seSBhIG5pdCBw aWNrIGxlZnQgdG8gCmZpeCwgdGhlIGNvZGluZyBzdHlsZSBsb29rcyBhIGJpdCBvZmYuCgpGb3Ig ZXhhbXBsZSB0aGUgImlmIiBzaG91bGQgYmUgaW5kZW50ZWQgc28gdGhhdCAiKGFkZXYuLiIgaW4g Ym90aCBsaW5lcyAKaXMgb24gdGhlIHNhbWUgY29sdW1uOgoKaWYgKChhZGV2Li4uLiApICYmCiDC oMKgwqAgKGFkZXYuLi4uCgpBbmQgdGhlICJhZGV2LT5nZngubWVfZndfd3JpdGVfd2FpdCA9IHRy dWU7IiBpcyB0byBmYXIgdG8gdGhlIHJpZ2h0LgoKV2l0aCB0aGF0IGZpeGVkIHRoZSBwYXRjaCBp cyBBY2tlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyAKPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4u CgpSZWdhcmRzLApDaHJpc3RpYW4uCgo+ICsKPiArCQlpZiAoKGFkZXYtPmdmeC5tZWNfZndfdmVy c2lvbiA+PSAgMHgwMDAwMDE5MykgJiYgKGFkZXYtPmdmeC5tZWNfZmVhdHVyZV92ZXJzaW9uID49 IDQyKSkKPiArCQkJCWFkZXYtPmdmeC5tZWNfZndfd3JpdGVfd2FpdCA9IHRydWU7Cj4gKwkJYnJl YWs7Cj4gKwljYXNlIENISVBfVkVHQTEyOgo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3ZlcnNp b24gPj0gMHgwMDAwMDA5YykgJiYgKGFkZXYtPmdmeC5tZV9mZWF0dXJlX3ZlcnNpb24gPj0gNDQp ICYmCj4gKwkJCShhZGV2LT5nZngucGZwX2Z3X3ZlcnNpb24gPj0gIDB4MDAwMDAwYjIpICYmIChh ZGV2LT5nZngucGZwX2ZlYXR1cmVfdmVyc2lvbiA+PSA0NCkpCj4gKwkJCQlhZGV2LT5nZngubWVf Zndfd3JpdGVfd2FpdCA9IHRydWU7Cj4gKwo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lY19md192ZXJz aW9uID49ICAweDAwMDAwMTk2KSAmJiAoYWRldi0+Z2Z4Lm1lY19mZWF0dXJlX3ZlcnNpb24gPj0g NDQpKQo+ICsJCQkJYWRldi0+Z2Z4Lm1lY19md193cml0ZV93YWl0ID0gdHJ1ZTsKPiArCQlicmVh azsKPiArCWNhc2UgQ0hJUF9WRUdBMjA6Cj4gKwkJaWYgKChhZGV2LT5nZngubWVfZndfdmVyc2lv biA+PSAweDAwMDAwMDljKSAmJiAoYWRldi0+Z2Z4Lm1lX2ZlYXR1cmVfdmVyc2lvbiA+PSA0NCkg JiYKPiArCQkJKGFkZXYtPmdmeC5wZnBfZndfdmVyc2lvbiA+PSAgMHgwMDAwMDBiMikgJiYgKGFk ZXYtPmdmeC5wZnBfZmVhdHVyZV92ZXJzaW9uID49IDQ0KSkKPiArCQkJCWFkZXYtPmdmeC5tZV9m d193cml0ZV93YWl0ID0gdHJ1ZTsKPiArCj4gKwkJaWYgKChhZGV2LT5nZngubWVjX2Z3X3ZlcnNp b24gPj0gIDB4MDAwMDAxOTcpICYmIChhZGV2LT5nZngubWVjX2ZlYXR1cmVfdmVyc2lvbiA+PSA0 NCkpCj4gKwkJCQlhZGV2LT5nZngubWVjX2Z3X3dyaXRlX3dhaXQgPSB0cnVlOwo+ICsJCWJyZWFr Owo+ICsJY2FzZSBDSElQX1JBVkVOOgo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lX2Z3X3ZlcnNpb24g Pj0gMHgwMDAwMDA5YykgJiYgKGFkZXYtPmdmeC5tZV9mZWF0dXJlX3ZlcnNpb24gPj0gNDIpICYm Cj4gKwkJCShhZGV2LT5nZngucGZwX2Z3X3ZlcnNpb24gPj0gIDB4MDAwMDAwYjEpICYmIChhZGV2 LT5nZngucGZwX2ZlYXR1cmVfdmVyc2lvbiA+PSA0MikpCj4gKwkJCQlhZGV2LT5nZngubWVfZndf d3JpdGVfd2FpdCA9IHRydWU7Cj4gKwo+ICsJCWlmICgoYWRldi0+Z2Z4Lm1lY19md192ZXJzaW9u ID49ICAweDAwMDAwMTkyKSAmJiAoYWRldi0+Z2Z4Lm1lY19mZWF0dXJlX3ZlcnNpb24gPj0gNDIp KQo+ICsJCQkJYWRldi0+Z2Z4Lm1lY19md193cml0ZV93YWl0ID0gdHJ1ZTsKPiArCQlicmVhazsK PiArCX0KPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQgZ2Z4X3Y5XzBfaW5pdF9taWNyb2NvZGUoc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpCj4gICB7Cj4gICAJY29uc3QgY2hhciAqY2hpcF9uYW1l Owo+IEBAIC03MTYsNiArNzU3LDcgQEAgc3RhdGljIGludCBnZnhfdjlfMF9pbml0X21pY3JvY29k ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAl9Cj4gICAKPiAgIG91dDoKPiArCWdm eF92OV8wX2NoZWNrX2Z3X3dyaXRlX3dhaXQoYWRldik7Cj4gICAJaWYgKGVycikgewo+ICAgCQlk ZXZfZXJyKGFkZXYtPmRldiwKPiAgIAkJCSJnZng5OiBGYWlsZWQgdG8gbG9hZCBmaXJtd2FyZSBc IiVzXCJcbiIsCj4gQEAgLTQzNDgsOCArNDM5MCwxMSBAQCBzdGF0aWMgdm9pZCBnZnhfdjlfMF9y aW5nX2VtaXRfcmVnX3dyaXRlX3JlZ193YWl0KHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywKPiAg IAkJCQkJCSAgdWludDMyX3QgcmVmLCB1aW50MzJfdCBtYXNrKQo+ICAgewo+ICAgCWludCB1c2Vw ZnAgPSAocmluZy0+ZnVuY3MtPnR5cGUgPT0gQU1ER1BVX1JJTkdfVFlQRV9HRlgpOwo+ICsJc3Ry dWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSByaW5nLT5hZGV2Owo+ICsJYm9vbCBmd192ZXJzaW9u X29rID0gKHJpbmctPmZ1bmNzLT50eXBlID09IEFNREdQVV9SSU5HX1RZUEVfR0ZYKSA/Cj4gKwkJ YWRldi0+Z2Z4Lm1lX2Z3X3dyaXRlX3dhaXQgOiBhZGV2LT5nZngubWVjX2Z3X3dyaXRlX3dhaXQ7 Cj4gICAKPiAtCWlmIChhbWRncHVfc3Jpb3ZfdmYocmluZy0+YWRldikpCj4gKwlpZiAoZndfdmVy c2lvbl9vaykKPiAgIAkJZ2Z4X3Y5XzBfd2FpdF9yZWdfbWVtKHJpbmcsIHVzZXBmcCwgMCwgMSwg cmVnMCwgcmVnMSwKPiAgIAkJCQkgICAgICByZWYsIG1hc2ssIDB4MjApOwo+ICAgCWVsc2UKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFp bGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=