From: "flichtenheld (Code Review)" Date: Wed, 25 Mar 2026 15:09:44 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xGVkw6IrcGY="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: configure: Remove --enable-strict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --xGVkw6IrcGY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=3Demail to review the following change. Change subject: configure: Remove --enable-strict ...................................................................... configure: Remove --enable-strict Both -Wsign-compare (via -Wextra) and -Wuninitalized (via -Wall) are enabled by default. So this does not do anything anymore. While here also remove rest of --enable-strict-options which was mostly removed in commit 2104ea62430e4d203f2cd998e053f4192798b9f1 Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Signed-off-by: Frank Lichtenheld --- M CMakeLists.txt M configure.ac 2 files changed, 1 insertion(+), 19 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index 198c98f..f9cbbfd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -112,7 +112,7 @@ add_link_options("$<$:/CETCOMPAT>") endif() else () - add_compile_options(-Wall -Wuninitialized) + add_compile_options(-Wall) check_and_add_compiler_flag(-Wno-stringop-truncation NoStringOpTruncat= ion) check_and_add_compiler_flag(-Wstrict-prototypes StrictPrototypes) check_and_add_compiler_flag(-Wold-style-definition OldStyleDefinition) diff --git a/configure.ac b/configure.ac index ecef2b9..5da877a 100644 --- a/configure.ac +++ b/configure.ac @@ -203,13 +203,6 @@ ) AC_ARG_ENABLE( - [strict], - [AS_HELP_STRING([--enable-strict], [enable strict compiler warnings (debu= gging option) @<:@default=3Dno@:>@])], - , - [enable_strict=3D"no"] -) - -AC_ARG_ENABLE( [pedantic], [AS_HELP_STRING([--enable-pedantic], [enable pedantic compiler warnings, = will not generate a working executable (debugging option) @<:@default=3Dno@= :>@])], , @@ -224,13 +217,6 @@ ) AC_ARG_ENABLE( - [strict-options], - [AS_HELP_STRING([--enable-strict-options], [enable strict options check b= etween peers (debugging option) @<:@default=3Dno@:>@])], - , - [enable_strict_options=3D"no"] -) - -AC_ARG_ENABLE( [selinux], [AS_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default= =3Dno@:>@])], , @@ -1270,13 +1256,9 @@ fi if test "${enable_pedantic}" =3D "yes"; then - enable_strict=3D"yes" CFLAGS=3D"${CFLAGS} -pedantic" AC_DEFINE([PEDANTIC], [1], [Enable pedantic mode]) fi -if test "${enable_strict}" =3D "yes"; then - CFLAGS=3D"${CFLAGS} -Wsign-compare -Wuninitialized" -fi if test "${enable_werror}" =3D "yes"; then CFLAGS=3D"${CFLAGS} -Werror" fi -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1590?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358b61c9e1045725 Gerrit-Change-Number: 1590 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --xGVkw6IrcGY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

configure: Remove --enable-strict

Bo= th -Wsign-compare (via -Wextra) and -Wuninitalized (via
-Wall) are enabl= ed by default. So this does not do anything
anymore.

While here a= lso remove rest of --enable-strict-options which
was mostly removed in c= ommit
2104ea62430e4d203f2cd998e053f4192798b9f1

Change-Id: I53e7b9= 84980cb1e2b3f68e80358b61c9e1045725
Signed-off-by: Frank Lichtenheld <= frank@...2641...>
---
M CMakeLists.txt
M configure.ac
2 file= s changed, 1 insertion(+), 19 deletions(-)

git p=
ull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/1590/1
d= iff --git a/CMakeLists.txt b/CMakeLists.txt
index 198c98f..= f9cbbfd 100644
--- a/CMakeLists.txt
+++ b/C= MakeLists.txt
@@ -112,7 +112,7 @@
= add_link_options("$<$<CONFIG:Release>:/CETCOMPAT>")
endif()
else ()
- add_compile_options(-Wall -Wuninitializ= ed)
+ add_compile_= options(-Wall)
check_and_add_compiler_flag(-Wno-string= op-truncation NoStringOpTruncation)
check_and_add_comp= iler_flag(-Wstrict-prototypes StrictPrototypes)
check_= and_add_compiler_flag(-Wold-style-definition OldStyleDefinition)
= diff --git a/configure.ac b/configure.ac
index ecef2b= 9..5da877a 100644
--- a/configure.ac
+++ b/= configure.ac
@@ -203,13 +203,6 @@
)=

AC_ARG_ENABLE(
- [strict],
- [AS_HELP_STRING([--enable-strict], [enable strict compiler warn= ings (debugging option) @<:@default=3Dno@:>@])],
- ,
- [enable_strict=3D"no"]
-)
-
-AC_ARG_ENABLE(<= /span>
[pedantic],
[AS_HELP_STRING([--enable-p= edantic], [enable pedantic compiler warnings, will not generate a working e= xecutable (debugging option) @<:@default=3Dno@:>@])],
,

@@ -224,13 +217,6 @@
)

AC_ARG_ENABLE(
- [strict-options],
- [AS_HELP_STRING([--enable-strict-options], [enable strict optio= ns check between peers (debugging option) @<:@default=3Dno@:>@])],
- ,
- [enable_strict_options=3D"no"]
-)
-
-AC_ARG_ENABLE(
[selinux],
[A= S_HELP_STRING([--enable-selinux], [enable SELinux support @<:@default=3D= no@:>@])],
,
@@ -1270,13 +1256,9 @@
fi

if test "${enable= _pedantic}" =3D "yes"; then
- enable_strict=3D"yes"
CFL= AGS=3D"${CFLAGS} -pedantic"
AC_DEFINE([PEDANTIC= ], [1], [Enable pedantic mode])
fi
-if test "${enable_strict}" =3D &q= uot;yes"; then
- C= FLAGS=3D"${CFLAGS} -Wsign-compare -Wuninitialized"
-fi

if test "${= enable_werror}" =3D "yes"; then
CFLAGS=3D&= quot;${CFLAGS} -Werror"
fi

To view, visit change 1590. To unsubscribe, or for help writing mail = filters, visit s= ettings.

=
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53e7b984980cb1e2b3f68e80358= b61c9e1045725
Gerrit-Change-Number: 1590
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --xGVkw6IrcGY=--