From: "stipa (Code Review)" Date: Wed, 10 Jan 2024 10:16:58 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="OROlATO0yKo="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: flichtenheld , cron2 , plaisthos , openvpn-devel --OROlATO0yKo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 4: (5 comments) File include/openvpn-msg.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/b79b7779_628d912d : PS4, Line 27: #include why those are needed here? File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/e376b80f_a07c08de : PS4, Line 621: do_block_local(const struct route_list *rl) since this function doesn't really do any blocking and only check options, = maybe rename to "is_block_local_needed()" ? File src/openvpn/wfp_block.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/98a45da8_a4f2c958 : PS4, Line 310: /* Fifth filter. Permit IPv4 for the VPN interface. Permit DNS or all IPv4 traffic for the VPN interface? http://gerrit.openvpn.net/c/openvpn/+/489/comment/d9207c40_fa180f47 : PS4, Line 327: /* Sixth filter. Permit IPv6 for the VPN interface. Same as above - Permit DNS or all IPv6 traffic for the VPN interface? File src/openvpn/win32.h: http://gerrit.openvpn.net/c/openvpn/+/489/comment/55c79df7_1e0f8209 : PS4, Line 28: #include why those changes? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: d12fk Gerrit-Comment-Date: Wed, 10 Jan 2024 10:16:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --OROlATO0yKo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, d12fk, flichtenheld, plais= thos.

View C= hange

5 comments:

    =
  • File include/openvpn-msg.h:

  • File src/openvpn/route.c:

      Patch Set #4, Line 621: do_block_local(const struct route_list *rl)

      since this function does= n't really do any blocking and only check options, maybe rename to &quo= t;is_block_local_needed()" ?

  • File src/openvpn/wfp_block.c:

    • Patch Set #4, Line 310: /* Fifth filter. Permit IPv4 for the VPN= interface.

      Permit DNS or all IPv4 traffic for the VPN interface?

    • Patch Set #4, Line 327: /* Sixth filter. Permit IPv6 for the VPN interface.

      Same as above - Permit= DNS or all IPv6 traffic for the VPN interface?

  • File src/openvpn/win32.h:

To view, visit change 489. To unsubscribe, or for = help writing mail filters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f= 071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 4
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Wed, 10 Jan 2024 10:16:58= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--OROlATO0yKo=--