From: "selvanair (Code Review)" Date: Tue, 31 Mar 2026 23:41:51 +0000 References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="G0Kc0DsyUTI="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add unit tests for 'auth-user-pass username-only' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --G0Kc0DsyUTI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail to review the following change. Change subject: Add unit tests for 'auth-user-pass username-only' ...................................................................... Add unit tests for 'auth-user-pass username-only' Inlined, file and stdin inputs tested. Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Signed-off-by: Selva Nair --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1602/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 16e0535..c4082e9 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -222,6 +222,16 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, "cpassword"); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_INLINE_CREDS | GET_USER_PASS_USERNAME_ONLY; + /*FIXME: query_user_exec() needs to be called even though nothing queu= ed */ + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "iuser\n", "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "iuser"); + assert_string_equal(up.password, "[[BLANK]]"); } /* NOTE: expect_assert_failure does not seem to work with MSVC */ @@ -282,6 +292,17 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, ""); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_USERNAME_ONLY; + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "stdin", "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + assert_string_equal(up.password, "[[BLANK]]"); } /* NOTE: expect_assert_failure does not seem to work with MSVC */ @@ -353,6 +374,17 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, "fuser"); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_USERNAME_ONLY; + /*FIXME: query_user_exec() needs to be called even though nothing queu= ed */ + will_return(query_user_exec_builtin, true); + openvpn_test_get_srcdir_dir(authfile, PATH_MAX, "input/user_only.txt"); + assert_true(get_user_pass_cr(&up, authfile, "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "fuser"); + assert_string_equal(up.password, "[[BLANK]]"); } #ifdef ENABLE_MANAGEMENT -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Gerrit-Change-Number: 1602 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --G0Kc0DsyUTI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

selvanair would like plaisthos to review this change.

V= iew Change

Add unit tests for 'auth-user-pass user=
name-only'

Inlined, file and stdin inputs tested.

Change-= Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d
Signed-off-by: Selva Nair = <selva.nair@...277...>
---
M tests/unit_tests/openvpn/test_user= _pass.c
1 file changed, 32 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02= /1602/1
diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/te=
sts/unit_tests/openvpn/test_user_pass.c
index 16e0535..c408= 2e9 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c<= /span>
+++ b/tests/unit_tests/openvpn/test_user_pass.c
<= span>@@ -222,6 +222,16 @@

assert_true(up.defined);
assert_string_equal(up.username, "user");
assert_string_equal(up.password, "cpassword");
+
+ reset_user_pass(&up);
<= span style=3D"color: hsl(120, 100%, 40%);">+

+ flags =3D GET_USER_PASS_INLINE_CREDS | GET_USE= R_PASS_USERNAME_ONLY;
+ /*FIXME: query_user_exec() needs to be called even though nothing que= ued */
+ will_retu= rn(query_user_exec_builtin, true);
+ assert_true(get_user_pass_cr(&up, "iuser\n"= ;, "UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "iuser&quo= t;);
+ assert_stri= ng_equal(up.password, "[[BLANK]]");
}
=
/* NOTE: expect_assert_failure does not seem to wo= rk with MSVC */
@@ -282,6 +292,17 @@
a= ssert_true(up.defined);
assert_string_equal(up.usernam= e, "user");
assert_string_equal(up.password,= "");
+
+ reset_user_pass(&am= p;up);
+
+ flags =3D GET_USER_PASS_USER= NAME_ONLY;

+ expec= t_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT User= name:");
+ wi= ll_return(query_user_exec_builtin, "cuser");
+ will_return(query_user_exec_builtin,= true);
+ assert_t= rue(get_user_pass_cr(&up, "stdin", "UT", flags, NUL= L));
+ assert_true= (up.defined);
+ as= sert_string_equal(up.username, "cuser");
+ assert_string_equal(up.password, "[= [BLANK]]");
}

/* N= OTE: expect_assert_failure does not seem to work with MSVC */
@@ -353,6 +374,17 @@

assert_true(up.defined);
assert_string_equal(up.username, "user");<= br> assert_string_equal(up.password, "fuser");+
+ reset_user_pass(&up);
+
+ flags =3D GET_USER_PASS_USERNAME_ONLY;
+ /*FIXME: query_user_exec() ne= eds to be called even though nothing queued */

+ will_return(query_user_exec_builtin, true);<= /span>
+ openvpn_test_get= _srcdir_dir(authfile, PATH_MAX, "input/user_only.txt");+ assert_true(get_user_pass= _cr(&up, authfile, "UT", flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.usern= ame, "fuser");

+ assert_string_equal(up.password, "[[BLANK]]"); }

#ifdef ENABLE_MANAGEMENT

To view, visit change 1602. To unsubscribe, or f= or help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a7= 02a140b0ac23d
Gerrit-Change-Number: 1602
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --G0Kc0DsyUTI=--