From: Lionel Landwerlin Subject: Re: [PATCH 1/2] drm/i915: Fix error checking/locking in perf/lookup_context() Date: Fri, 14 Jul 2017 16:59:36 +0100 Message-ID: References: <20170714151242.517-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5526F6E87D for ; Fri, 14 Jul 2017 15:59:39 +0000 (UTC) In-Reply-To: <20170714151242.517-1-imre.deak@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UmV2aWV3ZWQtYnk6IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwuZy5sYW5kd2VybGluQGludGVs LmNvbT4KCk9uIDE0LzA3LzE3IDE2OjEyLCBJbXJlIERlYWsgd3JvdGU6Cj4gMWFjZmMxMDRjZGY4 IG1pc3NlZCB0byBjb252ZXJ0IHRoaXMgb25lIGNhbGxlciB0byBiZSBsb2NrbGVzcy4gVGhlIHNp ZGUKPiBlZmZlY3Qgb2YgdGhhdCB3YXMgdGhhdCB0aGUgZXJyb3IgY2hlY2sgaW4gbG9va3VwX2Nv bnRleHQoKSBiZWNhbWUKPiBpbmNvcnJlY3QuIENvbnZlcnQgbm93IHRoaXMgY2FsbGVyIHRvby4K Pgo+IEZpeGVzOiAxYWNmYzEwNGNkZiAoImRybS9pOTE1OiBFbmFibGUgcmN1LW9ubHkgY29udGV4 dCBsb29rdXBzIikKPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYyB8IDMyICsrKysrLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAyNyBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Bl cmYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5jCj4gaW5kZXggZDlmNzdhNGQ4 NWRiLi45NjY4MmZkODZmODIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9wZXJmLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BlcmYuYwo+IEBAIC0y NDgzLDI3ICsyNDgzLDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgZm9w cyA9IHsKPiAgIH07Cj4gICAKPiAgIAo+IC1zdGF0aWMgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQg Kgo+IC1sb29rdXBfY29udGV4dChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g LQkgICAgICAgc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2LAo+IC0JICAg ICAgIHUzMiBjdHhfdXNlcl9oYW5kbGUpCj4gLXsKPiAtCXN0cnVjdCBpOTE1X2dlbV9jb250ZXh0 ICpjdHg7Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCXJldCA9IGk5MTVfbXV0ZXhfbG9ja19pbnRlcnJ1 cHRpYmxlKCZkZXZfcHJpdi0+ZHJtKTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIEVSUl9QVFIo cmV0KTsKPiAtCj4gLQljdHggPSBpOTE1X2dlbV9jb250ZXh0X2xvb2t1cChmaWxlX3ByaXYsIGN0 eF91c2VyX2hhbmRsZSk7Cj4gLQlpZiAoIUlTX0VSUihjdHgpKQo+IC0JCWk5MTVfZ2VtX2NvbnRl eHRfZ2V0KGN0eCk7Cj4gLQo+IC0JbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9t dXRleCk7Cj4gLQo+IC0JcmV0dXJuIGN0eDsKPiAtfQo+IC0KPiAgIC8qKgo+ICAgICogaTkxNV9w ZXJmX29wZW5faW9jdGxfbG9ja2VkIC0gRFJNIGlvY3RsKCkgZm9yIHVzZXJzcGFjZSB0byBvcGVu IGEgc3RyZWFtIEZECj4gICAgKiBAZGV2X3ByaXY6IGk5MTUgZGV2aWNlIGluc3RhbmNlCj4gQEAg LTI1NDUsMTIgKzI1MjQsMTEgQEAgaTkxNV9wZXJmX29wZW5faW9jdGxfbG9ja2VkKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkJdTMyIGN0eF9oYW5kbGUgPSBwcm9wcy0+ Y3R4X2hhbmRsZTsKPiAgIAkJc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2 ID0gZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gICAKPiAtCQlzcGVjaWZpY19jdHggPSBsb29rdXBfY29u dGV4dChkZXZfcHJpdiwgZmlsZV9wcml2LCBjdHhfaGFuZGxlKTsKPiAtCQlpZiAoSVNfRVJSKHNw ZWNpZmljX2N0eCkpIHsKPiAtCQkJcmV0ID0gUFRSX0VSUihzcGVjaWZpY19jdHgpOwo+IC0JCQlp ZiAocmV0ICE9IC1FSU5UUikKPiAtCQkJCURSTV9ERUJVRygiRmFpbGVkIHRvIGxvb2sgdXAgY29u dGV4dCB3aXRoIElEICV1IGZvciBvcGVuaW5nIHBlcmYgc3RyZWFtXG4iLAo+IC0JCQkJCSAgY3R4 X2hhbmRsZSk7Cj4gKwkJc3BlY2lmaWNfY3R4ID0gaTkxNV9nZW1fY29udGV4dF9sb29rdXAoZmls ZV9wcml2LCBjdHhfaGFuZGxlKTsKPiArCQlpZiAoIXNwZWNpZmljX2N0eCkgewo+ICsJCQlEUk1f REVCVUcoIkZhaWxlZCB0byBsb29rIHVwIGNvbnRleHQgd2l0aCBJRCAldSBmb3Igb3BlbmluZyBw ZXJmIHN0cmVhbVxuIiwKPiArCQkJCSAgY3R4X2hhbmRsZSk7Cj4gKwkJCXJldCA9IC1FTk9FTlQ7 Cj4gICAJCQlnb3RvIGVycjsKPiAgIAkJfQo+ICAgCX0KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK