From: "ordex (Code Review)"
Date: Thu, 17 Apr 2025 11:48:56 +0000
In-Reply-To:
References:
Reply-To: antonio@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="aAUlov7qsdU="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c:
Prevent potential double-free
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: stipa
Cc: plaisthos , flichtenheld , openvpn-devel
--aAUlov7qsdU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/942?usp=3Demail )
Change subject: ssl_openssl.c: Prevent potential double-free
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/942/comment/6db32f5d_f59632ce :
PS1, Line 1189: if (info)
> there is no need for this check. Like most free() methods, passing NULL l=
eads to nothing. [=E2=80=A6]
Done
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/942/comment/8c265995_42864120 :
PS3, Line 1190: info =3D NULL;
what is this for? the variable is going out of scope at this point.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 3
Gerrit-Owner: stipa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: ordex
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:48:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--aAUlov7qsdU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa. <=
/p>
Patch set 3:Code-Review -1=
Vi=
ew Change
2 comments:
Done
File src/openvpn/ssl_openssl.c:
<=
/ul>To view, visit change 942. To unsubscribe, or for help writing mail filte=
rs, visit settings.
<=
div itemscope itemtype=3D"http://schema.org/EmailMessage">
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03=
187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 3
Gerrit-Owner: stipa <lstipakov@...277...>=
;
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: ordex <antonio@...2726...&=
gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:48:56=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--aAUlov7qsdU=--