From: Andrey Grodzovsky Subject: Re: [PATCH 03/29] drm/amd/display: Complete TODO item: use new DRM iterator Date: Mon, 30 Oct 2017 13:18:19 -0400 Message-ID: References: <20171026183525.7532-1-harry.wentland@amd.com> <20171026183525.7532-4-harry.wentland@amd.com> <3450881e-59f5-7784-707c-fa9387d9e97e@amd.com> <87b988ad-8c7c-ec08-df65-6b4ff4c1af59@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87b988ad-8c7c-ec08-df65-6b4ff4c1af59-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Leo , Harry Wentland , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAxMC8zMC8yMDE3IDEyOjM2IFBNLCBMZW8gd3JvdGU6Cj4KPgo+IE9uIDIwMTctMTAtMjYg MTE6MDYgUE0sIEFuZHJleSBHcm9kem92c2t5IHdyb3RlOgo+Pgo+Pgo+PiBPbiAyMDE3LTEwLTI2 IDAyOjM0IFBNLCBIYXJyeSBXZW50bGFuZCB3cm90ZToKPj4+IEZyb206ICJMZW8gKFN1bnBlbmcp IExpIiA8c3VucGVuZy5saUBhbWQuY29tPgo+Pj4KPj4+IEFiYW5kb24gbmV3X2NydGNzIGFycmF5 IGFuZCB1c2UgZm9yX2VhY2hfbmV3IGl0ZXJhdG9yIHRvIGFjcXVpcmUgbmV3Cj4+PiBjcnRjcy4K Pj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMZW8gKFN1bnBlbmcpIExpIDxzdW5wZW5nLmxpQGFtZC5j b20+Cj4+PiBSZXZpZXdlZC1ieTogSGFycnkgV2VudGxhbmQgPEhhcnJ5LldlbnRsYW5kQGFtZC5j b20+Cj4+PiAtLS0KPj4+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9h bWRncHVfZG0uYyB8IDM2IAo+Pj4gKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPj4+ICAgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j IAo+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5j Cj4+PiBpbmRleCA0NDJiMzk5YTk0MDAuLjU5MGY4MGQyOWI1NiAxMDA2NDQKPj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmMKPj4+IEBA IC00MDEzLDEwICs0MDEzLDggQEAgc3RhdGljIHZvaWQgCj4+PiBhbWRncHVfZG1fYXRvbWljX2Nv bW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPj4+ICAgICAgIHN0cnVj dCBhbWRncHVfZGlzcGxheV9tYW5hZ2VyICpkbSA9ICZhZGV2LT5kbTsKPj4+ICAgICAgIHN0cnVj dCBkbV9hdG9taWNfc3RhdGUgKmRtX3N0YXRlOwo+Pj4gICAgICAgdWludDMyX3QgaSwgajsKPj4+ IC0gICAgdWludDMyX3QgbmV3X2NydGNzX2NvdW50ID0gMDsKPj4+ICAgICAgIHN0cnVjdCBkcm1f Y3J0YyAqY3J0YzsKPj4+ICAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3Rh dGUsICpuZXdfY3J0Y19zdGF0ZTsKPj4+IC0gICAgc3RydWN0IGFtZGdwdV9jcnRjICpuZXdfY3J0 Y3NbTUFYX1NUUkVBTVNdOwo+Pj4gICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICAgICAg IGJvb2wgd2FpdF9mb3JfdmJsYW5rID0gdHJ1ZTsKPj4+ICAgICAgIHN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3I7Cj4+PiBAQCAtNDA3NSwyNSArNDA3Myw5IEBAIHN0YXRpYyB2b2lkIAo+ Pj4gYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUpCj4+PiAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPj4+ICAgICAgICAgICAgICAg fQo+Pj4gLQo+Pj4gICAgICAgICAgICAgICBpZiAoZG1fb2xkX2NydGNfc3RhdGUtPnN0cmVhbSkK Pj4+ICAgICAgICAgICAgICAgICAgIHJlbW92ZV9zdHJlYW0oYWRldiwgYWNydGMsIAo+Pj4gZG1f b2xkX2NydGNfc3RhdGUtPnN0cmVhbSk7Cj4+PiAtCj4+PiAtICAgICAgICAgICAgLyoKPj4+IC0g ICAgICAgICAgICAgKiB0aGlzIGxvb3Agc2F2ZXMgc2V0IG1vZGUgY3J0Y3MKPj4+IC0gICAgICAg ICAgICAgKiB3ZSBuZWVkZWQgdG8gZW5hYmxlIHZibGFua3Mgb25jZSBhbGwKPj4+IC0gICAgICAg ICAgICAgKiByZXNvdXJjZXMgYWNxdWlyZWQgaW4gZGMgYWZ0ZXIgZGNfY29tbWl0X3N0cmVhbXMK Pj4+IC0gICAgICAgICAgICAgKi8KPj4+IC0KPj4+IC0gICAgICAgICAgICAvKlRPRE8gbW92ZSBh bGwgdGhpcyBpbnRvIGRtX2NydGNfc3RhdGUsIGdldCByaWQgb2YKPj4+IC0gICAgICAgICAgICAg KiBuZXdfY3J0Y3MgYXJyYXkgYW5kIHVzZSBvbGQgYW5kIG5ldyBhdG9taWMgc3RhdGVzCj4+PiAt ICAgICAgICAgICAgICogaW5zdGVhZAo+Pj4gLSAgICAgICAgICAgICAqLwo+Pj4gLSAgICAgICAg ICAgIG5ld19jcnRjc1tuZXdfY3J0Y3NfY291bnRdID0gYWNydGM7Cj4+PiAtICAgICAgICAgICAg bmV3X2NydGNzX2NvdW50Kys7Cj4+PiAtCj4+PiAtICAgICAgICAgICAgbmV3X2NydGNfc3RhdGUg PSBkcm1fYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgCj4+PiBjcnRjKTsKPj4+ICAg ICAgICAgICAgICAgYWNydGMtPmVuYWJsZWQgPSB0cnVlOwo+Pj4gICAgICAgICAgICAgICBhY3J0 Yy0+aHdfbW9kZSA9IG5ld19jcnRjX3N0YXRlLT5tb2RlOwo+Pj4gICAgICAgICAgICAgICBjcnRj LT5od21vZGUgPSBuZXdfY3J0Y19zdGF0ZS0+bW9kZTsKPj4+IEBAIC00MjIxLDE4ICs0MjAzLDI4 IEBAIHN0YXRpYyB2b2lkIAo+Pj4gYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbChzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4+PiAgICAgICAgICAgICAgIGRtX2Vycm9yKCIlczog RmFpbGVkIHRvIHVwZGF0ZSBzdHJlYW0gc2NhbGluZyFcbiIsIAo+Pj4gX19mdW5jX18pOwo+Pj4g ICAgICAgfQo+Pj4gLSAgICBmb3IgKGkgPSAwOyBpIDwgbmV3X2NydGNzX2NvdW50OyBpKyspIHsK Pj4+ICsgICAgZm9yX2VhY2hfb2xkbmV3X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG9sZF9j cnRjX3N0YXRlLAo+Pj4gKyAgICAgICAgICAgIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4+PiAgICAg ICAgICAgLyoKPj4+ICAgICAgICAgICAgKiBsb29wIHRvIGVuYWJsZSBpbnRlcnJ1cHRzIG9uIG5l d2x5IGFycml2ZWQgY3J0Ywo+Pj4gICAgICAgICAgICAqLwo+Pj4gLSAgICAgICAgc3RydWN0IGFt ZGdwdV9jcnRjICphY3J0YyA9IG5ld19jcnRjc1tpXTsKPj4+ICsgICAgICAgIHN0cnVjdCBhbWRn cHVfY3J0YyAqYWNydGMgPSB0b19hbWRncHVfY3J0YyhjcnRjKTsKPj4+ICsgICAgICAgIGJvb2wg bW9kZXNldF9uZWVkZWQ7Cj4+PiAtICAgICAgICBuZXdfY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNf Z2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLCAKPj4+ICZhY3J0Yy0+YmFzZSk7Cj4+PiAgICAgICAg ICAgZG1fbmV3X2NydGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKG5ld19jcnRjX3N0YXRlKTsK Pj4+ICsgICAgICAgIGRtX29sZF9jcnRjX3N0YXRlID0gdG9fZG1fY3J0Y19zdGF0ZShvbGRfY3J0 Y19zdGF0ZSk7Cj4+PiArICAgICAgICBtb2Rlc2V0X25lZWRlZCA9IG1vZGVzZXRfcmVxdWlyZWQo Cj4+PiArICAgICAgICAgICAgICAgIG5ld19jcnRjX3N0YXRlLAo+Pj4gKyAgICAgICAgICAgICAg ICBkbV9uZXdfY3J0Y19zdGF0ZS0+c3RyZWFtLAo+Pj4gKyAgICAgICAgICAgICAgICBkbV9vbGRf Y3J0Y19zdGF0ZS0+c3RyZWFtKTsKPj4+ICsKPj4+ICsgICAgICAgIGlmIChkbV9uZXdfY3J0Y19z dGF0ZS0+c3RyZWFtID09IE5VTEwgfHwgIW1vZGVzZXRfbmVlZGVkKQo+Pj4gKyAgICAgICAgICAg IGNvbnRpbnVlOwo+Pgo+PiBJIGZlZWwgaXQncyBhIGJpdCBmdXR1cmUgYnVnIHByb25lIHRvIHJl cGVhdCB0aGUgMiBjaGVja3MgYWJvdmUgZnJvbSAKPj4gdGhlIGluaXRpYWwKPj4gZm9yX2VhY2hf Y3J0Y19pbl9zdGF0ZSBsb29wLCBzb21lYm9keSBtYWtlcyBjaGFuZ2VzIHRoZXJlIGFuZCBmb3Jn ZXQgCj4+IGFib3V0IHRoaXMgbG9vcC4KPj4gVGhlIGFycmF5IGlzIHVnbHkgYnV0IGl0IGF2b2lk cyBsb2dpYyBkdXBsaWNhdGlvbi4KPgo+IEkgdGhpbmsgYSBiZXR0ZXIgZml4IHdvdWxkIGJlIHRv IGNvbWJpbmUgdGhpcyBmb3JfZWFjaCBzZWN0aW9uIHdpdGggdGhlCj4gb25lIGFib3ZlIGl0LiBU aGUgb25seSB0aGluZyBrZWVwaW5nIHRoZW0gc2VwYXJhdGUgKG5vdCBzaG93biBpbiB0aGUKPiBh Ym92ZSBjb250ZXh0KSBpcyBhbiBgaWYgKGFkZXYtPmRtLmZyZWVzeW5jX21vZHVsZSlgIGd1YXJk LCB3aGljaCBjYW4gYmUKPiBwdWxsZWQgaW50byB0aGUgZmlyc3QgZm9yX2VhY2ggbG9vcC4gSXQg d291bGQgYWxzbyBlbGltaW5hdGUgYSBsb3Qgb2YKPiBkdXBsaWNhdGVkIGluaXRpYWxpemF0aW9u IGNvZGUuCj4KPiBUaG91Z2h0cz8KCkl0IG1pZ2h0IGJlIGEgYml0IG1vcmUgZGlmZmljdWx0IHNp bmNlIGluc2lkZSB0aGUgY2xhdXNlIGlzIGZsaXAgYW5kIAp2YmxhbmsgaW50ZXJydXB0cyBlbmFi bGluZywKYnV0IHRoZXkgcmVseSBoZWF2aWx5IG9uIGFjcnRjLT5vdGdfaW5zdCB3aGljaCBpcyBi ZWluZyBzZXQgaW4gYmV0d2Vlbi4KClRoYW5rcywKQW5kcmV5Cgo+Cj4gTGVvCj4KPj4KPj4gVGhh bmtzLAo+PiBBbmRyZXkKPj4KPj4+ICAgICAgICAgICBpZiAoYWRldi0+ZG0uZnJlZXN5bmNfbW9k dWxlKQo+Pj4gICAgICAgICAgICAgICBtb2RfZnJlZXN5bmNfbm90aWZ5X21vZGVfY2hhbmdlKAo+ Pj4gLSAgICAgICAgICAgICAgICBhZGV2LT5kbS5mcmVlc3luY19tb2R1bGUsIAo+Pj4gJmRtX25l d19jcnRjX3N0YXRlLT5zdHJlYW0sIDEpOwo+Pj4gKyAgICAgICAgICAgICAgICBhZGV2LT5kbS5m cmVlc3luY19tb2R1bGUsCj4+PiArICAgICAgICAgICAgICAgICZkbV9uZXdfY3J0Y19zdGF0ZS0+ c3RyZWFtLCAxKTsKPj4+ICAgICAgICAgICBtYW5hZ2VfZG1faW50ZXJydXB0cyhhZGV2LCBhY3J0 YywgdHJ1ZSk7Cj4+PiAgICAgICB9Cj4+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2FtZC1nZngK