Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431ADC2D0E4 for ; Tue, 17 Nov 2020 06:56:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88BE124198 for ; Tue, 17 Nov 2020 06:56:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88BE124198 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keuv1-0003Bq-95 for qemu-devel@archiver.kernel.org; Tue, 17 Nov 2020 01:56:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keuuK-0002gI-06 for qemu-devel@nongnu.org; Tue, 17 Nov 2020 01:56:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:59904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keuuI-0006Pw-Dc for qemu-devel@nongnu.org; Tue, 17 Nov 2020 01:56:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 042CDAC1F; Tue, 17 Nov 2020 06:56:01 +0000 (UTC) Subject: Re: [PATCH 7/7] scsi: move host_status handling into SCSI drivers To: Paolo Bonzini References: <20201116184041.60465-1-hare@suse.de> <20201116184041.60465-8-hare@suse.de> <08795f50-2b4e-14cb-f5dd-709b054308c0@suse.de> From: Hannes Reinecke Message-ID: Date: Tue, 17 Nov 2020 07:55:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=hare@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 01:53:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/16/20 11:00 PM, Paolo Bonzini wrote: > On 16/11/20 20:05, Hannes Reinecke wrote: >>>> +    if (sreq->host_status == SCSI_HOST_OK) { >>>> +        SCSISense sense; >>>> + >>>> +        sreq->status = >>>> scsi_sense_from_host_status(sreq->host_status, &sense); >>>> +        if (sreq->status == CHECK_CONDITION) { >>>> +            scsi_req_build_sense(sreq, sense); >>>> +        } >>>> +    } >>> >>> Should be != of course. >>> >> No. >> scsi_req_build_sense() transfers the sense code from the second argument >> into a proper SCSI sense. Which is only set if the status is >> CHECK_CONDITION... > > I mean sreq->host_status != SCSI_HOST_OK.  I might be wrong, but every > other HBA is using that... > Bah. Yes, of course, you are right. Shall I resubmit? Or how is the process nowadays? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer