Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3740CC761A6 for ; Thu, 30 Mar 2023 13:05:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.516723.801313 (Exim 4.92) (envelope-from ) id 1phrxs-0006Pf-8I; Thu, 30 Mar 2023 13:05:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 516723.801313; Thu, 30 Mar 2023 13:05:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phrxs-0006PY-5F; Thu, 30 Mar 2023 13:05:16 +0000 Received: by outflank-mailman (input) for mailman id 516723; Thu, 30 Mar 2023 13:05:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phrxq-0006OR-5s for xen-devel@lists.xenproject.org; Thu, 30 Mar 2023 13:05:14 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80c2c9de-cefb-11ed-85db-49a42c6b2330; Thu, 30 Mar 2023 15:05:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80c2c9de-cefb-11ed-85db-49a42c6b2330 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1680181512; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=adxcuJkdzQDMNqJ6me0RVhVLacrk4QCIJ2X+K9Tdhq8=; b=dHl9uvbiJGOmrQefFyIiK8Dpqc0BqqdVdLTFKcPaybWlbs4dJtVXQ+jF Zd+vDHAWfBjwHICy03ysc2bOC0CheG5tXRfVpWPZy68rNo2NGmgIBhXW/ nmS8tDsAKlj9/x/dgQ52YtVSZKAyCQobhZzJIV+eilOnq6SybqhonwS1I s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103042006 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:1OiPjq1hsBrCh86AovbD5c12kn2cJEfYwER7XKvMYLTBsI5bpzVVy mUcCmmFPPqDYTHyctF/a9zl8kkDsMTWxtZgSVFtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS+HuDgNyo4GlD5gdlPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfHE5V8 +YHM2o3clO7ucWqyqK+VcBxiZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiHJ0OxhrC/ jqYl4j/KjtHCs6W+SXGznGXnLHmpBjKWqgTDqLto5aGh3XMnzdOWXX6T2CTuvm0jFKzSvpQL kUV/mwlqq1a3FWmS8S4UxCmrXqsuBkaVNxNVeog52mlz6PO6AudQGEcQDNFYtU7sec5QDUr0 hmCmNaBLSRlt7uHSHSc3q2ZoTO7JW4eKmpqTSMbSBQt6tzqsoY1yBnICMtgeIa1ltroAirxx RiQoSE1m7IIy8kR2M2T9E3djjatq57hRxMv6wGMBCSj4x8RTIOpeoWy5V/z7f9KL4GCUh+Hs WRss9CX8eQmHZyL0iuXT40lDLyvovqILjDYqVpuBIU6sSSg/Wa5eoJd6y04I11mWu4BYiPBe kLfuQpNopRUOROCdrRraoi8D8Ary6nIFtn/UP3QKN1UbfBZbg6M/Ch0aQiQ0mbhnVI3lqcXP ZadeNyrS3EABsxP1Dq3Q+IR+bsqwCkkwiXUX5+T5x692rqDb32HYb4CNB2FaeVRxKqcrR/c6 dp3K8qAwBIZW+r7ChQ76qZKcwpMdyJiQ8mr9YoOLLXrzhda9H8JFtDKx6k+YNZfg+dtqMDU9 GG4RWZFxw+q7ZHYEjlmekyPeZu2A8ku/CJrYXB8Vbq78yN9ONjytc/zY7NyJOB6r7I7kJaYW tFfI6297uJzpiMrEtj3Rb30t8RceRuinmpi1AL1MWFkL/aMq+Ekk+IInzcDFwFUVEJbTeNk/ 9WdOvrzGPLvvThKAsfMc+6IxFisp3Ubk+8adxKWcoEKIRmyr9Y6dXKZYhoLzyckc02rKtyyi W6r7eow/7GR8+fZDvGS7Ux7k2tZO7QnRRcLd4Uqxb23KTPb7gKe/GO0a87RJWq1fDqtqM2fi RB9k6mU3AsvwAwb7OKR0t9DkcoD2jcYj+UAkFw8QS6TMArD53EJCiDu4PSjf5Zlntdx0TZak GrWkjWGEd1l4P/YLWM= IronPort-HdrOrdr: A9a23:FSnW4aMx2+eR7cBcTh2jsMiBIKoaSvp037BL7TELdfUxSKelfq +V8sjzuSWYtN9TYgBFpTn4Asi9qCrnlaKdgrNhX4tKPjOWwFdARbsKheHfKlvbakjDH4Vmup uIHZITNDS+NykcsS9W2njfL/8whPO82OSDg+PGyndkSgtnL5tn8xxyBm+gYy5LrU19dOMEKK Y= X-IronPort-AV: E=Sophos;i="5.98,303,1673931600"; d="scan'208";a="103042006" Date: Thu, 30 Mar 2023 14:05:00 +0100 From: Anthony PERARD To: Bernhard Beschow CC: , Marcel Apfelbaum , Paolo Bonzini , David Woodhouse , =?iso-8859-1?Q?Herv=E9?= Poussineau , Aurelien Jarno , Eduardo Habkost , Paul Durrant , , "Michael S. Tsirkin" , Stefano Stabellini , Richard Henderson , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Chuck Zmudzinski Subject: Re: [PATCH v3 5/6] hw/isa/piix3: Resolve redundant k->config_write assignments Message-ID: References: <20230312120221.99183-1-shentey@gmail.com> <20230312120221.99183-6-shentey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230312120221.99183-6-shentey@gmail.com> On Sun, Mar 12, 2023 at 01:02:20PM +0100, Bernhard Beschow wrote: > The previous patch unified handling of piix3_write_config() accross the > PIIX3 device models which allows for assigning k->config_write once in the > base class. > > Signed-off-by: Bernhard Beschow > Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD