From: Markus Elfring Date: Sun, 14 Jun 2020 11:31:09 +0000 Subject: Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Navid Emamdoost , dri-devel@lists.freedesktop.org Cc: Qiushi Wu , Tomeu Vizoso , David Airlie , kernel-janitors@vger.kernel.org, Kangjie Lu , linux-kernel@vger.kernel.org, Steven Price , Navid Emamdoost , Alyssa Rosenzweig , Stephen McCamant > in panfrost_job_hw_submit, … * Can the term “reference count” become relevant also for this commit message besides other possible adjustments? * Would you like to add the tag “Fixes”? … > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c … > @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js) > job, js, jc_head); > > job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START); > +out: > + pm_runtime_put_sync_autosuspend(pfdev->dev); > + return; > } … Perhaps use the label “put_sync” instead? Regards, Markus