Message-ID: Date: Thu, 14 Jul 2022 17:28:56 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220707035151.25469-1-selva.nair@...277...> From: Arne Schwabe In-Reply-To: <20220707035151.25469-1-selva.nair@...277...> Subject: Re: [Openvpn-devel] [PATCH] Fix crash in xkey-provider in msvc builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: selva.nair@...277..., openvpn-devel@lists.sourceforge.net Am 07.07.22 um 05:51 schrieb selva.nair@...277...: > From: Selva Nair > > The function signature for xkey_load_generic_key had > function pointers defined as function types that seems > to work in gcc but not in msvc. > > Fix it by changing the function signatures to what was > intended. > Also revert part of commit 627d1a3d28638... as that work- > around should be no longer required. > > Reported by: Lev Stipakov https://github.com/lstipakov > I am surprised that this commit is not a noop but it is "more" correct this. So without any idea if this actually fixes Windows or not, I approve this commit on the basis of a cosmetic fix that is actually right. Arne