From: George Dunlap Subject: Re: [PATCH RFC v4] x86/mm: Clean up p2m_finish_type_change return value Date: Wed, 27 Mar 2019 16:44:05 +0000 Message-ID: References: <20190327152107.29288-1-aisaila@bitdefender.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h9Bf1-0007bF-30 for xen-devel@lists.xenproject.org; Wed, 27 Mar 2019 16:44:19 +0000 In-Reply-To: <20190327152107.29288-1-aisaila@bitdefender.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Alexandru Stefan ISAILA , "xen-devel@lists.xenproject.org" Cc: "kevin.tian@intel.com" , "wei.liu2@citrix.com" , "jun.nakajima@intel.com" , "george.dunlap@eu.citrix.com" , "andrew.cooper3@citrix.com" , "Paul.Durrant@citrix.com" , "jbeulich@suse.com" , "roger.pau@citrix.com" List-Id: xen-devel@lists.xenproject.org T24gMy8yNy8xOSAzOjIxIFBNLCBBbGV4YW5kcnUgU3RlZmFuIElTQUlMQSB3cm90ZToKPiBJbiB0 aGUgY2FzZSBvZiBhbnkgZXJyb3JzLCBmaW5pc2hfdHlwZV9jaGFuZ2UoKSBwYXNzZXMgdmFsdWVz IHJldHVybmVkCj4gZnJvbSBwMm0tPnJlY2FsYygpIHVwIHRoZSBzdGFjayAod2l0aCBzb21lIGV4 Y2VwdGlvbnMgaW4gdGhlIGNhc2Ugd2hlcmUKPiBhbiBlcnJvciBpcyBleHBlY3RlZCk7IHRoaXMg ZXZlbnR1YWxseSBlbmRzIHVwIGJlaW5nIHJldHVybmVkIHRvIHRoZQo+IFhFTl9ET01PUF9tYXBf bWVtX3R5cGVfdG9faW9yZXFfc2VydmVyIGh5cGVyY2FsbC4KPiAKPiBIb3dldmVyLCBvbiBJbnRl bCBwcm9jZXNzb3JzIChidXQgbm90IG9uIEFNRCBwcm9jZXNzb3IpLCBwMm0tPnJlY2FsYygpCj4g Y2FuIGFsc28gcmV0dXJuICcxJyBhcyB3ZWxsIGFzICcwJy4gIFRoaXMgY2FzZSBpcyBoYW5kbGVk IHZlcnkKPiBpbmNvbnNpc3RlbnRseTogZmluaXNoX3R5cGVfY2hhbmdlKCkgd2lsbCByZXR1cm4g dGhlIHZhbHVlIG9mIHRoZSBmaW5hbAo+IGVudHJ5IGl0IGF0dGVtcHRzLCBkaXNjYXJkaW5nIHJl c3VsdHMgZm9yIG90aGVyIGVudHJpZXM7Cj4gcDJtX2ZpbmlzaF90eXBlX2NoYW5nZSgpIHdpbGwg YXR0ZW1wdCB0byBhY2N1bXVsYXRlICcxJ3MsIHNvIHRoYXQgaXQKPiByZXR1cm5zICcxJyBpZiBh bnkgb2YgdGhlIGNhbGxzIHRvIGZpbmlzaF90eXBlX2NoYW5nZSgpIHJldHVybnMgJzEnOyBhbmQK PiBkbV9vcCgpIHdpbGwgYWdhaW4gcmV0dXJuICcxJyBvbmx5IGlmIHRoZSB2ZXJ5IGxhc3QgY2Fs bCB0bwo+IHAybV9maW5pc2hfdHlwZV9jaGFuZ2UoKSByZXR1cm5zICcxJy4gIFRoZSByZXN1bHQg aXMgdGhhdCB0aGUKPiBYRU5fRE1PUF9tYXBfbWVtX3R5cGVfdG9faW9yZXFfc2VydmVyKCkgaHlw ZXJjYWxsIHdpbGwgc29tZXRpbWVzIHJldHVybgo+IDAgYW5kIHNvbWV0aW1lcyByZXR1cm4gMSBv biBzdWNjZXNzLCBpbiBhbiB1bnByZWRpY3RhYmxlIG1hbm5lci4KPiAKPiBUaGUgaHlwZXJjYWxs IGRvY3VtZW50YXRpb24gZG9lc24ndCBtZW50aW9uIHJldHVybiB2YWx1ZXM7IGJ1dCBpdCdzIG5v dAo+IGNsZWFyIHdoYXQgdGhlIGNhbGxlciBjb3VsZCBkbyB3aXRoIHRoZSBpbmZvcm1hdGlvbiBh Ym91dCB3aGV0aGVyCj4gZW50cmllcyBoYWQgYmVlbiBjaGFuZ2VkIG9yIG5vdC4gIEF0IHRoZSBt b21lbnQgaXQncyBhbHdheXMgMCBvbiBBTUQKPiBib3hlcywgYW5kICp1c3VhbGx5KiAxIG9uIElu dGVsIGJveGVzOyBzbyBub3RoaW5nIGNhbiBiZSByZWx5aW5nIG9uIGEKPiAnMScgcmV0dXJuIHZh bHVlIGZvciBjb3JyZWN0bmVzcyAob3IgaWYgaXQgaXMsIGl0J3MgYnJva2VuKS4KPiAKPiBNYWtl IHRoZSByZXR1cm4gdmFsdWUgb24gc3VjY2VzcyBjb25zaXN0ZW50bHkgJzAnIGJ5IG9ubHkgcmV0 dXJuaW5nCj4gMC8tRVJST1IgZnJvbSBmaW5pc2hfdHlwZV9jaGFuZ2UoKS4gIEFsc28gcmVtb3Zl IHRoZSBhY2N1bXVsYXRpb24gY29kZQo+IGZyb20gcDJtX2ZpbmlzaF90eXBlX2NoYW5nZSgpLgoK VGhhbmtzIGZvciBwdXR0aW5nIGluIHRoZSBlZmZvcnQgdG8gY2xlYW4gdGhpcyB1cC4KCk9uZSBj b21tZW50OiB0aGlzIGlzIHRoZSBzZWNvbmQgaW5zdGFuY2Ugb2YgdGhlIHBhdGNoIHlvdSBwb3N0 ZWQgd2hlcmUKdGhpcyBwYXJhZ3JhcGggaXMgbm90IHRydWUuICBXaGF0IEkgd3JvdGUgd2FzIG1l YW50IHRvIGJlIGFuIGV4YW1wbGUgb2YKaG93IGEgZ29vZCBwYXRjaCBkZXNjcmlwdGlvbiBzaG91 bGQgYmUgd3JpdHRlbiwgd2hpY2ggaW5jbHVkZXMgYSBza2V0Y2gKb2Ygd2hhdCB0aGUgcGF0Y2gg ZG9lcyB0ZWNobmljYWxseS4gIFlvdSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGUgc2tldGNoCm1hdGNo ZXMgdGhlIHBhdGNoLgoKQXMgaXQgaGFwcGVucywgaXQgbG9va3MgbGlrZSB5b3UnbGwgaGF2ZSB0 byBtb2RpZnkgdGhlIHBhdGNoIHN1Y2ggdGhhdAp2NSBhY3R1YWxseSBtYXRjaGVzIHRoZSBkZXNj cmlwdGlvbiBhZ2Fpbi4gOi0pCgpBbHNvLCB5b3UgcHJvYmFibHkgc2hvdWxkIGhhdmUgZHJvcHBl ZCB0aGUgUkZDIGF0IHYyLgoKIC1HZW9yZ2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tZGV2ZWw=