From: Stefan Raspl Subject: Re: [PATCH 6/8] tools/kvm_stat: separate drilldown and fields filtering Date: Wed, 14 Feb 2018 22:31:56 +0100 Message-ID: References: <20180205130004.29691-1-raspl@linux.vnet.ibm.com> <20180205130004.29691-7-raspl@linux.vnet.ibm.com> Reply-To: raspl@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: rkrcmar@redhat.com, frankja@linux.vnet.ibm.com To: Paolo Bonzini , kvm@vger.kernel.org Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51188 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030501AbeBNVcB (ORCPT ); Wed, 14 Feb 2018 16:32:01 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1ELTdAZ139299 for ; Wed, 14 Feb 2018 16:32:01 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g4tcfxbvj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 14 Feb 2018 16:32:01 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 Feb 2018 21:31:59 -0000 In-Reply-To: Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 13.02.2018 15:55, Paolo Bonzini wrote: > On 05/02/2018 14:00, Stefan Raspl wrote: >> From: Stefan Raspl >> >> Drilldown (i.e. toggle display of child trace events) was implemented by >> overriding the fields filter. This resulted in inconsistencies: E.g. when >> drilldown was not active, adding a filter that also matches child trace >> events would not only filter fields according to the filter, but also add >> in the child trace events matching the filter. E.g. on x86, setting >> 'kvm_userspace_exit' as the fields filter after startup would result in >> display of kvm_userspace_exit(DCR), although that wasn't previously >> present - not exactly what one would expect from a filter. >> This patch addresses the issue by keeping drilldown and fields filter >> separate. While at it, we also fix a PEP8 issue by adding a blank line >> at one place (since we're in the area...). >> We implement this by adding a framework that also allows to define a >> taxonomy among the debugfs events to identify child trace events. I.e. >> drilldown using 'x' can now also work with debugfs. A respective parent- >> child relationship is only known for S390 at the moment, but could be >> added adjusting other platforms' ARCH.dbg_is_child() methods >> accordingly. > > Looks good, but please name the functions "tracepoint_is_child" and > "debugfs_is_child" rather than "trc_is_child". Though I'd keep the names short - nevermind, will change. > Also, should "child_events" (and "pid" too) move from DebugfsProvider > and TracepointProvider up to "Provider"? Good point, will do. Ciao, Stefan