From: Sagar Arun Kamble Subject: Re: [PATCH] drm/i915/guc: Move firmware size check out of generic code Date: Fri, 6 Oct 2017 16:13:10 +0530 Message-ID: References: <20171006090148.53596-1-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F3726E8FC for ; Fri, 6 Oct 2017 10:43:17 +0000 (UTC) In-Reply-To: <20171006090148.53596-1-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMC82LzIwMTcgMjozMSBQTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBDaGVja2lu ZyBHdUMgZmlybXdhcmUgc2l6ZSBjYW4gYmUgZG9uZSBpbiBHdUMgc3BlY2lmaWMgY29kZQo+IHJp Z2h0IGJlZm9yZSBETUEgY29weSBhcyBpdCBpcyB1bmxpa2VseSB0byBmYWlsIGFueXdheS4KPgo+ IFNpZ25lZC1vZmYtYnk6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwu Y29tPgo+IENjOiBTYWdhciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+ IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCAxNCArKysr KysrKysrKy0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYyAgICAgIHwg IDggLS0tLS0tLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTEgZGVs ZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3Vj X2xvYWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gaW5k ZXggYzdhODAwYS4uZjI0NWFhNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ndWNfbG9hZGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNf bG9hZGVyLmMKPiBAQCAtMTk4LDYgKzE5OCw3IEBAIHN0YXRpYyBpbnQgZ3VjX3Vjb2RlX3hmZXJf ZG1hKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAl1bnNpZ25lZCBsb25n IG9mZnNldDsKPiAgIAlzdHJ1Y3Qgc2dfdGFibGUgKnNnID0gdm1hLT5wYWdlczsKPiAgIAl1MzIg c3RhdHVzLCByc2FbVU9TX1JTQV9TQ1JBVENIX01BWF9DT1VOVF07Cj4gKwl1MzIgc2l6ZSA9IGd1 Y19mdy0+aGVhZGVyX3NpemUgKyBndWNfZnctPnVjb2RlX3NpemU7Cj4gICAJaW50IGksIHJldCA9 IDA7Cj4gICAKPiAgIAkvKiB3aGVyZSBSU0Egc2lnbmF0dXJlIHN0YXJ0cyAqLwo+IEBAIC0yMDgs OSArMjA5LDE2IEBAIHN0YXRpYyBpbnQgZ3VjX3Vjb2RlX3hmZXJfZG1hKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAlmb3IgKGkgPSAwOyBpIDwgVU9TX1JTQV9TQ1JBVENI X01BWF9DT1VOVDsgaSsrKQo+ICAgCQlJOTE1X1dSSVRFKFVPU19SU0FfU0NSQVRDSChpKSwgcnNh W2ldKTsKPiAgIAo+IC0JLyogVGhlIGhlYWRlciBwbHVzIHVDb2RlIHdpbGwgYmUgY29waWVkIHRv IFdPUENNIHZpYSBETUEsIGV4Y2x1ZGluZyBhbnkKPiAtCSAqIG90aGVyIGNvbXBvbmVudHMgKi8K PiAtCUk5MTVfV1JJVEUoRE1BX0NPUFlfU0laRSwgZ3VjX2Z3LT5oZWFkZXJfc2l6ZSArIGd1Y19m dy0+dWNvZGVfc2l6ZSk7Cj4gKwkvKgo+ICsJICogVGhlIGhlYWRlciBwbHVzIHVDb2RlIHdpbGwg YmUgY29waWVkIHRvIFdPUENNIHZpYSBETUEsIGV4Y2x1ZGluZyBhbnkKPiArCSAqIG90aGVyIGNv bXBvbmVudHMuIE1ha2Ugc3VyZSB0aGF0IGZpcm13YXJlIGZpdHMgdGhlcmUuCj4gKwkgKi8KPiAr CWlmICh1bmxpa2VseShzaXplID4gaW50ZWxfZ3VjX3dvcGNtX3NpemUoZGV2X3ByaXYpKSkgewo+ ICsJCURSTV9FUlJPUigiR3VDOiBGaXJtd2FyZSBpcyB0b28gbGFyZ2UgKCVkQikgdG8gZml0IGlu IFdPUENNXG4iLAo+ICsJCQkgIHNpemUpOwo+ICsJCXJldHVybiAtRUZCSUc7ClRvcCBsZXZlbCBm dW5jdGlvbiBpcyBjb252ZXJ0aW5nIHRoaXMgdG8gLUVBR0FJTiBhbmQgd291bGQgYmUgCnVubmVj ZXNzYXJ5IHRvIHJldHJ5IGluIHRoYXQgY2FzZS4KPiArCX0KPiArCUk5MTVfV1JJVEUoRE1BX0NP UFlfU0laRSwgc2l6ZSk7Cj4gICAKPiAgIAkvKiBTZXQgdGhlIHNvdXJjZSBhZGRyZXNzIGZvciB0 aGUgbmV3IGJsb2IgKi8KPiAgIAlvZmZzZXQgPSBndWNfZ2d0dF9vZmZzZXQodm1hKSArIGd1Y19m dy0+aGVhZGVyX29mZnNldDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdWNfZncuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPiBpbmRleCA3 NjZiMWNiLi40ODIxMTViIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3VjX2Z3LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jCj4gQEAg LTEwOCwxNCArMTA4LDYgQEAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJICovCj4gICAJc3dpdGNoICh1Y19mdy0+dHlwZSkgewo+ ICAgCWNhc2UgSU5URUxfVUNfRldfVFlQRV9HVUM6Cj4gLQkJLyogSGVhZGVyIGFuZCB1Q29kZSB3 aWxsIGJlIGxvYWRlZCB0byBXT1BDTS4gU2l6ZSBvZiB0aGUgdHdvLiAqLwo+IC0JCXNpemUgPSB1 Y19mdy0+aGVhZGVyX3NpemUgKyB1Y19mdy0+dWNvZGVfc2l6ZTsKPiAtCj4gLQkJLyogVG9wIDMy ayBvZiBXT1BDTSBpcyByZXNlcnZlZCAoOEsgc3RhY2sgKyAyNGsgUkM2IGNvbnRleHQpLiAqLwpU aGlzIGNvbW1lbnQgd2FzIG5vdCBjb3JyZWN0LiBTbyByZW1vdmFsIG1ha2VzIHNlbnNlLgo+IC0J CWlmIChzaXplID4gaW50ZWxfZ3VjX3dvcGNtX3NpemUoZGV2X3ByaXYpKSB7Cj4gLQkJCURSTV9F UlJPUigiRmlybXdhcmUgaXMgdG9vIGxhcmdlIHRvIGZpdCBpbiBXT1BDTVxuIik7Cj4gLQkJCWdv dG8gZmFpbDsKPiAtCQl9Cj4gICAJCXVjX2Z3LT5tYWpvcl92ZXJfZm91bmQgPSBjc3MtPmd1Yy5z d192ZXJzaW9uID4+IDE2Owo+ICAgCQl1Y19mdy0+bWlub3JfdmVyX2ZvdW5kID0gY3NzLT5ndWMu c3dfdmVyc2lvbiAmIDB4RkZGRjsKPiAgIAkJYnJlYWs7CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK