Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE105C4332F for ; Mon, 18 Apr 2022 08:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237050AbiDRIDq (ORCPT ); Mon, 18 Apr 2022 04:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236333AbiDRIDo (ORCPT ); Mon, 18 Apr 2022 04:03:44 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9FABE01 for ; Mon, 18 Apr 2022 01:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650268864; x=1681804864; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3/KeY74fCa89/HKmeQeN7bAvF9g3Fcpr0R9Z+15MzFA=; b=c1q/AECxaLdUQl4Yk9lcyBxeNumwUZzFmnrR3LeunaecQWlKehBvaiI6 nRXWv+pC7nYYtBgjL43A45trFo1tfCAZLN3IQxKUf2sneJBSXrFtHs9YH iWuHEBZVNU8m8Cr3O8IoBl/VL657V4MbpEpeEhDJz7DZotxcCR0ZYFwxK ZlplUGmJ7LCDfZys/hwWqF10HrIluKVEJYVsh5ynR2NWjaxWXrpbNlmFE Qr7JHvNQ01ELvgliTy1uHCB5Ozox7P9sd1t1oDaM6oNWmRmMCwc0gyui5 vu2B6GKjZre8U2UlddcqjXzo2tEdv8zBAcgCaYZKXKPJ6ntHbQwK6mrV/ A==; X-IronPort-AV: E=Sophos;i="5.90,269,1643644800"; d="scan'208";a="310119962" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 18 Apr 2022 16:01:04 +0800 IronPort-SDR: yVzy9zkhnFsNxD+b73jHEiYRn9jfGVOmbGnQ0OKh4SpCIPPCmYOJWd+o/hVGBb17lC/Eh3Mxxq JtACjrHiKwyxv/1D1T8DirPBU3A2iId4uhhSczUvcHhyBZhRL/YYdMBQYfVOgYFlpCbQHtt0mq g6kTg7pdvxiv80eHRm5V03kYKiBAL7Kj3CRG9l9ZbrrXl/uEJ1vz6hf3QRIhJlzN3OBXFJrU4u dVDYEcugk5jrKX2ymAlWr0r29cS4c7WYPqWeXSvXCzIwvXLCnkQUYh3u7JCZR8U/sDsxEMsMCw ojozBVHMx9fOLZyaoSnHVs6A Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 00:31:26 -0700 IronPort-SDR: F7qg91fB+hi8mXDVef2ng1vhLijEdxONlOvLS+R6Kl7QxFZHTQMCGLDv2fSyQz+vVIZ/iwYX+l SBRl/8uRozpsC7PZOV5k3biMpflBh22aVBC9JhDcEfBLEaomaZTHJBiIX3cou1WO2H4BmVlltJ 3SGl1hBM9YA0uXA5qkRBxw/g7akLT8tTGlBeyeRUi7V28/U5CexYOW/n4U6ub8NEdcI1dXhEf5 vaAmy4jhfMMbMI5+ZLaZmXDALl6b9nDhSmwnuAf78ETrF+2fzb7SHnRYw/na9IS57cp9HnmkgY DWo= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Apr 2022 01:01:07 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KhfWj4Hz2z1SVp4 for ; Mon, 18 Apr 2022 01:01:05 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1650268864; x=1652860865; bh=3/KeY74fCa89/HKmeQeN7bAvF9g3Fcpr0R9 Z+15MzFA=; b=RIA+H92HNPzO4gWSeMVoqSWT3m10rBKmlLQcVEyCT9Rid+o1KlV iqV2xUypq2hDG/V8+vod3GcZtiyWFYkzYA2YHoTyC2BIJE5k41aqBGin/fd1TZ/M b3+meMBaDqT3CBOEkN4Dr3xrqtXr8bCAOS1SaCim+QrPo47IHpeoOFz8wKR5cl/D fK8/F9+hBEendDrUaP6UYa6QADixsBuszVbfs+uTK8Xu2BiLh3viWdBB/rO1zH6b GQbc1dCPmhvl/dHQXgJxs/XwFf43p3Vpekh27O0opPRrekskDKSmIKghQQKDVaXj krlHvgQVnrfyY2BhYOMFK2yeTZa3G6VdKyA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LPP2fvxmkPP3 for ; Mon, 18 Apr 2022 01:01:04 -0700 (PDT) Received: from [10.225.163.14] (unknown [10.225.163.14]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KhfWd1wHlz1Rvlx; Mon, 18 Apr 2022 01:01:01 -0700 (PDT) Message-ID: Date: Mon, 18 Apr 2022 17:01:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [dm-devel] [PATCH 03/11] null_blk: don't set the discard_alignment queue limit Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Jan Hoeppner , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, Song Liu , dm-devel@redhat.com, "Md. Haris Iqbal" , Jack Wang , linux-s390@vger.kernel.org, Richard Weinberger , xen-devel@lists.xenproject.org, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-block@vger.kernel.org, Stefan Haberland , linux-raid@vger.kernel.org, "Martin K. Petersen" , Johannes Berg , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220418045314.360785-1-hch@lst.de> <20220418045314.360785-4-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220418045314.360785-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 4/18/22 13:53, Christoph Hellwig wrote: > The discard_alignment queue limit is named a bit misleading means the > offset into the block device at which the discard granularity starts. > Setting it to the discard granularity as done by null_blk is mostly > harmless but also useless. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/null_blk/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c > index 5cb4c92cdffea..a521e914a9843 100644 > --- a/drivers/block/null_blk/main.c > +++ b/drivers/block/null_blk/main.c > @@ -1765,7 +1765,6 @@ static void null_config_discard(struct nullb *nullb) > } > > nullb->q->limits.discard_granularity = nullb->dev->blocksize; > - nullb->q->limits.discard_alignment = nullb->dev->blocksize; > blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9); > } > Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research