Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59605C6FA8F for ; Thu, 24 Aug 2023 10:35:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.589919.921989 (Exim 4.92) (envelope-from ) id 1qZ7g5-0000ez-RX; Thu, 24 Aug 2023 10:35:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 589919.921989; Thu, 24 Aug 2023 10:35:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qZ7g5-0000es-Os; Thu, 24 Aug 2023 10:35:01 +0000 Received: by outflank-mailman (input) for mailman id 589919; Thu, 24 Aug 2023 10:35:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qZ7g4-0000em-Oj for xen-devel@lists.xenproject.org; Thu, 24 Aug 2023 10:35:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfaf2505-4269-11ee-9b0c-b553b5be7939; Thu, 24 Aug 2023 12:34:58 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 6665E4EE0737; Thu, 24 Aug 2023 12:34:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfaf2505-4269-11ee-9b0c-b553b5be7939 MIME-Version: 1.0 Date: Thu, 24 Aug 2023 12:34:58 +0200 From: Nicola Vetrini To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini Subject: Re: [XEN PATCH v4 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2 In-Reply-To: <3007febabe8a13259dc10b566d23a27a89b75358.1690368810.git.simone.ballarin@bugseng.com> References: <3007febabe8a13259dc10b566d23a27a89b75358.1690368810.git.simone.ballarin@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 26/07/2023 13:03, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > Add the 'U' suffix to integers literals with unsigned type and also to > other > literals used in the same contexts or near violations, when their > positive > nature is immediately clear. The latter changes are done for the sake > of > uniformity. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin > Reviewed-by: Stefano Stabellini > --- > Changes in v4: > - change commit headline > - add Reviewed-by > > Changes in v3: > - create this commit for 'viridian.c' and 'hyperv-tlfs.h' > --- > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 ++++++++++---------- > 2 files changed, 15 insertions(+), 15 deletions(-) > This patch has perhaps slipped by since its submission. As it can be applied on top of staging without conflicts, then it probably needs an ack from the x86 viridian maintainers. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)