Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD7FC433E0 for ; Tue, 30 Jun 2020 00:02:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E22720760 for ; Tue, 30 Jun 2020 00:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E22720760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B6EEF89F71; Tue, 30 Jun 2020 00:02:36 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ABCB89F71 for ; Tue, 30 Jun 2020 00:02:34 +0000 (UTC) IronPort-SDR: xpKCgpQVgsfFuv5fAlQXAjn9/elnx9IDnD7nm+TlrW3PEH30gA7KM/w6IYjxbL4An25w7nNC5A hO4ARlSAqQSg== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="144293641" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="144293641" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 17:02:33 -0700 IronPort-SDR: 4uSVtlXe1aAHCM6Djzw7mEQdx2d99jA1Pa2waS6TWDK7+OkZoh8Tlhb120vS7i+svsMALHeQ11 B3+2vmLr5g/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="454386382" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 29 Jun 2020 17:02:32 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jun 2020 17:02:32 -0700 Received: from fmsmsx116.amr.corp.intel.com ([169.254.2.40]) by fmsmsx111.amr.corp.intel.com ([169.254.12.48]) with mapi id 14.03.0439.000; Mon, 29 Jun 2020 17:02:32 -0700 From: "Souza, Jose" To: "intel-gfx@lists.freedesktop.org" , "Deak, Imre" Thread-Topic: [Intel-gfx] [PATCH 2/2] drm/i915/icl+: Simplify combo/TBT PLL calculation call-chain Thread-Index: AQHWTkeO2+tnrGiE2kaownSTDXgX8ajwvLwA Date: Tue, 30 Jun 2020 00:02:31 +0000 Message-ID: References: <20200629185848.20550-1-imre.deak@intel.com> <20200629185848.20550-2-imre.deak@intel.com> In-Reply-To: <20200629185848.20550-2-imre.deak@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.46.142] Content-ID: <6DEA93D2F30F2A4DBF00375E431629C4@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl+: Simplify combo/TBT PLL calculation call-chain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gTW9uLCAyMDIwLTA2LTI5IGF0IDIxOjU4ICswMzAwLCBJbXJlIERlYWsgd3JvdGU6DQo+IFRv IHNpbXBsaWZ5IHRoaW5ncywgY2FsbCB0aGUgY29tYm8gUEhZL1RCVCBQTEwgY2FsY3VsYXRpb24g ZnVuY3Rpb25zDQo+IGRpcmVjdGx5IGZyb20gdGhlIGNvcnJlc3BvbmRpbmcgY29tYm8vVHlwZUMg UExMIGdldCBmdW5jdGlvbnMsIGluc3RlYWQgb2YNCj4gY2FsbGluZyB0aGUgc2FtZSBjYWxjdWxh dGlvbiBmdW5jdGlvbnMgYWZ0ZXIgaGF2aW5nIHRvIHJlY2hlY2sgaWYgdGhlDQo+IGdpdmVuIFBI WSBpcyBjb21ibyBvciBUeXBlQy4NCg0KTG9va3MgY2xlYW5lci4NCg0KUmV2aWV3ZWQtYnk6IEpv c8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPg0KDQo+IA0KPiBTaWdu ZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+DQo+IC0tLQ0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcGxsX21nci5jIHwgNjQgKysrKysrKyst LS0tLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDM3IGRlbGV0 aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkv aW50ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBs bF9tZ3IuYw0KPiBpbmRleCBmNTg1MDUzZDAyZDguLjgzMDZlOTJkYzg5MiAxMDA2NDQNCj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcGxsX21nci5jDQo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHBsbF9tZ3IuYw0KPiBAQCAtMzA0 Niw0OSArMzA0NiwyNiBAQCBzdGF0aWMgaW50IGljbF9kZGlfY29tYm9fcGxsX2dldF9mcmVxKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LA0KPiAgCQkJCQlpY2xfd3JwbGxfcmVmX2Nsb2Nr KGk5MTUpKTsNCj4gIH0NCj4gIA0KPiAtc3RhdGljIGJvb2wgaWNsX2NhbGNfZHBsbF9zdGF0ZShz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwNCj4gLQkJCQlzdHJ1Y3QgaW50ZWxf ZW5jb2RlciAqZW5jb2RlciwNCj4gK3N0YXRpYyB2b2lkIGljbF9jYWxjX2RwbGxfc3RhdGUoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsDQo+ICsJCQkJY29uc3Qgc3RydWN0IHNrbF93cnBs bF9wYXJhbXMgKnBsbF9wYXJhbXMsDQo+ICAJCQkJc3RydWN0IGludGVsX2RwbGxfaHdfc3RhdGUg KnBsbF9zdGF0ZSkNCj4gIHsNCj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGNydGNfc3RhdGUtPnVhcGkuY3J0Yy0+ZGV2KTsNCj4gLQl1MzIgY2ZnY3IwLCBj ZmdjcjE7DQo+IC0Jc3RydWN0IHNrbF93cnBsbF9wYXJhbXMgcGxsX3BhcmFtcyA9IHsgMCB9Ow0K PiAtCWJvb2wgcmV0Ow0KPiAtDQo+IC0JaWYgKGludGVsX3BoeV9pc190YyhkZXZfcHJpdiwgaW50 ZWxfcG9ydF90b19waHkoZGV2X3ByaXYsDQo+IC0JCQkJCQkJZW5jb2Rlci0+cG9ydCkpKQ0KPiAt CQlyZXQgPSBpY2xfY2FsY190YnRfcGxsKGNydGNfc3RhdGUsICZwbGxfcGFyYW1zKTsNCj4gLQll bHNlIGlmIChpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9IRE1J KSB8fA0KPiAtCQkgaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRf RFNJKSkNCj4gLQkJcmV0ID0gaWNsX2NhbGNfd3JwbGwoY3J0Y19zdGF0ZSwgJnBsbF9wYXJhbXMp Ow0KPiAtCWVsc2UNCj4gLQkJcmV0ID0gaWNsX2NhbGNfZHBfY29tYm9fcGxsKGNydGNfc3RhdGUs ICZwbGxfcGFyYW1zKTsNCj4gLQ0KPiAtCWlmICghcmV0KQ0KPiAtCQlyZXR1cm4gZmFsc2U7DQo+ ICsJbWVtc2V0KHBsbF9zdGF0ZSwgMCwgc2l6ZW9mKCpwbGxfc3RhdGUpKTsNCj4gIA0KPiAtCWNm Z2NyMCA9IERQTExfQ0ZHQ1IwX0RDT19GUkFDVElPTihwbGxfcGFyYW1zLmRjb19mcmFjdGlvbikg fA0KPiAtCQkgcGxsX3BhcmFtcy5kY29faW50ZWdlcjsNCj4gKwlwbGxfc3RhdGUtPmNmZ2NyMCA9 IERQTExfQ0ZHQ1IwX0RDT19GUkFDVElPTihwbGxfcGFyYW1zLT5kY29fZnJhY3Rpb24pIHwNCj4g KwkJCSAgICBwbGxfcGFyYW1zLT5kY29faW50ZWdlcjsNCj4gIA0KPiAtCWNmZ2NyMSA9IERQTExf Q0ZHQ1IxX1FESVZfUkFUSU8ocGxsX3BhcmFtcy5xZGl2X3JhdGlvKSB8DQo+IC0JCSBEUExMX0NG R0NSMV9RRElWX01PREUocGxsX3BhcmFtcy5xZGl2X21vZGUpIHwNCj4gLQkJIERQTExfQ0ZHQ1Ix X0tESVYocGxsX3BhcmFtcy5rZGl2KSB8DQo+IC0JCSBEUExMX0NGR0NSMV9QRElWKHBsbF9wYXJh bXMucGRpdik7DQo+ICsJcGxsX3N0YXRlLT5jZmdjcjEgPSBEUExMX0NGR0NSMV9RRElWX1JBVElP KHBsbF9wYXJhbXMtPnFkaXZfcmF0aW8pIHwNCj4gKwkJCSAgICBEUExMX0NGR0NSMV9RRElWX01P REUocGxsX3BhcmFtcy0+cWRpdl9tb2RlKSB8DQo+ICsJCQkgICAgRFBMTF9DRkdDUjFfS0RJVihw bGxfcGFyYW1zLT5rZGl2KSB8DQo+ICsJCQkgICAgRFBMTF9DRkdDUjFfUERJVihwbGxfcGFyYW1z LT5wZGl2KTsNCj4gIA0KPiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEyKQ0KPiAtCQlj ZmdjcjEgfD0gVEdMX0RQTExfQ0ZHQ1IxX0NGU0VMT1ZSRF9OT1JNQUxfWFRBTDsNCj4gKwlpZiAo SU5URUxfR0VOKGk5MTUpID49IDEyKQ0KPiArCQlwbGxfc3RhdGUtPmNmZ2NyMSB8PSBUR0xfRFBM TF9DRkdDUjFfQ0ZTRUxPVlJEX05PUk1BTF9YVEFMOw0KPiAgCWVsc2UNCj4gLQkJY2ZnY3IxIHw9 IERQTExfQ0ZHQ1IxX0NFTlRSQUxfRlJFUV84NDAwOw0KPiAtDQo+IC0JbWVtc2V0KHBsbF9zdGF0 ZSwgMCwgc2l6ZW9mKCpwbGxfc3RhdGUpKTsNCj4gLQ0KPiAtCXBsbF9zdGF0ZS0+Y2ZnY3IwID0g Y2ZnY3IwOw0KPiAtCXBsbF9zdGF0ZS0+Y2ZnY3IxID0gY2ZnY3IxOw0KPiAtDQo+IC0JcmV0dXJu IHRydWU7DQo+ICsJCXBsbF9zdGF0ZS0+Y2ZnY3IxIHw9IERQTExfQ0ZHQ1IxX0NFTlRSQUxfRlJF UV84NDAwOw0KPiAgfQ0KPiAgDQo+IC0NCj4gIHN0YXRpYyBlbnVtIHRjX3BvcnQgaWNsX3BsbF9p ZF90b190Y19wb3J0KGVudW0gaW50ZWxfZHBsbF9pZCBpZCkNCj4gIHsNCj4gIAlyZXR1cm4gaWQg LSBEUExMX0lEX0lDTF9NR1BMTDE7DQo+IEBAIC0zNTAxLDE5ICszNDc4LDI5IEBAIHN0YXRpYyBi b29sIGljbF9nZXRfY29tYm9fcGh5X2RwbGwoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3Rh dGUsDQo+ICB7DQo+ICAJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPQ0KPiAg CQlpbnRlbF9hdG9taWNfZ2V0X25ld19jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsNCj4gKwlzdHJ1 Y3Qgc2tsX3dycGxsX3BhcmFtcyBwbGxfcGFyYW1zID0geyB9Ow0KPiAgCXN0cnVjdCBpY2xfcG9y dF9kcGxsICpwb3J0X2RwbGwgPQ0KPiAgCQkmY3J0Y19zdGF0ZS0+aWNsX3BvcnRfZHBsbHNbSUNM X1BPUlRfRFBMTF9ERUZBVUxUXTsNCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsNCj4gIAllbnVtIHBvcnQgcG9ydCA9IGVuY29k ZXItPnBvcnQ7DQo+ICAJdW5zaWduZWQgbG9uZyBkcGxsX21hc2s7DQo+ICsJaW50IHJldDsNCj4g IA0KPiAtCWlmICghaWNsX2NhbGNfZHBsbF9zdGF0ZShjcnRjX3N0YXRlLCBlbmNvZGVyLCAmcG9y dF9kcGxsLT5od19zdGF0ZSkpIHsNCj4gKwlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0 YXRlLCBJTlRFTF9PVVRQVVRfSERNSSkgfHwNCj4gKwkgICAgaW50ZWxfY3J0Y19oYXNfdHlwZShj cnRjX3N0YXRlLCBJTlRFTF9PVVRQVVRfRFNJKSkNCj4gKwkJcmV0ID0gaWNsX2NhbGNfd3JwbGwo Y3J0Y19zdGF0ZSwgJnBsbF9wYXJhbXMpOw0KPiArCWVsc2UNCj4gKwkJcmV0ID0gaWNsX2NhbGNf ZHBfY29tYm9fcGxsKGNydGNfc3RhdGUsICZwbGxfcGFyYW1zKTsNCj4gKw0KPiArCWlmICghcmV0 KSB7DQo+ICAJCWRybV9kYmdfa21zKCZkZXZfcHJpdi0+ZHJtLA0KPiAgCQkJICAgICJDb3VsZCBu b3QgY2FsY3VsYXRlIGNvbWJvIFBIWSBQTEwgc3RhdGUuXG4iKTsNCj4gIA0KPiAgCQlyZXR1cm4g ZmFsc2U7DQo+ICAJfQ0KPiAgDQo+ICsJaWNsX2NhbGNfZHBsbF9zdGF0ZShkZXZfcHJpdiwgJnBs bF9wYXJhbXMsICZwb3J0X2RwbGwtPmh3X3N0YXRlKTsNCj4gKw0KPiAgCWlmIChJU19FTEtIQVJU TEFLRShkZXZfcHJpdikgJiYgcG9ydCAhPSBQT1JUX0EpDQo+ICAJCWRwbGxfbWFzayA9DQo+ICAJ CQlCSVQoRFBMTF9JRF9FSExfRFBMTDQpIHwNCj4gQEAgLTM1NDcsMTYgKzM1MzQsMTkgQEAgc3Rh dGljIGJvb2wgaWNsX2dldF90Y19waHlfZHBsbHMoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAq c3RhdGUsDQo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShz dGF0ZS0+YmFzZS5kZXYpOw0KPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl ID0NCj4gIAkJaW50ZWxfYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7DQo+ ICsJc3RydWN0IHNrbF93cnBsbF9wYXJhbXMgcGxsX3BhcmFtcyA9IHsgfTsNCj4gIAlzdHJ1Y3Qg aWNsX3BvcnRfZHBsbCAqcG9ydF9kcGxsOw0KPiAgCWVudW0gaW50ZWxfZHBsbF9pZCBkcGxsX2lk Ow0KPiAgDQo+ICAJcG9ydF9kcGxsID0gJmNydGNfc3RhdGUtPmljbF9wb3J0X2RwbGxzW0lDTF9Q T1JUX0RQTExfREVGQVVMVF07DQo+IC0JaWYgKCFpY2xfY2FsY19kcGxsX3N0YXRlKGNydGNfc3Rh dGUsIGVuY29kZXIsICZwb3J0X2RwbGwtPmh3X3N0YXRlKSkgew0KPiArCWlmICghaWNsX2NhbGNf dGJ0X3BsbChjcnRjX3N0YXRlLCAmcGxsX3BhcmFtcykpIHsNCj4gIAkJZHJtX2RiZ19rbXMoJmRl dl9wcml2LT5kcm0sDQo+ICAJCQkgICAgIkNvdWxkIG5vdCBjYWxjdWxhdGUgVEJUIFBMTCBzdGF0 ZS5cbiIpOw0KPiAgCQlyZXR1cm4gZmFsc2U7DQo+ICAJfQ0KPiAgDQo+ICsJaWNsX2NhbGNfZHBs bF9zdGF0ZShkZXZfcHJpdiwgJnBsbF9wYXJhbXMsICZwb3J0X2RwbGwtPmh3X3N0YXRlKTsNCj4g Kw0KPiAgCXBvcnRfZHBsbC0+cGxsID0gaW50ZWxfZmluZF9zaGFyZWRfZHBsbChzdGF0ZSwgY3J0 YywNCj4gIAkJCQkJCSZwb3J0X2RwbGwtPmh3X3N0YXRlLA0KPiAgCQkJCQkJQklUKERQTExfSURf SUNMX1RCVFBMTCkpOw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==