From: "cron2 (Code Review)" Date: Tue, 15 Jul 2025 20:05:07 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="jC/22+JclKs="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: reliable: Review and fix gc_arena usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --jC/22+JclKs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/10= 83?usp=3Demail ) Change subject: reliable: Review and fix gc_arena usage ...................................................................... reliable: Review and fix gc_arena usage Check for unused objects (in reliable_get_num_output_sequenced_available) and missing free (in reliable_can_get). While looking through the code, modernize the loop variable usage. Change-Id: I8cefa9a406fe90bb3cbe481304782c639691a3a0 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20250715143750.9719-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 157.html Signed-off-by: Gert Doering --- M src/openvpn/reliable.c 1 file changed, 29 insertions(+), 56 deletions(-) diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c index 424d194..5505f56 100644 --- a/src/openvpn/reliable.c +++ b/src/openvpn/reliable.c @@ -98,8 +98,7 @@ static inline bool reliable_ack_packet_id_present(struct reliable_ack *ack, packet_id_type pi= d) { - int i; - for (i =3D 0; i < ack->len; ++i) + for (int i =3D 0; i < ack->len; ++i) { if (ack->packet_id[i] =3D=3D pid) { @@ -312,10 +311,7 @@ const char * reliable_ack_print(struct buffer *buf, bool verbose, struct gc_arena *gc) { - int i; uint8_t n_ack; - struct session_id sid_ack; - packet_id_type pid; struct buffer out =3D alloc_buf_gc(256, gc); buf_printf(&out, "["); @@ -323,8 +319,9 @@ { goto done; } - for (i =3D 0; i < n_ack; ++i) + for (int i =3D 0; i < n_ack; ++i) { + packet_id_type pid; if (!buf_read(buf, &pid, sizeof(pid))) { goto done; @@ -334,6 +331,7 @@ } if (n_ack) { + struct session_id sid_ack; if (!session_id_read(&sid_ack, buf)) { goto done; @@ -356,14 +354,12 @@ void reliable_init(struct reliable *rel, int buf_size, int offset, int array_si= ze, bool hold) { - int i; - CLEAR(*rel); ASSERT(array_size > 0 && array_size <=3D RELIABLE_CAPACITY); rel->hold =3D hold; rel->size =3D array_size; rel->offset =3D offset; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; e->buf =3D alloc_buf(buf_size); @@ -378,8 +374,7 @@ { return; } - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; free_buf(&e->buf); @@ -391,8 +386,7 @@ bool reliable_empty(const struct reliable *rel) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -407,11 +401,10 @@ void reliable_send_purge(struct reliable *rel, const struct reliable_ack *ack) { - int i, j; - for (i =3D 0; i < ack->len; ++i) + for (int i =3D 0; i < ack->len; ++i) { packet_id_type pid =3D ack->packet_id[i]; - for (j =3D 0; j < rel->size; ++j) + for (int j =3D 0; j < rel->size; ++j) { struct reliable_entry *e =3D &rel->array[j]; if (e->active && e->packet_id =3D=3D pid) @@ -449,10 +442,9 @@ reliable_print_ids(const struct reliable *rel, struct gc_arena *gc) { struct buffer out =3D alloc_buf_gc(256, gc); - int i; buf_printf(&out, "[" packet_id_format "]", (packet_id_print_type)rel->= packet_id); - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -468,9 +460,7 @@ bool reliable_can_get(const struct reliable *rel) { - struct gc_arena gc =3D gc_new(); - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (!e->active) @@ -478,6 +468,7 @@ return true; } } + struct gc_arena gc =3D gc_new(); dmsg(D_REL_LOW, "ACK no free receive buffer available: %s", reliable_p= rint_ids(rel, &gc)); gc_free(&gc); return false; @@ -488,12 +479,11 @@ reliable_not_replay(const struct reliable *rel, packet_id_type id) { struct gc_arena gc =3D gc_new(); - int i; if (reliable_pid_min(id, rel->packet_id)) { goto bad; } - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active && e->packet_id =3D=3D id) @@ -514,19 +504,17 @@ bool reliable_wont_break_sequentiality(const struct reliable *rel, packet_id_ty= pe id) { - struct gc_arena gc =3D gc_new(); - const int ret =3D reliable_pid_in_range2(id, rel->packet_id, rel->size= ); if (!ret) { + struct gc_arena gc =3D gc_new(); dmsg(D_REL_LOW, "ACK " packet_id_format " breaks sequentiality: %s= ", (packet_id_print_type)id, reliable_print_ids(rel, &gc)); + gc_free(&gc); } dmsg(D_REL_DEBUG, "ACK RWBS rel->size=3D%d rel->packet_id=3D%08x id=3D= %08x ret=3D%d", rel->size, rel->packet_id, id, ret); - - gc_free(&gc); return ret; } @@ -534,8 +522,7 @@ struct buffer * reliable_get_buf(struct reliable *rel) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (!e->active) @@ -550,7 +537,6 @@ int reliable_get_num_output_sequenced_available(struct reliable *rel) { - struct gc_arena gc =3D gc_new(); packet_id_type min_id =3D 0; bool min_id_defined =3D false; @@ -573,7 +559,6 @@ { ret -=3D subtract_pid(rel->packet_id, min_id); } - gc_free(&gc); return ret; } @@ -581,14 +566,12 @@ struct buffer * reliable_get_buf_output_sequenced(struct reliable *rel) { - struct gc_arena gc =3D gc_new(); - int i; packet_id_type min_id =3D 0; bool min_id_defined =3D false; struct buffer *ret =3D NULL; /* find minimum active packet_id */ - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -607,9 +590,10 @@ } else { + struct gc_arena gc =3D gc_new(); dmsg(D_REL_LOW, "ACK output sequence broken: %s", reliable_print_i= ds(rel, &gc)); + gc_free(&gc); } - gc_free(&gc); return ret; } @@ -617,8 +601,7 @@ struct reliable_entry * reliable_get_entry_sequenced(struct reliable *rel) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (e->active && e->packet_id =3D=3D rel->packet_id) @@ -634,9 +617,8 @@ reliable_can_send(const struct reliable *rel) { struct gc_arena gc =3D gc_new(); - int i; int n_active =3D 0, n_current =3D 0; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -662,11 +644,10 @@ struct buffer * reliable_send(struct reliable *rel, int *opcode) { - int i; struct reliable_entry *best =3D NULL; const time_t local_now =3D now; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; @@ -701,10 +682,9 @@ void reliable_schedule_now(struct reliable *rel) { - int i; dmsg(D_REL_DEBUG, "ACK reliable_schedule_now"); rel->hold =3D false; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -722,10 +702,9 @@ { struct gc_arena gc =3D gc_new(); interval_t ret =3D BIG_TIMEOUT; - int i; const time_t local_now =3D now; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) @@ -758,8 +737,7 @@ reliable_mark_active_incoming(struct reliable *rel, struct buffer *buf, packet_id_type pid, int opcode) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (buf =3D=3D &e->buf) @@ -790,8 +768,7 @@ void reliable_mark_active_outgoing(struct reliable *rel, struct buffer *buf, in= t opcode) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (buf =3D=3D &e->buf) @@ -817,8 +794,7 @@ void reliable_mark_deleted(struct reliable *rel, struct buffer *buf) { - int i; - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { struct reliable_entry *e =3D &rel->array[i]; if (buf =3D=3D &e->buf) @@ -836,10 +812,8 @@ void reliable_ack_debug_print(const struct reliable_ack *ack, char *desc) { - int i; - printf("********* struct reliable_ack %s\n", desc); - for (i =3D 0; i < ack->len; ++i) + for (int i =3D 0; i < ack->len; ++i) { printf(" %d: " packet_id_format "\n", i, (packet_id_print_type) a= ck->packet_id[i]); } @@ -848,14 +822,13 @@ void reliable_debug_print(const struct reliable *rel, char *desc) { - int i; update_time(); printf("********* struct reliable %s\n", desc); printf(" initial_timeout=3D%d\n", (int)rel->initial_timeout); printf(" packet_id=3D" packet_id_format "\n", rel->packet_id); printf(" now=3D%" PRIi64 "\n", (int64_t)now); - for (i =3D 0; i < rel->size; ++i) + for (int i =3D 0; i < rel->size; ++i) { const struct reliable_entry *e =3D &rel->array[i]; if (e->active) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1083?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8cefa9a406fe90bb3cbe481304782c639691a3a0 Gerrit-Change-Number: 1083 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --jC/22+JclKs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

reliable: Review and fix gc_arena usage
Check for unused objects (in
reliable_get_num_output_sequenced_availab= le)
and missing free (in reliable_can_get).

While looking through= the code, modernize
the loop variable usage.

Change-Id: I8cefa9a= 406fe90bb3cbe481304782c639691a3a0
Signed-off-by: Frank Lichtenheld <f= rank@...2641...>
Acked-by: Arne Schwabe <arne-openvpn@...1227...&g= t;
Message-Id: <20250715143750.9719-1-gert@...1296...>
URL: htt= ps://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32157.html=
Signed-off-by: Gert Doering <gert@...1296...>
---
M src/ope= nvpn/reliable.c
1 file changed, 29 insertions(+), 56 deletions(-)
diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c
<= span>index 424d194..5505f56 100644
--- a/src/openvpn/reliab= le.c
+++ b/src/openvpn/reliable.c
@@ -98,8 = +98,7 @@
static inline bool
reliable_ack_= packet_id_present(struct reliable_ack *ack, packet_id_type pid)
<= span> {
- int i;

- for (i =3D 0; i < = ack->len; ++i)
+ = for (int i =3D 0; i < ack->len; ++i)
{<= br> if (ack->packet_id[i] =3D=3D pid)
= {
@@ -312,10 +311,7 @@
const char *
reliable_ack_print(struct buffer *buf, bool verbose, struct= gc_arena *gc)
{
- int i;
uint8_t n_ack;
- struct session_id sid_ack;<= br>- packet_id_type pid;
struct buffer out =3D alloc_buf_gc(256, gc);

buf_printf(&out, "[");
@@ -323,8 +319,9 @@

{
goto= done;
}
- for (i =3D 0; i < n_ack; ++i)
+ for (int i =3D 0; i < n_ack; ++i) {
+ = packet_id_type pid;
if (!buf_read(buf, &pid,= sizeof(pid)))
{
goto= done;
@@ -334,6 +331,7 @@
} if (n_ack)
{
+ struct session_id sid_ack;
if (!session_id_read(&sid_ack, buf))
= {
goto done;
@@ -356,14 +354= ,12 @@
void
reliable_init(struct reliable= *rel, int buf_size, int offset, int array_size, bool hold)
{
- int i;<= br>-
CLEAR(*= rel);
ASSERT(array_size > 0 && array_size &= lt;=3D RELIABLE_CAPACITY);
rel->hold =3D hold;

rel->size =3D array_size;
rel->= offset =3D offset;
- = for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->size; ++i)=
{
struct reliable_entry *e =3D &= ;rel->array[i];
e->buf =3D alloc_buf(buf_siz= e);
@@ -378,8 +374,7 @@
{
return;
}
- int i;
- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->siz= e; ++i)
{
struct reliable_ent= ry *e =3D &rel->array[i];
free_buf(&e-&= gt;buf);
@@ -391,8 +386,7 @@
bool reliable_empty(const struct reliable *rel)
{
- int i;
- for (i =3D 0; i < rel->size= ; ++i)

+ for (int = i =3D 0; i < rel->size; ++i)
{
= const struct reliable_entry *e =3D &rel->array[i]; if (e->active)
@@ -407,11 +401,10 @@
void
reliable_send_purge(struct reliable *re= l, const struct reliable_ack *ack)
{
- int i, j;
- for (i =3D 0; i < ack->len; ++i)+ for (int i =3D 0; i <= ack->len; ++i)
{
packet_i= d_type pid =3D ack->packet_id[i];
- for (j =3D 0; j < rel->size; ++j)
+ for (int j =3D 0; j <= rel->size; ++j)

{
= struct reliable_entry *e =3D &rel->array[j];
= if (e->active && e->packet_id =3D=3D pid)
@@ -449,10 +442,9 @@
reliable_print_ids(const struct r= eliable *rel, struct gc_arena *gc)
{
= struct buffer out =3D alloc_buf_gc(256, gc);
- int i;

bu= f_printf(&out, "[" packet_id_format "]", (packet_id= _print_type)rel->packet_id);
- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->size= ; ++i)
{
const struct reliabl= e_entry *e =3D &rel->array[i];
if (e->ac= tive)
@@ -468,9 +460,7 @@
bool
<= span> reliable_can_get(const struct reliable *rel)
{
- struct gc_arena gc =3D = gc_new();
- int i;
- for (i =3D 0; i <= ; rel->size; ++i)
= + for (int i =3D 0; i < rel->size; ++i)
{
const struct reliable_entry *e =3D &rel->array= [i];
if (!e->active)
@@ -478,6 = +468,7 @@
return true;
= }
}
+ struct gc_arena gc =3D gc_new();
dmsg(D_REL= _LOW, "ACK no free receive buffer available: %s", reliable_print_= ids(rel, &gc));
gc_free(&gc);
= return false;
@@ -488,12 +479,11 @@
r= eliable_not_replay(const struct reliable *rel, packet_id_type id) {
struct gc_arena gc =3D gc_new();
<= span style=3D"color: hsl(0, 100%, 40%);">- int i;

i= f (reliable_pid_min(id, rel->packet_id))
{ goto bad;
}
- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i= < rel->size; ++i)
{
co= nst struct reliable_entry *e =3D &rel->array[i];
= if (e->active && e->packet_id =3D=3D id)
@@ -514,19 +504,17 @@

bool
reliable_won= t_break_sequentiality(const struct reliable *rel, packet_id_type id)=
{
- struc= t gc_arena gc =3D gc_new();
-
const int ret =3D reliable_pid_in_range2(id, re= l->packet_id, rel->size);

if (= !ret)
{
+ struct gc_arena gc =3D gc_new();
= dmsg(D_REL_LOW, "ACK " packet_id_format " breaks sequentiali= ty: %s",
(packet_id_print_type)id, relia= ble_print_ids(rel, &gc));
+ gc_free(&gc);
}
=
dmsg(D_REL_DEBUG, "ACK RWBS rel->size=3D%d r= el->packet_id=3D%08x id=3D%08x ret=3D%d", rel->size, rel->pac= ket_id, id, ret);
-
- gc_free(&gc);
return ret;
}
@@ -534,8 +522,7 @@
struct buffer *
reliable_get_buf(struct reliable *rel)

{
- int i;

- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i= < rel->size; ++i)
{
st= ruct reliable_entry *e =3D &rel->array[i];
= if (!e->active)
@@ -550,7 +537,6 @@
int=
reliable_get_num_output_sequenced_available(struct reliab= le *rel)
{
- struct gc_arena gc =3D gc_new();
packet_id_t= ype min_id =3D 0;
bool min_id_defined =3D false;

@@ -573,7 +559,6 @@
{
ret -=3D subtract_pid(rel->packet_id, min_id);
}
- = gc_free(&gc);
return ret;
}

@@ -581,14 +566,12 @@
struc= t buffer *
reliable_get_buf_output_sequenced(struct reliab= le *rel)
{
- struct gc_arena gc =3D gc_new();
- int i;
packet_id_type min_id = =3D 0;
bool min_id_defined =3D false;
= struct buffer *ret =3D NULL;

/*= find minimum active packet_id */
- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->si= ze; ++i)
{
const struct relia= ble_entry *e =3D &rel->array[i];
if (e->= active)
@@ -607,9 +590,10 @@
}<= br> else
{
+ struct gc_arena gc =3D gc_new();
dmsg(D_REL_LOW, "ACK output sequence broken: %s", re= liable_print_ids(rel, &gc));

+ gc_free(&gc);
}
- gc_free(&gc);

return ret;

}

@@= -617,8 +601,7 @@
struct reliable_entry *
= reliable_get_entry_sequenced(struct reliable *rel)
{
- int i;
- for (i =3D 0; i < rel->size= ; ++i)

+ for (int = i =3D 0; i < rel->size; ++i)
{
= struct reliable_entry *e =3D &rel->array[i];
if (e->active && e->packet_id =3D=3D rel->packet= _id)

@@ -634,9 +617,8 @@
reliable_can_send= (const struct reliable *rel)
{
struct= gc_arena gc =3D gc_new();
- int i;
int n_active =3D 0, n_current =3D 0;
- for (i =3D 0; i <= ; rel->size; ++i)
= + for (int i =3D 0; i < rel->size; ++i)
{
const struct reliable_entry *e =3D &rel->array= [i];
if (e->active)
@@ -662,11 = +644,10 @@
struct buffer *
reliable_send(= struct reliable *rel, int *opcode)
{
- int i;
struct reli= able_entry *best =3D NULL;
const time_t local_now =3D = now;

= - for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->size; ++i)

{
struct reliable_entry *e =3D = &rel->array[i];

@@ -701,10 +682,9 = @@
void
reliable_schedule_now(struct reli= able *rel)
{
- int i;
dmsg(D_REL_DEBUG, "ACK reliabl= e_schedule_now");
rel->hold =3D false;<= br>- for (i =3D 0; i < rel-= >size; ++i)
+ f= or (int i =3D 0; i < rel->size; ++i)
{ struct reliable_entry *e =3D &rel->array[i];<= br> if (e->active)
@@ -722,10 +702,9 @@

{
struct gc_arena gc =3D gc_new();
interval_t ret =3D BIG_TIMEOUT;
- int i;
const time_t loc= al_now =3D now;

- for (i =3D 0; i < rel->size; ++i)
+ for (int i =3D 0; i < rel->si= ze; ++i)
{
const struct relia= ble_entry *e =3D &rel->array[i];
if (e->= active)
@@ -758,8 +737,7 @@
reliable_mark_= active_incoming(struct reliable *rel, struct buffer *buf,
= packet_id_type pid, int opcode)
{

- int i;
- for (i =3D 0; i < re= l->size; ++i)
+ = for (int i =3D 0; i < rel->size; ++i)
{<= br> struct reliable_entry *e =3D &rel->array[i];
if (buf =3D=3D &e->buf)
@@ -790,= 8 +768,7 @@
void
reliable_mark_active_out= going(struct reliable *rel, struct buffer *buf, int opcode)
{

- int i;<= br>- for (i =3D 0; i < rel-= >size; ++i)
+ f= or (int i =3D 0; i < rel->size; ++i)
{ struct reliable_entry *e =3D &rel->array[i];<= br> if (buf =3D=3D &e->buf)
@@ -817,8 = +794,7 @@
void
reliable_mark_deleted(stru= ct reliable *rel, struct buffer *buf)
{
- int i;
- for (i =3D 0; i < rel->size; ++i)<= br>+ for (int i =3D 0; i <= ; rel->size; ++i)
{
struct= reliable_entry *e =3D &rel->array[i];
if (= buf =3D=3D &e->buf)
@@ -836,10 +812,8 @@
<= span> void

reliable_ack_debug_print(const struct reliable_= ack *ack, char *desc)
{
- int i;
-
printf("********* struct reliable_ack %s= \n", desc);
- f= or (i =3D 0; i < ack->len; ++i)
+ for (int i =3D 0; i < ack->len; ++i)
= {
printf(" %d: " packet_id_f= ormat "\n", i, (packet_id_print_type) ack->packet_id[i]);
}
@@ -848,14 +822,13 @@
v= oid
reliable_debug_print(const struct reliable *rel, char = *desc)
{
- int i;
update_time();
=
printf("********* struct reliable %s\n", desc);
printf(" initial_timeout=3D%d\n", (int)rel-&g= t;initial_timeout);
printf(" packet_id=3D" = packet_id_format "\n", rel->packet_id);
p= rintf(" now=3D%" PRIi64 "\n", (int64_t)now);- for (i =3D 0; i < rel-&g= t;size; ++i)
+ for= (int i =3D 0; i < rel->size; ++i)
{
<= span> const struct reliable_entry *e =3D &rel->array[i];
if (e->active)

To view, visit change 1083. To unsubscribe, or for help writing mail filters= , visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8cefa9a406fe90bb3cbe4813047= 82c639691a3a0
Gerrit-Change-Number: 1083
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--jC/22+JclKs=--