Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2924C432BE for ; Thu, 26 Aug 2021 12:47:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 997A160FDC for ; Thu, 26 Aug 2021 12:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 997A160FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 585D16E837; Thu, 26 Aug 2021 12:47:36 +0000 (UTC) X-Greylist: delayed 391 seconds by postgrey-1.36 at gabe; Thu, 26 Aug 2021 12:47:35 UTC Received: from NAM11-DM6-obe.outbound.protection.outlook.com (unknown [40.107.223.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2039F6E837 for ; Thu, 26 Aug 2021 12:47:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XBXX1oxOweehlYeSCeO6Psu8KSo7HTo2dnqE4MJTsOAVSiI3I21VmE7X7jpZEoRHbYeaToxBieuMb2iERYOLmjVLYiVpLAg2ZQt97XFEdVNJVdhdRv1b5NNn1o6O6fFqzZ45q5cxIv/p6kOHvZyAnkGp+7ITjEK2+yvEbIKytIurseE6lSTsmqWRSozWSCWw1bCcEtu/g136njgjF06WnIf3yH8hRE0wGorDTSGMMtAdfqdScrHF7yqFRskg29N888bqY2vgVphCSMtuBboTEeBeXOQdaSfpu+6mRLZnVHPDb69qOX1xwuz+0lJjWATZl1P94VCNUCEGdz0SJpKDgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2xqK98XZQzFDsY3/sPoOwcXDwsFrewD5W2Iy5FxW3M=; b=U1KrVq4rVwisLrLoWYISh7dlBELZMryLD65KQ0JU4yKeU/UvFz9T9Mi7Hi6CFFJU/GroO9tpIiwc7EnyoonpaNsbR+vAk+Hu3yHFc4fCWB7+eoo0gVDo7JZ7AxrbwlNQQqCaQ2lP2Ic9MRKxfSN9MDZuJ0QiLtisrjpo24btYYPDiJmfg1haC9dBhXq+il/0YUZ9fKua2Km+7Nu09ROMT7TDXyPXNXCDsiEBhAQEsI5wXVJb+DjZ5o9phLqRqzX7FRxqhJNJautDgWVbzi35gxwWVPbk8gTZQRFHCNa039B6qcZqepSjJ6Czb/e6qNWlo0bu1tT9Kzrn29agKpACnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U2xqK98XZQzFDsY3/sPoOwcXDwsFrewD5W2Iy5FxW3M=; b=ELNYDhjGJOqM9TPHiwgaYDFCi+G2wz8DgqCOKJUKanYZSmBIB+KtmxEJNRcmThgxVQALqUkczNpZ+WSFWLmCYK4x43Ubomce3HJmKEhYl5bnDagVhmnOjT5qo0nK8VMYFAaw5Ec/AxjU2P1WO1Az9fZLuPqbokeb5+noAv/PjkE= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) by MN2PR12MB3952.namprd12.prod.outlook.com (2603:10b6:208:164::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Thu, 26 Aug 2021 12:34:55 +0000 Received: from MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe]) by MN2PR12MB3775.namprd12.prod.outlook.com ([fe80::dce2:96e5:aba2:66fe%6]) with mapi id 15.20.4436.024; Thu, 26 Aug 2021 12:34:55 +0000 Subject: Re: [PATCH 2/5] drm/amdgpu/vcn:set vcn encode ring priority level To: "Sharma, Shashank" , Satyajit Sahu , amd-gfx@lists.freedesktop.org Cc: leo.liu@amd.com, Alexander.Deucher@amd.com, nirmoy.das@amd.com References: <20210826071307.136010-1-satyajit.sahu@amd.com> <20210826071307.136010-2-satyajit.sahu@amd.com> <2a818da4-dc8e-a9b6-c85e-9a6cfef8b537@amd.com> <82b91115-b2c8-f6bf-30bb-15da77e70d09@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 26 Aug 2021 14:34:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: FR0P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::23) To MN2PR12MB3775.namprd12.prod.outlook.com (2603:10b6:208:159::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a02:908:1252:fb60:1f1e:4529:2fc9:1857] (2a02:908:1252:fb60:1f1e:4529:2fc9:1857) by FR0P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.10 via Frontend Transport; Thu, 26 Aug 2021 12:34:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 578841da-7163-4325-cbbf-08d9688de88e X-MS-TrafficTypeDiagnostic: MN2PR12MB3952: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5c5f3f2kyQ9N+LgwK6qtDIIP+ozte2X3dsQOIHPP/oFu17O05JQNy9xeg4kjaORlsyYDEai21LKkPqwcfnQ5f5Kx3qbA4Xp2QCDhgQWlb5XWk3uUuv/GfwzCX8rPnZpAy9LZ1vtcqzK0bbKw7c2aJb6RBnyvaXlqrfk5900RVia4uYk0sEwmzSDv/qaWXXvw1ZIX2yZ6e/7pewd93MjIl9uFm9bXXmyIojTTBoOD3Q3HEkPhW2Sgbffvk4RSN4AUjUgi/RKJljhZsx0a0X4YVz6xiZ+32X88cpsLAKUXODlWf2cRqG/pcsoUoUOwaeACX/MeY4Uuos007h8ShogtYQEz03vsbhWIR2cve5guWxGts+IblFf9mmi34KG0jyLOEEIYbh2Wsm42EPcSjLHMKp/X2ULwdaBnci0HxTV2wbtzGKywFDbkUgGkGrI3mrO94mO3adDUmX/sJpbYvGLIDNmZ1bhe7RpGo4pd/h7QYRwP4EJAVMGQ7xJ9Nu9GYOt5Ug2CFh0zubFgcYwH2R7cs6TpZ+YppzyLWrVHc4v+GxDvKQd091cF1zmhVYAucRtG8NrJKSBBqB2zoYngg0qxBPjPcDAqe5lCUPAmo9kre40EHN3VSe1HpwHz8vLE2fZyFYQZV/ukhvB0IBKEdmcImNZ9YoSxxosSIZILSUD928XXYZ+YhWskwUVzw7zffvJ3zVz8xAr8uch5jIaLt0OB2C0sLRI9k4fuP30N/okCftA9mbTelL2Q5PT2CC3Yr4a/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3775.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(110136005)(86362001)(83380400001)(316002)(66574015)(478600001)(5660300002)(8936002)(53546011)(186003)(8676002)(66556008)(4326008)(6666004)(66476007)(31696002)(66946007)(2906002)(38100700002)(31686004)(36756003)(2616005)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2NKS0NocW14cCs5QlB4RUxNV1JGcU9DbzhHTHVIRmdEWkRuV3A3cmdFQnFo?= =?utf-8?B?WjhKNGZFQXZDckgyeFc3Vm40SWNueWp5T2JsYXdMbDNRdGowQVUxVTNpK0Vw?= =?utf-8?B?NjVPWkFDU3l2ZHYxQ1BndDhyMzY4aVJHK3NJTENSSDZ3aG9vQmpNTnJoR1dF?= =?utf-8?B?SnpPcDhLRUN2TEhoL1p2TzhlYW9aVVp1Q1E5MVEwU3dOM20wem1kb3NwUmNW?= =?utf-8?B?TGZFVU9ZVTFlZE1OQ1BYek9JclNXZ2pUSC9LQUo5MStQLzdBRUl5UU8xeEdm?= =?utf-8?B?SjIzQXZPT0p5ekxmeDA4M3g5QjlEL2RlSkNoc2RkU0UxSGZMWS96dW1EaWZT?= =?utf-8?B?ZVV5ZmhwSTUxbmhGRXU2SVBXb1NEbTQrYyswc3lpNGZNQ3ZhT2RIcCtuN09h?= =?utf-8?B?SzlYSzJxU1FyMEN4UlAvdXRDeFc1ZjdqM0I1a0ZsV1EyU29kWElYclluU0hw?= =?utf-8?B?cFNmM05WNnBSRnZPSEhPeHdudE4rbzFBUTIrVDZlYzQreXhvQTRpU2Zqc053?= =?utf-8?B?Z3o0ZGpidGtRSkU5d0IxRGg0UjY0cHRyd21STm82SE5JSXA2bUlHNmhSeVVq?= =?utf-8?B?eTVPSmQ4QkxvV0tCMWYyWUM0Y1JSWW9ialkzejhyYjRmZHFoeXlXbG5zcHMr?= =?utf-8?B?cU51cnArNHNVUXQrSHo0NHN2cVo3S09wdk1xSm1YNVRCb1kxNHN4NCtSUU1O?= =?utf-8?B?c1NZYytJL1hwOHdQSVNjU0RQVmdGckZqOHRoSVBOZ0xnSnR3MW8xT1ZqamJt?= =?utf-8?B?SXlXZXRNMnBETW1zSWdOS09jUVUwOVh1OFNVcjc3UXBZczd2ampSMDVlSjhw?= =?utf-8?B?RWg5SExhdG5DaWhQcDFRNGdhMjJ0eDNKdkdBRU5FYzRRMFQxekJ5Y1NlNmsw?= =?utf-8?B?ODJXS2JNS1Q2NG1NSGVWRXB6MXZlMC83cTNXbWVZZEk2RC9XVWZUcXIveWRK?= =?utf-8?B?Q3FqUnFWV09IKzdpb0VwVEtwT1NHZk1hbXJTYWdvMXB3ZGpjQVZTRVFUbWMr?= =?utf-8?B?N0lZMlNVbjNCSzFPb2RyUHptRGdMOC9pQVFPSkZZVHl3VlRGUlg4SC9keEpK?= =?utf-8?B?WnZ1UEhObDQ1ekh1eGRhUmVBSGRHL2xsaUY1VDZWNis3M01GV28vU2NKeElh?= =?utf-8?B?dVFWYUdoalB6WlEzQXl5NXlHNGJYS0lRU0plbnNPRHZyWnhsbkpsb29DbUUr?= =?utf-8?B?N2dESHQwQVh1dkF2eUJ2WFN6TDFZN3NndDdNYlc2WDhOekdlZTgvUWNCbUww?= =?utf-8?B?aHZESG5Nby9zWFpoSUZ2NTNNMm1yK255ZkxsMFVTa1N4blh4UEU1aWY0RTE2?= =?utf-8?B?cUMrQzMxMzhUUnc1S1grWnhSVUk5d3BYNllqMVR3dHlUNis2UUtOaVFTbmpL?= =?utf-8?B?VmpPUk5xd2Ewek4xR2xHOHQrMzN0NTc1bWVYWjJsMnNXUzN1b2p2USs2RHFY?= =?utf-8?B?djlOMHVzeHF0UXZhU2RpRDFSd3NUc2JNb0tmWjhrb1Q0MVpPb3c1b3RhSHdB?= =?utf-8?B?N2lRYkx0T21GejNxQjI2SzJqNEQ5VnVJd3U0KzYyVHc0ajRhRXZZeXl2TU0x?= =?utf-8?B?VkN2MDgyckwzRXJBd1llV1N3VUdnVWNvK2F4R0pEaVdINHhDdDJXN0t5ZkdY?= =?utf-8?B?Q2EzbUN1VTI3dTUrdFAvVnhzQlpramh1Y1hEbWJBQS91SDZvN2VrQ29vYnFS?= =?utf-8?B?blpmR1JRWUFCdkZ4TFI1YmFsTFBmbjRUcTBkbHVTcHpoVzUvN1dOOHlRQUN3?= =?utf-8?B?b295UTlsbXJCZ0MwS2REU3pKK1RsMDRHNktBYyswNG5FOVRpQmQ3U3dEQVR2?= =?utf-8?B?NmU3eXdqUllaRlZEQWxKcEoyZmp4RHRTUjdVUFhTUjhZcVdVUHprQ3Nib0N6?= =?utf-8?Q?N3nYwhOgBinnL?= X-MS-Exchange-CrossTenant-Network-Message-Id: 578841da-7163-4325-cbbf-08d9688de88e X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 12:34:55.2394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GI25UUNFcdkoh3GzQpKnLERYj+Yv30Lxm04qHT9kn5qdv+nFfKgFKNY9lE3kL3HT X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3952 X-OriginatorOrg: amd.com X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Am 26.08.21 um 14:31 schrieb Sharma, Shashank: > On 8/26/2021 5:54 PM, Christian König wrote: >> Am 26.08.21 um 13:32 schrieb Sharma, Shashank: >>> Hi Satyajit, >>> >>> On 8/26/2021 12:43 PM, Satyajit Sahu wrote: >>>> There are multiple rings available in VCN encode. Map each ring >>>> to different priority. >>>> >>>> Signed-off-by: Satyajit Sahu >>>> --- >>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++++++++++++++ >>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h |  9 +++++++++ >>>>   2 files changed, 23 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c >>>> index 6780df0fb265..ce40e7a3ce05 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c >>>> @@ -951,3 +951,17 @@ int amdgpu_vcn_enc_ring_test_ib(struct >>>> amdgpu_ring *ring, long timeout) >>>>         return r; >>>>   } >>>> + >>>> +enum vcn_enc_ring_priority amdgpu_vcn_get_enc_ring_prio(int index) >>>> +{ >>>> +    switch(index) { >>>> +    case 0: >>> >>> As discussed in the previous patches, its far better to have MACROS >>> or enums instead of having 0/1/2 cases. As a matter of fact, we can >>> always call it RING_0 RING_1 and so on. >> >> I strongly disagree. Adding macros or enums just to have names for >> the numbered rings doesn't gives you any advantage at all. That's >> just extra loc. >> > > Honestly, when I just see case '0', its a magic number for me, and is > making code less readable, harder for review, and even harder to > debug. RING_0 tells me that we are mapping a ring to a priority, and > clarifies the intention. Well we should probably rename the variable then, e.g. like ring_idx or just ring. A switch on the variable named "ring" with a value of 0 has the same meaning than RING_0, it's just not so much code to maintain. Christian. > > - Shashank > >> We could use the ring pointers to identify a ring instead, but using >> the switch here which is then used inside the init loop is perfectly >> fine. >> >> Regards, >> Christian. >> >>> >>> >>> If this is being done just for the traditional reasons, we can have >>> a separate patch to replace it across the driver as well. >>> >>> - Shashank >>> >>> >>>> +        return AMDGPU_VCN_ENC_PRIO_NORMAL; >>>> +    case 1: >>>> +        return AMDGPU_VCN_ENC_PRIO_HIGH; >>>> +    case 2: >>>> +        return AMDGPU_VCN_ENC_PRIO_VERY_HIGH; >>>> +    default: >>>> +        return AMDGPU_VCN_ENC_PRIO_NORMAL; >>>> +    } >>>> +} >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h >>>> index d74c62b49795..938ee73dfbfc 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h >>>> @@ -290,6 +290,13 @@ enum vcn_ring_type { >>>>       VCN_UNIFIED_RING, >>>>   }; >>>>   +enum vcn_enc_ring_priority { >>>> +    AMDGPU_VCN_ENC_PRIO_NORMAL = 1, >>>> +    AMDGPU_VCN_ENC_PRIO_HIGH, >>>> +    AMDGPU_VCN_ENC_PRIO_VERY_HIGH, >>>> +    AMDGPU_VCN_ENC_PRIO_MAX >>>> +}; >>>> + >>>>   int amdgpu_vcn_sw_init(struct amdgpu_device *adev); >>>>   int amdgpu_vcn_sw_fini(struct amdgpu_device *adev); >>>>   int amdgpu_vcn_suspend(struct amdgpu_device *adev); >>>> @@ -308,4 +315,6 @@ int amdgpu_vcn_dec_sw_ring_test_ib(struct >>>> amdgpu_ring *ring, long timeout); >>>>   int amdgpu_vcn_enc_ring_test_ring(struct amdgpu_ring *ring); >>>>   int amdgpu_vcn_enc_ring_test_ib(struct amdgpu_ring *ring, long >>>> timeout); >>>>   +enum vcn_enc_ring_priority amdgpu_vcn_get_enc_ring_prio(int index); >>>> + >>>>   #endif >>>> >>