Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A897C25B75 for ; Wed, 29 May 2024 04:56:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCBMJ-0003Zl-Us; Wed, 29 May 2024 00:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCBMI-0003Z6-EH for qemu-riscv@nongnu.org; Wed, 29 May 2024 00:56:18 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCBMG-00023L-3p for qemu-riscv@nongnu.org; Wed, 29 May 2024 00:56:18 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-52ae14e78e5so249746e87.3 for ; Tue, 28 May 2024 21:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716958574; x=1717563374; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RjQLcO+jti6a0l4UzCHBRgK9x2OIJpQajNqtYvux1Gs=; b=px88/112qtgkdEjwCJFE2RZob5/EDRhmThq+MqYONT45zzexaPPiSceuXEfV7Dp3Cv 6ujvc9gCxxGnyTugdJVogpDFbHPDKXkLhmmH3jJmiO0SRc+HMqqxcbw8Q5why4FDAhuZ dMzn4ANZvPdPPknbsU7uhS+8qy4rdo18b+CiAy7jQWLqx6NNrm5OIey6tPkv03VNcVpX X+IewI3gjDxCropJJTfavi7l9uiDo2wv1HmH+/On04FOL/OHIaqVIW9N/SJYFah+3Ssu x/BER5ES9IYBw/TJOITfYIDgSrEZG2kVucFtBig6wae75ibQS7Snq8eAZck7Yz+wz602 Gz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716958574; x=1717563374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RjQLcO+jti6a0l4UzCHBRgK9x2OIJpQajNqtYvux1Gs=; b=Q8HDmXNbD4VqVQs6WdgKFlwIlX/oFjeS8+bvriQMkQE8R8hJAlTsDFDYWRNTnELhzt svr/38l4Y7wESZashxUgP/GkNUAz4xG/kRAbvUZnhtARp519J9DpfBUnbBYb3R5U5Osr b5etCxvDQjubYawQ4lpjE0+g11DnUgTLaxPU+ug2ROaVMZZDWXykmZMn+0uFdEcfKXSB alXmgWE3CWZ4WfkLFQlaHdtUGbkFhUSYaA6eDYSqTx7hBok6jjOiN4Ho3xO55h4ge5UK fublUobnJgCZvC84vFcQsGgOwbUEVXhrN43oXA0DDBprUXoW+ccKhqqThsEn05WM6wIu qBbw== X-Gm-Message-State: AOJu0Yzw5IRCecwJWNkE/tR/Nak60E3K3ZoKVcEljG8HHaY2B38Lx9yk cTjWYAYF46lcoI9edPQa0jAWyiaHAcAo4uApljpGLRJ84GNUnOuIaPwqTyj9jQpo6mNXV6mZal/ S X-Google-Smtp-Source: AGHT+IFcL7ZWs9vLZjW7XUeP+QY60hoD+A5njo8CuJalM3wyzhhx7mp4aZRhDsZ4kCV/FBefAulNsg== X-Received: by 2002:a05:6512:3096:b0:523:87b6:2ac2 with SMTP id 2adb3069b0e04-52965199527mr11586460e87.40.1716958574179; Tue, 28 May 2024 21:56:14 -0700 (PDT) Received: from [192.168.69.100] ([176.187.204.141]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626c9776e2sm681725966b.91.2024.05.28.21.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 21:56:13 -0700 (PDT) Message-ID: Date: Wed, 29 May 2024 06:56:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] target/riscv: Use get_address() to get address with Zicbom extensions To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, Palmer Dabbelt , Bin Meng , Alistair Francis , Christoph Muellner , Philipp Tomsich , Liu Zhiwei , Weiwei Li , Palmer Dabbelt , Daniel Henrique Barboza , Zhiwei Jiang References: <20240419110514.69697-1-philmd@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240419110514.69697-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=philmd@linaro.org; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org ping? On 19/4/24 13:05, Philippe Mathieu-Daudé wrote: > We need to use get_address() to get an address from cpu_gpr[], > since $zero is "special" (NULL). > > Fixes: e05da09b7c ("target/riscv: implement Zicbom extension") > Reported-by: Zhiwei Jiang (姜智伟) > Signed-off-by: Philippe Mathieu-Daudé > --- > target/riscv/insn_trans/trans_rvzicbo.c.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/riscv/insn_trans/trans_rvzicbo.c.inc b/target/riscv/insn_trans/trans_rvzicbo.c.inc > index d5d7095903..6f6b29598d 100644 > --- a/target/riscv/insn_trans/trans_rvzicbo.c.inc > +++ b/target/riscv/insn_trans/trans_rvzicbo.c.inc > @@ -31,27 +31,27 @@ > static bool trans_cbo_clean(DisasContext *ctx, arg_cbo_clean *a) > { > REQUIRE_ZICBOM(ctx); > - gen_helper_cbo_clean_flush(tcg_env, cpu_gpr[a->rs1]); > + gen_helper_cbo_clean_flush(tcg_env, get_address(ctx, a->rs1, 0)); > return true; > } > > static bool trans_cbo_flush(DisasContext *ctx, arg_cbo_flush *a) > { > REQUIRE_ZICBOM(ctx); > - gen_helper_cbo_clean_flush(tcg_env, cpu_gpr[a->rs1]); > + gen_helper_cbo_clean_flush(tcg_env, get_address(ctx, a->rs1, 0)); > return true; > } > > static bool trans_cbo_inval(DisasContext *ctx, arg_cbo_inval *a) > { > REQUIRE_ZICBOM(ctx); > - gen_helper_cbo_inval(tcg_env, cpu_gpr[a->rs1]); > + gen_helper_cbo_inval(tcg_env, get_address(ctx, a->rs1, 0)); > return true; > } > > static bool trans_cbo_zero(DisasContext *ctx, arg_cbo_zero *a) > { > REQUIRE_ZICBOZ(ctx); > - gen_helper_cbo_zero(tcg_env, cpu_gpr[a->rs1]); > + gen_helper_cbo_zero(tcg_env, get_address(ctx, a->rs1, 0)); > return true; > }