Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474D615E8E for ; Fri, 12 Jan 2024 18:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C0rAFPzj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F71CC43390; Fri, 12 Jan 2024 18:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705085617; bh=21qOPdLaKdN60+G+z+Lc0e12NHNHs20wxrMNpf/tOIE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=C0rAFPzjZPtwgT/VOFx62dZe6QX1IwHyWUD9pIv7mjp7G81xxpiGLhP4/G7GImgCR 1MN08Nfu/IEPeIXfYrWizVI1wadYPt5BVyrbAV+rO9+LVxV5mtka4Cya6shtqcqlj/ zIXUgmyZ190dNVre1ABi4m0+8wGX3zIw+aoVu4WDYKnlZ9jIaqS3caDM4Fy9SX8pop 4SstoOy71tnSt/+AD5DHsgIy1qZfpSSz0ansnHPn0pyRtLOqkAFEKc7TB5ObHLKbQ9 PIGoN18FY3YINerN77pmHwPiKoeCMq9IeOpYpFhNiUnf0vM/LWso6l1SkE/izGI8pB FL6LNL8Dn2G/g== Date: Fri, 12 Jan 2024 10:53:36 -0800 (PST) From: Mat Martineau To: Eric Dumazet cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Matthieu Baerts , Geliang Tang , Florian Westphal , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN option In-Reply-To: <20240111194917.4044654-1-edumazet@google.com> Message-ID: References: <20240111194917.4044654-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Thu, 11 Jan 2024, Eric Dumazet wrote: > Based on a syzbot report (see 4th patch in the series). > > We need to be more explicit about which one of the > following flag is set by mptcp_parse_option(): > > - OPTION_MPTCP_MPJ_SYN > - OPTION_MPTCP_MPJ_SYNACK > - OPTION_MPTCP_MPJ_ACK > > Then select the appropriate values instead of OPTIONS_MPTCP_MPJ > > Paolo suggested to do the same for OPTIONS_MPTCP_MPC (5th patch) > > Eric Dumazet (5): > mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN > mptcp: strict validation before using mp_opt->hmac > mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect() > mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req() > mptcp: refine opt_mp_capable determination > > net/mptcp/options.c | 6 +++--- > net/mptcp/subflow.c | 16 ++++++++-------- > 2 files changed, 11 insertions(+), 11 deletions(-) Hi Eric - Thanks for the fixes, code looks good (one separate commit message comment on patch 5): Reviewed-by: Mat Martineau