Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB34CC38142 for ; Fri, 27 Jan 2023 09:19:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C769855D3; Fri, 27 Jan 2023 10:19:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="NIpJfeYa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4C3DD854C7; Fri, 27 Jan 2023 10:19:28 +0100 (CET) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB24D856CC for ; Fri, 27 Jan 2023 10:19:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=souajih@baylibre.com Received: by mail-wm1-x331.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so4963737wma.1 for ; Fri, 27 Jan 2023 01:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ye3IwBrBcvozRj0SclRSJyDBMG82sD5q+rx+GVh04I=; b=NIpJfeYa8sqEIdXCJ2pIdK72Po2sENftloUL4dhvTBg8BLXdQEuLOoYTBZl0P/ArXO 5JmSexk9+yY1xz9/P4wP1uZi3Zzz5H3mEgOFXZj231cmUJqHztJrUVM3xx4rlGrtMLPK wqj0i0nEnCdKIT/+/Jj1hJVVijRHNkfq0jxZuvh+6cTCeG37q/d9r2Yh1j+sBMmUDg2L mqzBlLoMKrx6lCklRqxqcNUkGwwlTXaQU60RP5o/TSEaBnSNOMe3vIpuUmYORmzNJUtB huH0pCrHGV6NbGbNL759P9LD2or3+dWFB5FoWSB3IkANlBt9AmQJKqlkklAVlc9zcUX8 d55g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ye3IwBrBcvozRj0SclRSJyDBMG82sD5q+rx+GVh04I=; b=PT/XzNfDCCEsjpRkp9wZQxCG3EvDEt2978r8OLIFIR6PKTTThx9Ytrw8G8bgG3NbMY sWqT93OvUflbD4F2WZHqvC9ZraeJ4RP0AcH61IGqCK9x7sC5zJHDHFWYLqcZPpo40NNl QivX8iYEs9v40cKN7EAZE0e02CR0Q1aaO8Iy553ef/glNgmbIPLY24sbgptsqCO056sp NtlPT0A2Tc6L8TfiEVKjd5oYpnt2UiBMmJRP5zxfGmNNM1vr9sOehW2c5uksewrphoKV oHv72CYSaGdwMhl1N/umbDB+eILOknNfk+Kjm+v+2ZnTtsyWPmsoAKKIfs4jheuvEEX3 4slg== X-Gm-Message-State: AO0yUKUHUsbrloKNc7BnQ+8GZ6k3Bmwhfzv+7VnGP/uKh9HWZafEn0Bt HwP8ksVte4losxpAmC526/FwDA== X-Google-Smtp-Source: AK7set9AgiHWGN26uRQAZVndUHnx57PR4ock6Yld+AnB56FtusDyXYJJdZn3U2DH+4baM+tI0OR/TA== X-Received: by 2002:a05:600c:354b:b0:3dc:16d2:ae5e with SMTP id i11-20020a05600c354b00b003dc16d2ae5emr12101348wmq.32.1674811164384; Fri, 27 Jan 2023 01:19:24 -0800 (PST) Received: from [10.2.3.222] (lfbn-nic-1-295-18.w90-116.abo.wanadoo.fr. [90.116.132.18]) by smtp.gmail.com with ESMTPSA id ip6-20020a05600ca68600b003d04e4ed873sm6979896wmb.22.2023.01.27.01.19.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 01:19:24 -0800 (PST) Message-ID: Date: Fri, 27 Jan 2023 10:19:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 00/17] Support android boot image v3/v4 Content-Language: en-US To: Roman Stratiienko Cc: sjg@chromium.org, u-boot@lists.denx.de, sean.anderson@seco.com, mkorpershoek@baylibre.com, glaroque@baylibre.com, khilman@baylibre.com References: <20230126160506.1026643-1-souajih@baylibre.com> From: Safae Ouajih In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 26/01/2023 19:17, Roman Stratiienko wrote: > чт, 26 янв. 2023 г. в 18:05, Safae Ouajih : >> Hello everyone, >> >> * This is based on Roman Stratiienko's work to support boot image header version 3 and 4. >> >> * This supports the new boot image headers v3, v4 and bootconfig feature. >> https://source.android.com/docs/core/architecture/bootloader/boot-image-header >> https://source.android.com/docs/core/architecture/bootloader/implementing-bootconfig >> >> - Tested on Amlogic Khadas vim3l, a reference board for Android Open Source Project >> https://www.khadas.com/vim3l >> >> And on AM625 Texas Instruments board with 5.10 linux kernel >> >> Main changes : >> - New partition : vendor boot, with a specific vendor ramdisk >> - DTB is stored in the vendor boot partition >> - The generic ramdisk is placed after the vendor ramdisk >> - Bootconfig feature support >> >> >> Here is a link to see the related android boot flow changes on KHADAS vim3l as an example: >> https://gitlab.baylibre.com/baylibre/amlogic/atv/u-boot/-/commits/souajih/BootImagev4/ >> >> Changes in v2: >> - Rework parts of the code to fix the abootimg test: test_abootimg >> - Update test_abootimg to support boot image header v4 >> - Remove LIBXBC library, import and adapt the functions to support bootconfig feature >> - Rename the used structures : >> andr_boot_img_hdr_v0_v1_v2 -> andr_boot_img_hdr_v0 >> andr_boot_img_hdr_v3_v4 -> andr_boot_img_hdr_v3 >> andr_vendor_boot_img_hdr_v3_v4 -> andr_vendor_img_hdr > Hello, > > Thanks for these patches. > > Please note that Android has both vendor.img and boot_vendor.img > I would suggest adding some prefix, e.g. andr_bootvnd_img_hdr or > something similar. Hello, Thank you for your remark. Indeed " struct andr_vendor_img_hdr " can be confusing. To differentiate vendor.img and vendor_boot.img I will make the following changed in a v3: struct andr_vendor_img_hdr -> struct andr_vnd_boot_img_hdr Best regards, --safae >> Safae Ouajih (17): >> android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0 >> android: boot: support vendor boot image in abootimg >> android: boot: replace android_image_check_header >> android: boot: add boot image header v3 and v4 structures >> android: boot: kcomp: support andr_image_data >> android: boot: move to andr_image_data structure >> android: boot: content print is not supported for v3,v4 header version >> android: boot: boot image header v3,v4 do not support recovery DTBO >> android: boot: add vendor boot image to prepare for v3,v4 support >> android: boot: update android_image_get_data to support v3,v4 >> android: boot: ramdisk: support vendor ramdisk >> android: boot: support extra command line >> android: boot: update android_image_get_dtb_img_addr to support v3,v4 >> drivers: fastboot: zImage flashing is not supported for v3,v4 >> android: boot: support boot image header version 3 and 4 >> android: boot: support bootconfig >> test/py: android: extend abootimg test >> >> boot/bootm.c | 29 +- >> boot/image-android.c | 467 ++++++++++++++++---- >> boot/image-board.c | 15 +- >> boot/image-fdt.c | 5 +- >> cmd/abootimg.c | 75 +++- >> drivers/fastboot/fb_mmc.c | 19 +- >> include/android_image.h | 228 +++++++++- >> include/image.h | 37 +- >> test/py/tests/test_android/test_abootimg.py | 135 +++++- >> 9 files changed, 850 insertions(+), 160 deletions(-) >> >> -- >> 2.34.1 >>