From: "flichtenheld (Code Review)" Date: Wed, 28 Feb 2024 13:03:11 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="fMn/FHr+/PA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --fMn/FHr+/PA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/478?usp=3Demail ) Change subject: tests: fork default automake test-driver ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Some additional context for this patch and #479: Originally the switch to parallel test framework was triggered by https://gerrit.openvpn.net/c/openvpn/+/474 which required setting up additional environment. This is also possible in the serial-test framework, but was much more obvious with parallel. The parallel test framework is the newer one which offers a lot more options for customization. It is recommended by automake authors. So I tested whether it works with our tests or whether there is any reason it wouldn't work. It works fine. In parallel there was a discussion where cron2 complained about the test execution being too verbose, especially for the UTs. This is addressed by the parallel test framework which is much less verbose by default, but can't be addressed in serial-test framework. The problem is that the parallel test framework default behavior is not desirable in t_client context since that runs for a long time and we would like to see live progress. This is solvable in the parallel test framework since it is very configurable, but it requires us forking the default test driver since the default test driver itself is not configurable. You need to override it. That is implemented by https://gerrit.openvpn.net/c/openvpn/+/478 (copy test driver) https://gerrit.openvpn.net/c/openvpn/+/479 (patch it) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/478?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I67d461afbcc9c06b1fc5ab4477141d7b8bd9ba8e Gerrit-Change-Number: 478 Gerrit-PatchSet: 8 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Comment-Date: Wed, 28 Feb 2024 13:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --fMn/FHr+/PA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #8:

      Some additional context for this patch and #479:

      Originally the= switch to parallel test framework was triggered by
      https://gerrit.openv= pn.net/c/openvpn/+/474 which required setting
      up additional environment.= This is also possible in the serial-test
      framework, but was much more o= bvious with parallel.

      The parallel test framework is the newer one which offers a lot mo= re
      options for customization. It is recommended by automake authors.
      = So I tested whether it works with our tests or whether there is any
      reas= on it wouldn't work. It works fine.

      In parallel there was a discussion where cron2 c= omplained about the
      test execution being too verbose, especially for the= UTs. This is
      addressed by the parallel test framework which is much les= s verbose
      by default, but can't be addressed in serial-test framewor= k.

      The proble= m is that the parallel test framework default behavior is
      not desirable = in t_client context since that runs for a long time
      and we would like to= see live progress. This is solvable in the
      parallel test framework sinc= e it is very configurable, but it
      requires us forking the default test d= river since the default
      test driver itself is not configurable. You need= to override it.
      That is implemented by
      https://gerrit.openvpn.net/c/= openvpn/+/478 (copy test driver)
      https://gerrit.openvpn.net/c/openvpn/+/= 479 (patch it)

To view, visit change 478. To unsubscri= be, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I67d461afbcc9c06b1fc5ab44771= 41d7b8bd9ba8e
Gerrit-Change-Number: 478
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Comment-Date: Wed, 28 Feb 2024 13:03:11= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--fMn/FHr+/PA=--