Message-ID: Date: Mon, 25 Jul 2022 12:17:58 +0200 MIME-Version: 1.0 Content-Language: en-GB References: From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] PUSH_BUNDLE_SIZE is too short List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Angel Abad , openvpn-devel@lists.sourceforge.net Am 24.07.22 um 19:46 schrieb Angel Abad: > Description: PUSH_BUNDLE_SIZE is too short > Author: Angel Abad > --- > > Hello, we have problem with a large used openvpn server, our server push to clients > almos 150 routes, we havent problem with windows clients, but with linux clients push > options are cut, and the clients fail to configure beacouse the route commmands are cut. > > We look code and verify that push bundle size is only 1024, so push options on linux are cut > on this size. We looked openvpn3 too, and there this limit is 2048 > > https://github.com/OpenVPN/openvpn3/blob/e1a35028a82acaf5ae6caeae321d83c36477d27c/openvpn/tun/linux/client/sitnl.hpp#L50 That is the buffer size of the netlink socket. That has absolutely nothing to do with PUSH bundle size. The maximum PUSH bundle size that OpenVPN3 will generate is also 1024: https://github.com/OpenVPN/openvpn3/blob/master/openvpn/options/continuation_fragment.hpp#L42 > > Could you please increase this limit on openvpn2 or provide a configuration option to > increase it? There are a patches from me for master that allow adjusting control channel max size. However, our OpenVPN 2 server code should never send a push message that exceeds the 1024 byte limit. Increasing this size for both client and server will break existing setups. Can you explain your setup and how to reproduce the bug? In the current form this patch is a NAK from me. Arne