Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E7F7C4332F for ; Wed, 9 Nov 2022 17:28:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09DB285001; Wed, 9 Nov 2022 18:28:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="A2NheNux"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9BF2185081; Wed, 9 Nov 2022 18:28:00 +0100 (CET) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4F08D84D85 for ; Wed, 9 Nov 2022 18:27:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2A9HRpdl033715; Wed, 9 Nov 2022 11:27:51 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668014871; bh=VhUXKxvoQ2cvTNZTY4W6w/vpaK18NY8t5lwB8qrNU8Y=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=A2NheNuxznjLGznpF5XaI5NjMSDFhnGRvidii3a+/yyVJrzKL4vXsUgmwT9erW96c Jua52cd1oK6ZGRBqtWLJYpwpjGlq+xBp6bTI6tqCxz9yBnsyZIEKSsq+Xlo5a6MsY2 IKGXHLWE/0mUdrRteyxhQFt1xWiyBowhLVwiHnoY= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2A9HRpxh043162 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Nov 2022 11:27:51 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Wed, 9 Nov 2022 11:27:51 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Wed, 9 Nov 2022 11:27:51 -0600 Received: from [128.247.81.39] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2A9HRpuG059588; Wed, 9 Nov 2022 11:27:51 -0600 Message-ID: Date: Wed, 9 Nov 2022 11:27:51 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] doc: board: j721e_evm: Add DM firmware steps Content-Language: en-US To: Heinrich Schuchardt CC: Simon Glass , Tom Rini , References: <20221007203759.28533-1-afd@ti.com> <01a2f7c7-0a1a-10bc-b6b6-662d9d60919f@ti.com> From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/6/22 2:49 AM, Heinrich Schuchardt wrote: > On 11/1/22 15:06, Andrew Davis wrote: >> On 10/7/22 6:47 PM, Heinrich Schuchardt wrote: >>> On 10/7/22 22:37, Andrew Davis wrote: >>>> J721e needs DM firmware when using updated SYSFW. Add steps to fetch, >>>> build, and deploy the same. >>>> >>>> Signed-off-by: Andrew Davis >>>> --- >>>>   doc/board/ti/j721e_evm.rst | 16 ++++++++++------ >>>>   1 file changed, 10 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst >>>> index 44dc316afd..a7d7229722 100644 >>>> --- a/doc/board/ti/j721e_evm.rst >>>> +++ b/doc/board/ti/j721e_evm.rst >>>> @@ -142,7 +142,11 @@ Sources: >>>>       Tree: https://github.com/OP-TEE/optee_os.git >>>>       Branch: master >>>> >>>> -4. U-Boot: >>>> +4. DM: > > DM in the context of U-Boot is used as abbreviation for driver model. > > Please, provide a meaningful title. > Will rename to "DM Firmware" for v3. Thanks, Andrew > Best regards > > Heinrich > >>>> +    Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >>>> +    Branch: ti-linux-firmware >>>> + >>>> +5. U-Boot: >>>>       Tree: https://source.denx.de/u-boot/u-boot >>>>       Branch: master >>>> >>>> @@ -152,7 +156,7 @@ Build procedure: >>>> >>>>   .. code-block:: text >>> >>> Thanks for updating the documentation. >>> >>> The code-blocks look like bash and not text. Please, correct this >>> information to allow syntax highlighting. >>> >>>> >>>> - $ make CROSS_COMPILE=arm-linux-gnueabihf- >>>> + $ make CROSS_COMPILE=arm-linux-gnueabihf- SOC=j721e >>> >>> Please, remove the leading $-signs which are not helpful when copying to >>> the console. >>> >>> Please indent code blocks by 4 spaces. Otherwise Sphinx cannot recognize >>> them. >>> >> >> >> Will fix all the code blocks then in a single patch, add it to this as >> a follow up in a series. >> >> Thanks, >> Andrew >> >> >>> Best regards >>> >>> Heinrich >>> >>>> >>>>   2. ATF: >>>> >>>> @@ -172,15 +176,15 @@ Build procedure: >>>> >>>>   .. code-block:: text >>>> >>>> - $ make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig >>>> O=/tmp/r5 >>>> - $ make CROSS_COMPILE=arm-linux-gnueabihf- O=/tmp/r5 >>>> + $ make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig >>>> O=build/r5 >>>> + $ make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5 >>>> >>>>   * 4.2 A72: >>>> >>>>   .. code-block:: text >>>> >>>> - $ make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig >>>> O=/tmp/a72 >>>> - $ make CROSS_COMPILE=aarch64-linux-gnu- ATF=>>> dir>/build/k3/generic/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=>>> image> O=/tmp/a72 >>>> + $ make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig >>>> O=build/a72 >>>> + $ make CROSS_COMPILE=aarch64-linux-gnu- ATF=>>> dir>/build/k3/generic/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=DM=>>> firmware>/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.xer5f >>>> O=build/a72 >>>> >>>>   Target Images >>>>   -------------- >>> >