From: Dhinakaran Pandiyan Subject: Re: [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts Date: Fri, 05 Oct 2018 11:33:41 -0700 Message-ID: References: <20181004205149.9286-1-dhinakaran.pandiyan@intel.com> <20181004230303.GA23914@ldmartin-desk.jf.intel.com> <20181004232835.GA4163@intel.com> <20181005002717.GB4163@intel.com> <20181005181034.GC4163@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D80796E02E for ; Fri, 5 Oct 2018 18:33:43 +0000 (UTC) In-Reply-To: <20181005181034.GC4163@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTA1IGF0IDExOjEwIC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ IE9uIFRodSwgT2N0IDA0LCAyMDE4IGF0IDA3OjU2OjM3UE0gLTA3MDAsIERoaW5ha2FyYW4gUGFu ZGl5YW4gd3JvdGU6Cj4gPiBPbiBUaHUsIDIwMTgtMTAtMDQgYXQgMTc6MjcgLTA3MDAsIE1hbmFz aSBOYXZhcmUgd3JvdGU6Cj4gPiA+IE9uIFRodSwgT2N0IDA0LCAyMDE4IGF0IDA1OjAwOjA2UE0g LTA3MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4KPiA+ID4gd3JvdGU6Cj4gPiA+ID4gT24gVGh1LCAy MDE4LTEwLTA0IGF0IDE2OjI4IC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ID4gPiA+ID4g T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDQ6MTM6MjZQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbgo+ID4gPiA+ID4gd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIFRodSwgMjAxOC0xMC0wNCBhdCAx NjowMyAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIHdyb3RlOgo+ID4gPiA+ID4gPiA+IE9uIFRodSwg T2N0IDA0LCAyMDE4IGF0IDAxOjUxOjQ5UE0gLTA3MDAsIERoaW5ha2FyYW4KPiA+ID4gPiA+ID4g PiBQYW5kaXlhbgo+ID4gPiA+ID4gPiA+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gVGhlIHNoaWZ0 cyBmb3IgVlNDX1NFTEVDVCBiaXRzIGFyZSB3cm9uZywgZml4IGl0LiBHb29kCj4gPiA+ID4gPiA+ ID4gPiB0aGluZyBpcwo+ID4gPiA+ID4gPiA+ID4gdGhlCj4gPiA+ID4gPiA+ID4gPiBkZWZpbml0 aW9ucyBhcmUgdW51c2VkLgo+ID4gPiAKPiA+ID4gTm8gbmVlZCB0byBtZW50aW9uIHRoYXQgZGVm cyBhcmUgdW51c2VkIGluIHRoZSBjb21taXQgc2luY2UgdGhhdAo+ID4gPiB3aWxsCj4gPiA+IG5v dCBtYWtlIHNlbnNlCj4gPiA+IG9uY2UgdGhlIHBhdGNoZXMgZ2V0IG1lcmdlZCB0aGF0IHN0YXJ0 IHVzaW5nIHRoZXNlLgo+ID4gCj4gPiBXZWxsLCB0aGUgcGF0Y2ggaXMgYmFzZWQgb24gdGhlIGN1 cnJlbnQgc3RhdGUgb2YgdGhlIGNvZGUgYmFzZS4KPiA+IAo+IAo+IFdlbGwgSU1ITyB0aGF0IHN0 YXRlbWVudCBpcyBzdGlsbCByZWR1bmRhbnQgYW5kIG1vcmUgZXhwcmVzc2l2ZSB0aGFuCj4gaW5m b3JtYXRpdmUuCj4gTWVudGlvbmluZyB0aGF0IHRoaXMgaXMKPiBhIGZpeCBmb3IgVlNDIFNFTEVD VCBzaG91bGQgc3VmZmljZS4gQnV0IHRoYXRzIGEgbml0Y3BpY2ssIHNvIGl0cwo+IHlvdXIgY2Fs bC4KPiAgIAo+ID4gPiAKPiA+ID4gTW9yZSBjb21tZW50cyBiZWxvdwo+ID4gPiAKPiA+ID4gPiA+ ID4gPiAKPiA+ID4gPiA+ID4gPiBJZiB0aGV5IGFyZSB1bnVzZWQgd2h5IGFyZSB3ZSBmaXhpbmcg dGhlbSBpbnN0ZWFkIG9mCj4gPiA+ID4gPiA+ID4gcmVtb3Zpbmc/IE9yCj4gPiA+ID4gPiA+ID4g YmV0dGVyLAo+ID4gPiA+ID4gPiA+IHdoeSBkaWQgd2UgYWRkIHRoZW0/Cj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBJIGd1ZXNzIHRoZXJlIGFyZSBwbGFucyB0byBtYWtlIHVzZSBvZiB0aGVtLCBu byBpZGVhLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gWWVzLCB0aGUgVkRJUF9S TkFCTEVfUFBTIGFuZCBESVAgZW5hYmxlcyBnZXQgdXNlZCBpbiB0aGUgRFNDCj4gPiA+ID4gPiBw YXRjaAo+ID4gPiA+ID4gc2VyaWVzOgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBodHRwczovL3BhdGNo d29yay5mcmVlZGVza3RvcC5vcmcvc2VyaWVzLzQ3NTE0Lwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJ ZiB5b3Ugd2FudCBJIGNhbiBjb21iaW5lIHRoaXMgZml4ZXMgcGF0Y2ggd2l0aCB0aGUgbmV3Cj4g PiA+ID4gPiByZXZpc2lvbgo+ID4gPiA+ID4gb2YKPiA+ID4gPiA+IERTQyBwYXRjaHNlcmllcwo+ ID4gPiA+ID4gSSBhbSBhYm91dCB0byBzZW5kIG91dAo+ID4gPiA+IAo+ID4gPiA+IFRoYXQgbWln aHQgY3JlYXRlIGFuIHVubmVjZXNzYXJ5IGRlcGVuZGVuY3kgb24gdGhlIHNlcmllcwo+ID4gPiA+ IGdldHRpbmcKPiA+ID4gPiBtZXJnZWQuIFdlJ2xsIGhhdmUgdG8gcHJvZ3JhbSB0aGVzZSBiaXRz IGZvciBQU1IyIGZyb20gdGhlCj4gPiA+ID4gbG9va3Mgb2YKPiA+ID4gPiBpdC4KPiA+ID4gPiBM ZXQncyBnZXQgdGhpcyBpbnRvIHRoZSB0cmVlIHNvb24sIGNhbiB5b3UgcGxlYXNlIHJldmlldyB0 aGUKPiA+ID4gPiBmaXg/Cj4gPiA+ID4gCj4gPiA+ID4gLURLCj4gPiA+ID4gCj4gPiA+ID4gPiAK PiA+ID4gPiA+IE1hbmFzaQo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gPiBDYzogQW51c2hhLCBNYW5h c2kKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gTHVjYXMgRGUgTWFy Y2hpCj4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IENjOiBN YW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+ID4g Q2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVsLmNvbT4KPiA+ID4gPiA+ ID4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+ID4g PiA+ID4gPiBGaXhlczogN2FmMmJlNmQ1NGQ0ICgiZHJtL2k5MTUvaWNsOiBBZGQgVklERU9fRElQ Cj4gPiA+ID4gPiA+ID4gPiByZWdpc3RlcnMiKQo+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1i eTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8Cj4gPiA+ID4gPiA+ID4gPiBkaGluYWthcmFuLnBhbmRp eWFuQGludGVsLmNvbT4KPiA+ID4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggfCAxOCArKysrKysrKystLS0tLS0KPiA+ID4gPiA+ ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMo KyksIDkgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiA+ID4gPiA+ID4gPiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gPiA+ID4gPiA+IGluZGV4IDI3 ZTY1MGZlNTkxYi4uYTBhZDc3YjkyMTJiIDEwMDY0NAo+ID4gPiA+ID4gPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4gPiA+ID4gQEAgLTQ1ODQsNiArNDU4 NCwxNSBAQCBlbnVtIHsKPiA+ID4gPiA+ID4gPiA+ICAjZGVmaW5lICAgVklERU9fRElQX0ZSRVFf MlZTWU5DCQkoMiA8PAo+ID4gPiA+ID4gPiA+ID4gMTYpCj4gPiA+ID4gPiA+ID4gPiAgI2RlZmlu ZSAgIFZJREVPX0RJUF9GUkVRX01BU0sJCSgzIDw8IDE2KQo+ID4gPiA+ID4gPiA+ID4gIC8qIEhT VyBhbmQgbGF0ZXI6ICovCj4gPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIERSTV9ESVBfRU5BQkxF CQkoMSA8PCAyOCkKPiA+ID4gPiA+ID4gPiA+ICsjZGVmaW5lICAgUFNSX1ZTQ19CSVRfN19TRVQJ CSgxIDw8IDI3KQo+ID4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfU0VMRUNUX01BU0sJCSgw eDMgPDwgMjUpCj4gPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFZTQ19TRUxFQ1RfU0hJRlQJCTI1 Cj4gPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFZTQ19ESVBfSFdfSEVBX0RBVEEJCSgwIDw8IDI1 KQo+ID4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfRElQX0hXX0hFQV9TV19EQVRBCSgxIDw8 IDI1KQo+ID4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfRElQX0hXX0RBVEFfU1dfSEVBCSgy IDw8IDI1KQo+ID4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfRElQX1NXX0hFQV9EQVRBCQko MyA8PCAyNSkKPiA+ID4gPiA+ID4gPiA+ICsjZGVmaW5lICAgVkRJUF9FTkFCTEVfUFBTCQkoMSA8 PCAyNCkKPiA+ID4gPiA+ID4gPiA+ICAjZGVmaW5lICAgVklERU9fRElQX0VOQUJMRV9WU0NfSFNX CSgxIDw8IDIwKQo+ID4gPiA+ID4gPiA+ID4gICNkZWZpbmUgICBWSURFT19ESVBfRU5BQkxFX0dD UF9IU1cJKDEgPDwgMTYpCj4gPiA+ID4gPiA+ID4gPiAgI2RlZmluZSAgIFZJREVPX0RJUF9FTkFC TEVfQVZJX0hTVwkoMSA8PCAxMikKPiA+ID4gPiA+ID4gPiA+IEBAIC00NTkxLDE1ICs0NjAwLDYg QEAgZW51bSB7Cj4gPiA+ID4gPiA+ID4gPiAgI2RlZmluZSAgIFZJREVPX0RJUF9FTkFCTEVfR01Q X0hTVwkoMSA8PCA0KQo+ID4gPiA+ID4gPiA+ID4gICNkZWZpbmUgICBWSURFT19ESVBfRU5BQkxF X1NQRF9IU1cJKDEgPDwgMCkKPiA+ID4gPiA+ID4gPiA+ICAKCQkJCQkJCS0+Cj4gPiA+ID4gPiA+ ID4gPiAtI2RlZmluZSAgRFJNX0RJUF9FTkFCTEUJCQkoMSA8PAo+ID4gPiA+ID4gPiA+ID4gMjgp Cj4gPiA+ID4gPiA+ID4gPiAtI2RlZmluZSAgUFNSX1ZTQ19CSVRfN19TRVQJCSgxIDw8IDI3KQo+ ID4gPiA+ID4gPiA+ID4gLSNkZWZpbmUgIFZTQ19TRUxFQ1RfTUFTSwkJKDB4MyA8PCAyNikKPiA+ ID4gPiA+ID4gPiA+IC0jZGVmaW5lICBWU0NfU0VMRUNUX1NISUZUCQkyNgo+ID4gPiA+ID4gPiA+ ID4gLSNkZWZpbmUgIFZTQ19ESVBfSFdfSEVBX0RBVEEJCSgwIDw8IDI2KQo+ID4gPiA+ID4gPiA+ ID4gLSNkZWZpbmUgIFZTQ19ESVBfSFdfSEVBX1NXX0RBVEEJCSgxIDw8Cj4gPiA+ID4gPiA+ID4g PiAyNikKPiA+ID4gPiA+ID4gPiA+IC0jZGVmaW5lICBWU0NfRElQX0hXX0RBVEFfU1dfSEVBCQko MiA8PAo+ID4gPiA+ID4gPiA+ID4gMjYpCj4gPiA+ID4gPiA+ID4gPiAtI2RlZmluZSAgVlNDX0RJ UF9TV19IRUFfREFUQQkJKDMgPDwgMjYpCj4gPiA+ID4gPiA+ID4gPiAtI2RlZmluZSAgVkRJUF9F TkFCTEVfUFBTCQkoMSA8PCAyNCkKPiA+ID4gCj4gPiA+IFdoeSBkbyB5b3UgbmVlZCB0byByZW1v dmUgYWxsIG9mIHRoZXNlIGRlZnM/Cj4gPiA+IEZyb20gdGhlIHNwZWMsIHRoZSBvbmx5IHNoaWZ0 IHRoYXRzIHdyb25nIGlzIDoKPiA+ID4gVlNDX1NFTEVDVF9NQVNLICAgICAgICAgICAgICgweDMg PDwgMjYpCj4gPiA+ICNkZWZpbmUgIFZTQ19TRUxFQ1RfU0hJRlQgICAgICAgICAgICAyNgo+ID4g PiAjZGVmaW5lICBWU0NfRElQX0hXX0hFQV9EQVRBICAgICAgICAgKDAgPDwgMjYpCj4gPiA+IGRl ZmluZSAgVlNDX0RJUF9IV19IRUFfU1dfREFUQSAgICAgICAgICAgICAgKDEgPDwgMjYpCj4gPiA+ IGRlZmluZSAgVlNDX0RJUF9IV19EQVRBX1NXX0hFQSAgICAgICAgICAgICAgKDIgPDwgMjYpCj4g PiA+IFZTQ19ESVBfU1dfSEVBX0RBVEEgICAgICAgICAoMyA8PCAyNikKPiA+ID4gCj4gPiA+IFJl bW92aW5nIG90aGVycyBhbmQgcmVkZWZpbmluZyB0byBiZSB0aGUgc2FtZSBpcyBtaXNsZWFkaW5n Cj4gPiAKPiA+IFBsZWFzZSBzZWUgb3RoZXIgZGVmaW5pdGlvbnMgaW4gdGhlIGZpbGUgYW5kIHRo ZSBkb2N1bWVudGF0aW9uCj4gPiBhYm92ZSwKPiA+IHdlIGdlbmVyYWxseSBvcmdhbml6ZSBiaXQg ZGVmaW5pdGlvbnMgaW4gdGhlIGRlc2NlbmRpbmcgb3JkZXIgb2YKPiA+IHRoZWlyCj4gPiBwb3Np dGlvbi4KPiA+IAo+IAo+IEkgc3RpbGwgZG9udCBzZWUgd2h5IHlvdSBoYWQgcmVtb3ZlIGVhcmxp ZXIgZGVmcyBhbmQgcmVkZWZpbmUgc2luY2UKPiBpdCB3YXMgYWxyZWFkeSBvcmdhbml6ZWQgaW4g ZGVzY2VuZGluZyBvcmRlciBvZiB0aGVpciBwb3NpdGlvbiBpbiB0aGUKPiBvcmlnaW5sCj4gcGF0 Y2hlcyBzdGFydGluZyB3aXRoIERSTV9ESVBfRU5BQkxFIHdpdGggMTw8IDI4IGFsbCB0aGUgd2F5 IHRvCj4gVkRJUF9FTkFCTEVfUFBTIHdpdGgKPiAxIDw8IDI0IGFuZCB5b3VyIGNoYW5nZXMga2Vl cHMgdGhlIHNhbWUgb3JkZXIgd2l0aCB0aGUgZml4IG9mIFZTQwo+IEhTSUZUIGZyb20gMjYgdG8g MjUuCj4gU28gb25seSB0aG9zZSBWU0MgZGVmcyBzaG91bGQgYmUgY2hhbmdlZCBub3QgdGhlIGVu dGlyZSBzZXQuCkl0IHdhcyBkZWZpbmVkIGJlbG93ICgxIDw8IDApCgoKCj4gCj4gTWFuYXNpCj4g IAo+ID4gCj4gPiA+IAo+ID4gPiBPdGhlciB0aGFuIHRoYXQgdGhlIGFjdHVhbCBmaXhlcyBsb29r IGdvb2QsIGRvdWJsZSBjaGVja2VkIHdpdGgKPiA+ID4gdGhlCj4gPiA+IHNwZWMuCj4gPiA+IFNv IGFmdGVyIHRoZSBhYm92ZSBmaXggYW5kIHRoZSBjb21taXQgbWVzc2FnZSBmaXgKPiA+ID4gCj4g PiA+IFJldmlld2VkLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29t Pgo+ID4gPiAKPiA+ID4gTWFuYXNpCj4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gIAo+ID4gPiA+ID4g PiA+ID4gIC8qIFBhbmVsIHBvd2VyIHNlcXVlbmNpbmcgKi8KPiA+ID4gPiA+ID4gPiA+ICAjZGVm aW5lIFBQU19CQVNFCQkJMHg2MTIwMAo+ID4gPiA+ID4gPiA+ID4gLS0gCj4gPiA+ID4gPiA+ID4g PiAyLjE0LjEKPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gPiA+ID4gPiA+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+ID4gPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+ID4gPiA+ID4gPiA+IApodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==