From: "stipa (Code Review)" Date: Tue, 3 Dec 2024 14:42:41 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="1OUfRPZgOdM="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: plaisthos , flichtenheld , openvpn-devel --1OUfRPZgOdM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/809?usp=3Demail ) Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 7: Code-Review-2 (2 comments) File src/openvpn/init.h: http://gerrit.openvpn.net/c/openvpn/+/809/comment/94a55af1_56ebeb0e : PS4, Line 89: bool do_update(struct context *c, unsigned int option_types_f= ound); Doxygen File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/3765b756_2ab72e4d : PS7, Line 3300: && (opt->routes->flags & RG_DEF1)) this gives me "access violation" on Windows, opt->routes is nullptr. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 7 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Tue, 03 Dec 2024 14:42:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --1OUfRPZgOdM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

Patch set 7:Code-Review -2=

Vi= ew Change

2 comments:

  • File src/openvpn/options.c:

  • To view, visit change 809. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I507180d7397b6959844a3090801= 0132bc3411067
    Gerrit-Change-Number: 809
    Gerrit-PatchSet: 7
    Gerrit-Owner: mrbff <marco@...2726...> <= /div>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-Reviewer: stipa <lstipakov@...277...= >
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: mrbff <marco@...2726...&g= t;
    Gerrit-Comment-Date: Tue, 03 Dec 2024 14:42:41= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --1OUfRPZgOdM=--