Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78207C433DB for ; Tue, 12 Jan 2021 07:42:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB89822DD3 for ; Tue, 12 Jan 2021 07:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB89822DD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzEKL-0006sG-PW for qemu-devel@archiver.kernel.org; Tue, 12 Jan 2021 02:42:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzEJK-0006NE-Gv for qemu-devel@nongnu.org; Tue, 12 Jan 2021 02:41:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzEJI-00007h-U7 for qemu-devel@nongnu.org; Tue, 12 Jan 2021 02:41:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610437308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9mD5HY5Mtmlp4RZrVQRYoF/AtOYxVPslrcqcwWQz9MI=; b=gKE92SM4UgtSNXzsv4uZxMUlbXuLYXO+XGHMskZIjneBfy7y5MI5X0ASNxlOl3grxhROlk sLqi1vgyhwAolqrZLuAxQ11gy7vv18Or2YV948jRSpmquT339CrWSmE/ILgKL+YL5VIxHx mZ6qzV6Op0my0A9I7kMSHuIumaSaxH8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-hNPRZjDXMly5MSdaKOy-kw-1; Tue, 12 Jan 2021 02:41:46 -0500 X-MC-Unique: hNPRZjDXMly5MSdaKOy-kw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C719107ACF7; Tue, 12 Jan 2021 07:41:45 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-184.ams2.redhat.com [10.36.112.184]) by smtp.corp.redhat.com (Postfix) with ESMTP id F05659CA0; Tue, 12 Jan 2021 07:41:40 +0000 (UTC) Subject: Re: [PATCH v3 4/5] tests/tcg/s390x: Fix EXRL tests To: David Hildenbrand , qemu-devel@nongnu.org References: <20210111163845.18148-1-david@redhat.com> <20210111163845.18148-5-david@redhat.com> From: Thomas Huth Message-ID: Date: Tue, 12 Jan 2021 08:41:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210111163845.18148-5-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/01/2021 17.38, David Hildenbrand wrote: > The current EXRL tests crash on real machines: we must not use r0 as a base > register for trt/trtr, otherwise the content gets ignored. Also, we must > not use r0 for exrl, otherwise it gets ignored. > > Let's use the "a" constraint so we get a general purpose register != r0. > For op2, we can simply specify a memory operand directly via "Q" (Memory > reference without index register and with short displacement). > > Fixes: ad8c851d2e77 ("target/s390x: add EX support for TRT and TRTR") > Signed-off-by: David Hildenbrand > --- > tests/tcg/s390x/exrl-trt.c | 8 ++++---- > tests/tcg/s390x/exrl-trtr.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/tests/tcg/s390x/exrl-trt.c b/tests/tcg/s390x/exrl-trt.c > index 3c5323aecb..16711a3181 100644 > --- a/tests/tcg/s390x/exrl-trt.c > +++ b/tests/tcg/s390x/exrl-trt.c > @@ -19,7 +19,7 @@ int main(void) > } > asm volatile( > " j 2f\n" > - "1: trt 0(1,%[op1]),0(%[op2])\n" > + "1: trt 0(1,%[op1]),%[op2]\n" > "2: exrl %[op1_len],1b\n" > " lgr %[r1],%%r1\n" > " lgr %[r2],%%r2\n" > @@ -27,9 +27,9 @@ int main(void) > : [r1] "+r" (r1), > [r2] "+r" (r2), > [cc] "=r" (cc) > - : [op1] "r" (&op1), > - [op1_len] "r" (5), > - [op2] "r" (&op2) > + : [op1] "a" (&op1), > + [op1_len] "a" (5), I think op1_len could still stay with "r" instead of "a" ... OTOH "a" also does not hurt here, so: Reviewed-by: Thomas Huth