From: "mattock (Code Review)" Date: Thu, 23 Jan 2025 05:12:58 +0000 In-Reply-To: References: Reply-To: samuli@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="M1pasu7gPg0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , flichtenheld , plaisthos , openvpn-devel --M1pasu7gPg0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/o= penvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > What is the point of backgrounding stuff from an `--up` script that waits= on an (unrelated) foregrou [=E2=80=A6] Yeah, I think that is definitely a better approach. Even better, it seems p= ossible to do what you propose by changing the .ips file format to include = the PID for the client. That way ping_lwip_clients() has the information it= needs to kill the lwip openvpn processes. I also don't see any obvious way= s this restructuring could break the rest of the logic in t_server_null_cli= ent.sh. So, in normal cases ping_lwip_clients() would kill the lwip openvpn clients= . A fallback would the self-termination in lwip_client_up.sh. I'll start working on this. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 9 Gerrit-Owner: mattock Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 23 Jan 2025 05:12:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --M1pasu7gPg0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #8:

      What is the point of b= ackgrounding stuff from an `--up` script that waits on an (unrelated) foreg= rou [=E2=80=A6]

      Yeah, I think that is definitely a better approach. Even be= tter, it seems possible to do what you propose by changing the .ips file fo= rmat to include the PID for the client. That way ping_lwip_clients() has th= e information it needs to kill the lwip openvpn processes. I also don't= see any obvious ways this restructuring could break the rest of the logic = in t_server_null_client.sh.

      So, in normal cases ping_lwip_clients() would kill the lwip = openvpn clients. A fallback would the self-termination in lwip_client_up.sh= .

      I'll st= art working on this.

To view, visit change 811. To uns= ubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 9
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Thu, 23 Jan 2025 05:12:58= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--M1pasu7gPg0=--