Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21D62C4332F for ; Tue, 25 Jan 2022 15:49:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 868B783106; Tue, 25 Jan 2022 16:49:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643125760; bh=VUuklbe++gDynZVVqmruW8NJVglq6G5RhTfs+fejJOc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PXNVHIqYR/5UKZO1/Taei5Cgn2u5kWltPRExIwUPEaHnUBoOJI2Ov6xJn21rslGcf /gwkyVU6vTLJx2U+7427hmkkqdnIPNnENV3fSzPxBffwN24Ct9D4trxHQjhmUiCVKR ot2Dr+FTa+fnkzB8O/8+SXnLoiH2LNkKUWS6mtfXYCa4XI3R5ydmictJccjPBB25cQ XKS80chSMmOzl4k7bccR6f91lW1goRfIEtVDQKgQo1FyqpQp2qhjxapegPLJxLK7TN CRvOuTNecGAcHZXuYAZ1CHiBgWlxe+DruL6UBvZnd6ZsXvNu0MCzCFeaJNUUlIQDjU ru8CuRfw+v9Dg== Received: by phobos.denx.de (Postfix, from userid 109) id 48D4683217; Tue, 25 Jan 2022 16:49:19 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 879A383019 for ; Tue, 25 Jan 2022 16:49:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4JjrrC25d5z9snB; Tue, 25 Jan 2022 16:49:15 +0100 (CET) Message-ID: Date: Tue, 25 Jan 2022 16:49:06 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver Content-Language: en-US To: Tony Dinh , U-Boot Mailing List Cc: Tom Rini , David Purdy , =?UTF-8?B?UGFsaSBSb2jvv71y?= , =?UTF-8?Q?Marek_Beh=ef=bf=bdn?= References: <20220125094846.14504-1-mibodhi@gmail.com> From: Stefan Roese In-Reply-To: <20220125094846.14504-1-mibodhi@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 1/25/22 10:48, Tony Dinh wrote: > The Pogoplug V4 board has the network chip Marvell 88E1118R. So to > properly configure the network, enable CONFIG_PHY_MARVELL to activate > the driver M88E1118R. > > - This patch depends on the series: > https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mibodhi@gmail.com/ > > Signed-off-by: Tony Dinh I was wondering, how all this "magically" works without the Marvell PHY driver being involved. ;) So: Reviewed-by: Stefan Roese Thanks, Stefan > --- > > configs/pogo_v4_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig > index 5490067b9e..1cf409c834 100644 > --- a/configs/pogo_v4_defconfig > +++ b/configs/pogo_v4_defconfig > @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y > CONFIG_MVEBU_MMC=y > CONFIG_MTD=y > CONFIG_MTD_RAW_NAND=y > +CONFIG_PHY_MARVELL=y > CONFIG_DM_ETH=y > CONFIG_MVGBE=y > CONFIG_MII=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de