From: "cron2 (Code Review)" Date: Sun, 19 Apr 2026 14:09:07 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net, antonio@...2726... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="nLVCKFVNQZQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Inlined credentials: read missing password from management interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair , plaisthos Cc: openvpn-devel --nLVCKFVNQZQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1599?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Inlined credentials: read missing password from management = interface ...................................................................... Inlined credentials: read missing password from management interface When commit 39619b7fab added support for inlining username only, fallback for password was from console. This is not ideal when graphical UI is in use as there is no console. Instead, query the management interface when possible. This patch just extends a similar fix when username is read from a file and password is missing. As before, any username read from file or inlined is not peserved as we currently have no way of locking the username in the management interface prompt. Change-Id: Ieeb2f980330d485739dbf3d722f107c1dbf704fc Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1599 Message-Id: <20260414055900.17132-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 608.html Signed-off-by: Gert Doering --- M src/openvpn/misc.c 1 file changed, 17 insertions(+), 19 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/99/1599/2 diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index c00a3ce..979293f 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -305,24 +305,6 @@ { strncpy(up->password, password_buf, USER_PASS_LEN); } - /* The auth-file does not have the password: get both user= name - * and password from the management interface if possible. - * Otherwise set to read password from console. - */ -#if defined(ENABLE_MANAGEMENT) - else if (management && (flags & GET_USER_PASS_MANAGEMENT) - && management_query_user_pass_enabled(management)) - { - msg(D_LOW, - "No password found in %s authfile '%s'. Querying t= he management interface", - prefix, auth_file); - if (!auth_user_pass_mgmt(up, prefix, flags, auth_chall= enge)) - { - fclose(fp); - return false; - } - } -#endif else { password_from_stdin =3D 1; @@ -348,7 +330,23 @@ if (username_from_stdin || password_from_stdin || response_from_st= din) { #ifdef ENABLE_MANAGEMENT - if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHALLENGE= ) && response_from_stdin) + /* If management-query-passwords is true, we could be here bec= ause + * of no password present in auth-file or inline. In that case + * query via the management interface instead of stdin/console. + */ + if (management && (flags & GET_USER_PASS_MANAGEMENT) + && management_query_user_pass_enabled(management) + && !(flags & GET_USER_PASS_USERNAME_ONLY)) + { + msg(D_LOW, + "No '%s' password found in authfile or inline. Queryin= g the management interface", + prefix); + if (!auth_user_pass_mgmt(up, prefix, flags, auth_challenge= )) + { + return false; + } + } + else if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHAL= LENGE) && response_from_stdin) { struct auth_challenge_info *ac =3D parse_auth_challenge(au= th_challenge, &gc); if (ac) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1599?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ieeb2f980330d485739dbf3d722f107c1dbf704fc Gerrit-Change-Number: 1599 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --nLVCKFVNQZQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by selvanair.<= /p>

Vi= ew Change

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

Inlined credentials: read missi=
ng password from management interface

When commit 39619b7fab added s= upport for inlining username only,
fallback for password was from consol= e. This is not ideal when
graphical UI is in use as there is no console.= Instead, query the
management interface when possible.

This patc= h just extends a similar fix when username is read from
a file and passw= ord is missing. As before, any username read
from file or inlined is not= peserved as we currently have no way
of locking the username in the man= agement interface prompt.

Change-Id: Ieeb2f980330d485739dbf3d722f107= c1dbf704fc
Signed-off-by: Selva Nair <selva.nair@...277...>
Ack= ed-by: Arne Schwabe <arne-openvpn@...1227...>
Gerrit URL: https://= gerrit.openvpn.net/c/openvpn/+/1599
Message-Id: <20260414055900.17132= -1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...465...= ists.sourceforge.net/msg36608.html
Signed-off-by: Gert Doering <gert@= ...1296...>
---
M src/openvpn/misc.c
1 file changed, 17 inserti= ons(+), 19 deletions(-)

git pull ssh://gerrit.op=
envpn.net:29418/openvpn refs/changes/99/1599/2
diff --git a/src/ope=
nvpn/misc.c b/src/openvpn/misc.c
index c00a3ce..979293f 100= 644
--- a/src/openvpn/misc.c
+++ b/src/open= vpn/misc.c
@@ -305,24 +305,6 @@
= {
strncpy(up->password, passw= ord_buf, USER_PASS_LEN);
}
- /* The auth-file does= not have the password: get both username
- * and password from the management int= erface if possible.
- = * Otherwise set to read password from console.
- */
-#if defined(ENABLE_MANAGEMENT)=
- else if (man= agement && (flags & GET_USER_PASS_MANAGEMENT)
- && man= agement_query_user_pass_enabled(management))
- {
- msg(D_LOW,
- "No password found= in %s authfile '%s'. Querying the management interface",
- pr= efix, auth_file);
- = if (!auth_user_pass_mgmt(up, prefix, flags, auth_challenge)= )
- = {
- = fclose(fp);
- = return false;
- }
- }
-#endif
else
= {
password_from_stdin =3D 1;<= /span>
@@ -348,7 +330,23 @@
if (username_= from_stdin || password_from_stdin || response_from_stdin)
= {
#ifdef ENABLE_MANAGEMENT
- if (auth_challenge && (= flags & GET_USER_PASS_DYNAMIC_CHALLENGE) && response_from_stdin= )
+ /* If = management-query-passwords is true, we could be here because
+ * of no password pres= ent in auth-file or inline. In that case

+ * query via the management interface inst= ead of stdin/console.
+ */
+ = if (management && (flags & GET_USER_PASS_MANAGEMENT)<= /span>
+ &= ;& management_query_user_pass_enabled(management)
+ && !(flags & = GET_USER_PASS_USERNAME_ONLY))
+ {
+ msg(D_LOW,
+ "No '%s' password found in auth= file or inline. Querying the management interface",
+ prefix);+ if (!auth_use= r_pass_mgmt(up, prefix, flags, auth_challenge))
+ {
+ return false;
+ }

+ }
+ else if (auth_challenge &= & (flags & GET_USER_PASS_DYNAMIC_CHALLENGE) && response_fro= m_stdin)
{
st= ruct auth_challenge_info *ac =3D parse_auth_challenge(auth_challenge, &= gc);
if (ac)

To view, visit change 1599. To unsubscribe, or for help writing mail fil= ters, visit sett= ings.

<= link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/1599?us= p=3Demail"/>
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb2f980330d485739dbf3d722f= 107c1dbf704fc
Gerrit-Change-Number: 1599
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --nLVCKFVNQZQ=--