From: "plaisthos (Code Review)" Date: Tue, 2 Jan 2024 12:41:22 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rEIq3r9KOTQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --rEIq3r9KOTQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/479?usp=3Demail ) Change subject: forked-test-driver: Show test output always ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: The patch does not do what it promises to do. I cherry-picked this patch an= d the other forked-test-driver patch on my branch and in github actions sti= ll only reports that a unit test has failed without any indication of why: PASS: argv_testdriver FAIL: buffer_testdriver PASS: crypto_testdriver https://github.com/schwabe/openvpn/actions/runs/7385546211/job/20090514521 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 Gerrit-Change-Number: 479 Gerrit-PatchSet: 5 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 02 Jan 2024 12:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --rEIq3r9KOTQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

Patch set 5:Code-Review -1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #5:

      The patch does not do what it promises to do. = I cherry-picked this patch and the other forked-test-driver patch on my bra= nch and in github actions still only reports that a unit test has failed wi= thout any indication of why:

      PASS: argv_testdriver
      FAIL: buffer_testdriver
      PASS: c= rypto_testdriver

      https://github.com/schwabe/openvpn/actions/runs/7385546211/job/20090514= 521

To view, visit change 479. To unsubscribe, or for = help writing mail filters, visit settings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I11e0091482d9acee89ca018374c= b8d96d22f8514
Gerrit-Change-Number: 479
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 02 Jan 2024 12:41:22= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--rEIq3r9KOTQ=--