Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A664C433F5 for ; Fri, 4 Mar 2022 07:29:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E339683CA3; Fri, 4 Mar 2022 08:29:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1646378961; bh=Jh7wWoX6oLEwBUdlFycKZHRUOJjlm11yfEc6AXhhV6U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FfFMXU5/dfzyS+v5HntrgYtkHmFQF2S97Hxa2LPchmt35ee70wFnaAX1D2DTKVV5W dm32jTGfuNeyitn8ExTdrHWPEH3/WjkD6VwiMMQ26ylTJsIZCvkC22OkekH4LGM8Vj pufc4gXB3bcRHC1meHF8bR+T6sfiIfDzsYF6wxHF3KFzt2FQLZ+LihL7z9et8L6tFO Lb9wmRpxRMK0ScWtgb3WfQmZ8ED9kqnERKUMg7NfPfbQMBqeNrCvpT0h3qHtV0R3iu IhSJmOkC252kFhjZQuQSs9trFI3UNIJtFYVudMosP4jO9s9axoHaZyTERpN8YM8gkz JobtzxWMnzqzA== Received: by phobos.denx.de (Postfix, from userid 109) id 0842C83CA8; Fri, 4 Mar 2022 08:29:19 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BD1083BC1 for ; Fri, 4 Mar 2022 08:29:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4K8zxl5Pbjz9snq; Fri, 4 Mar 2022 08:29:15 +0100 (CET) Message-ID: Date: Fri, 4 Mar 2022 08:29:07 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] ARM: mvebu: x530: clearfog: Add ODT configuration Content-Language: en-US To: Chris Packham , u-boot@lists.denx.de Cc: Baruch Siach , Chris Packham , Kostya Porotchkin , =?UTF-8?Q?Marek_Beh=c3=ban?= , Moti Buskila , Nadav Haklai , Tom Rini References: <20220301005323.1786382-1-judge.packham@gmail.com> From: Stefan Roese In-Reply-To: <20220301005323.1786382-1-judge.packham@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/1/22 01:53, Chris Packham wrote: > Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT > configuration") added the odt_config member to struct > mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This > means that any boards that configured either of clk_enable or ck_delay > needed to have their board topology updated. This affects the x530 and > clearfog boards. Other A38x boards don't touch any of the trailing > members of mv_ddr_topology_map so don't need updating. > > Fixes: 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") > Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan > --- > > board/alliedtelesis/x530/x530.c | 1 + > board/solidrun/clearfog/clearfog.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c > index 8b31045a0743..c0ec2afa3011 100644 > --- a/board/alliedtelesis/x530/x530.c > +++ b/board/alliedtelesis/x530/x530.c > @@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0, /* Clock enable mask */ > 160 /* Clock delay */ > }; > diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c > index c920cf8d6b50..03adb591d826 100644 > --- a/board/solidrun/clearfog/clearfog.c > +++ b/board/solidrun/clearfog/clearfog.c > @@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = { > {0}, /* timing parameters */ > { {0} }, /* electrical configuration */ > {0,}, /* electrical parameters */ > + 0, /* ODT configuration */ > 0x3, /* clock enable mask */ > }; > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de