Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m2veJ-0006TB-GV for mharc-grub-devel@gnu.org; Mon, 12 Jul 2021 09:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2veG-0006R0-1j for grub-devel@gnu.org; Mon, 12 Jul 2021 09:07:01 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2veD-0007Ep-Js for grub-devel@gnu.org; Mon, 12 Jul 2021 09:06:59 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16CD5eDE134816; Mon, 12 Jul 2021 09:06:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=DnqjRcAmJbICN1/qW/NZJPzzmyA0kR+bqf04P3mPOwo=; b=rkqTmae2BbbrPr1C0PhN7P5HysghJh+ErKyGR76GfbdblBARCf7UIg9L6M8r7KdLFZ8d qWpgve1Cfmansl4/MbwNb4zPd1dgSstdhqULswkEes77WW7CflK/yY7sBs++p1EzqAAu 31NZ1WgTO3nLJVL/iauxvR+mS8ld4pC3AGAQVSxeAPBBZFq5kgFxrikoO37LhSI8hXY5 il5TYLPFU7VAXrVhYdFGw8x3HYFIFOhARdhf+Uqt0Y44JbQOJM6CcAKmNT9jkhgQYdlM Mu2FdWqgYvnERvf1mnEi/fMpp1JkeG+l7IXpUZBxyHKb6tOPofROhOA7hag1Btcza/D2 kA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39qrmt1ss4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jul 2021 09:06:55 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16CD6Zhn138264; Mon, 12 Jul 2021 09:06:54 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 39qrmt1srt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jul 2021 09:06:54 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16CD35Cp027881; Mon, 12 Jul 2021 13:06:53 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01dal.us.ibm.com with ESMTP id 39q36ap9tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Jul 2021 13:06:42 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16CD5ilP10814086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Jul 2021 13:05:44 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2AB8AE066; Mon, 12 Jul 2021 13:05:44 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 99B15AE060; Mon, 12 Jul 2021 13:05:44 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 12 Jul 2021 13:05:44 +0000 (GMT) Subject: Re: [PATCH v2 14/22] libtasn1: compile into asn1 module To: The development of GNU GRUB , Daniel Axtens Cc: rashmica.g@gmail.com, alastair@d-silva.org, nayna@linux.ibm.com References: <20210630084031.2663622-1-dja@axtens.net> <20210630084031.2663622-15-dja@axtens.net> From: Stefan Berger Message-ID: Date: Mon, 12 Jul 2021 09:05:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210630084031.2663622-15-dja@axtens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4uX_TnsL-Tw_elhlnBMKzdITbTbbuIX2 X-Proofpoint-ORIG-GUID: F8pcpyn1MhjwjhwLVheyt60ijR9-oMw9 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-12_08:2021-07-12, 2021-07-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107120103 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.479, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 13:07:01 -0000 On 6/30/21 4:40 AM, Daniel Axtens wrote: > Create a wrapper file that specifies the module license. > Set up the makefile so it is built. > > Signed-off-by: Daniel Axtens Reviewed-by: Stefan Berger > --- > grub-core/Makefile.core.def | 15 +++++++++++++++ > grub-core/lib/libtasn1_wrap/wrap.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 41 insertions(+) > create mode 100644 grub-core/lib/libtasn1_wrap/wrap.c > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 915287d44c13..6fbae150c687 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makefile.core.def > @@ -2535,3 +2535,18 @@ module = { > common = commands/i386/wrmsr.c; > enable = x86; > }; > + > +module = { > + name = asn1; > + common = lib/libtasn1/lib/decoding.c; > + common = lib/libtasn1/lib/coding.c; > + common = lib/libtasn1/lib/element.c; > + common = lib/libtasn1/lib/structure.c; > + common = lib/libtasn1/lib/parser_aux.c; > + common = lib/libtasn1/lib/gstr.c; > + common = lib/libtasn1/lib/errors.c; > + common = lib/libtasn1_wrap/wrap.c; > + cflags = '$(CFLAGS_POSIX) $(CFLAGS_GNULIB)'; > + // -Wno-type-limits comes from libtasn1's configure.ac > + cppflags = '$(CPPFLAGS_POSIX) $(CPPFLAGS_GNULIB) -I$(srcdir)/lib/libtasn1/lib -Wno-type-limits'; > +}; > diff --git a/grub-core/lib/libtasn1_wrap/wrap.c b/grub-core/lib/libtasn1_wrap/wrap.c > new file mode 100644 > index 000000000000..622ba942e33f > --- /dev/null > +++ b/grub-core/lib/libtasn1_wrap/wrap.c > @@ -0,0 +1,26 @@ > +/* > + * GRUB -- GRand Unified Bootloader > + * Copyright (C) 2020 IBM Corporation > + * > + * GRUB is free software: you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation, either version 3 of the License, or > + * (at your option) any later version. > + * > + * GRUB is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with GRUB. If not, see . > + */ > + > +#include > + > +/* > + * libtasn1 is provided under LGPL2.1+, which is compatible > + * with GPL3+. As Grub as a whole is under GPL3+, this module > + * is therefore under GPL3+ also. > + */ > +GRUB_MOD_LICENSE ("GPLv3+");