Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2DDC388F7 for ; Fri, 13 Nov 2020 17:09:01 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 989C021D1A for ; Fri, 13 Nov 2020 17:09:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="UNxy3TS1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 989C021D1A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.26796.55282 (Exim 4.92) (envelope-from ) id 1kdcZ0-0001VW-QI; Fri, 13 Nov 2020 17:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 26796.55282; Fri, 13 Nov 2020 17:08:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdcZ0-0001VP-NM; Fri, 13 Nov 2020 17:08:42 +0000 Received: by outflank-mailman (input) for mailman id 26796; Fri, 13 Nov 2020 17:08:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdcYz-0001VK-2y for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 17:08:41 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d62c5ed-c900-49b3-a869-d62e6cc43343; Fri, 13 Nov 2020 17:08:39 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdcYz-0001VK-2y for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 17:08:41 +0000 X-Inumbo-ID: 9d62c5ed-c900-49b3-a869-d62e6cc43343 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d62c5ed-c900-49b3-a869-d62e6cc43343; Fri, 13 Nov 2020 17:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1605287319; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=nEhD71WdBPiSRNX2ZLtn5P4iTtAdnrsZyLi7zEsS+A4=; b=UNxy3TS1/UxrRuKKtgXKcwrzIShUM2F/wBD3co0r6qJLuSVxFXkahln7 AsEtVln2cfx/W3RU+dtA958wtM7Ppx+tvWXMQDtmMnnXTuZu0FPu2ZZVi T/+HgppWPyhs1Z40pYmxYT8f2jrDfOnzXqu7UM6aaFKF9QcnSVEYjPc8t Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: XsaHqAbAQP7zSTmVpevWowNZDlhPkxRdQ6hjjLhwWEZU79VInI4rsVuVFU5PBLMCEvsB82ME+q nY9qbIjRNk40TLSAtuKvnmSmgKoQexwDsYw9gIuCC1X2NXjQuz4ZNp1slakFlhBALLzMJpBWJY xXFwj+zI8tCMwFbyWeadmd+fzgGMMokKSOHBhfcjdQPQgK54fsEKuo7T3xrw7skiAq4UaKcODi p2vI5g43vJbIOjDg/+kp/+aWTaMwY/yOz7P2gV5Ijr2BUi5t4Mx1tkpvfn8IuN4HIT7Io2DEzL pXA= X-SBRS: None X-MesageID: 31482236 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,476,1596513600"; d="scan'208";a="31482236" Subject: Re: [XEN PATCH] tools/xenstore: Log xenstored build ID on startup To: Bjoern Doebel , CC: Julien Grall , Eslam Elnikety , Ian Jackson , Wei Liu References: <20201113141823.58712-1-doebel@amazon.de> From: Andrew Cooper Message-ID: Date: Fri, 13 Nov 2020 17:08:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To FTLPEX02CL04.citrite.net (10.13.108.177) On 13/11/2020 16:55, Bjoern Doebel wrote: > > On 13.11.20 15:30, Andrew Cooper wrote: >> On 13/11/2020 14:18, Bjoern Doebel wrote: >>> Right now we do not have a mechanism to determine the version of the >>> currently running xenstored at runtime. As xenstored runs throughout >>> the >>> lifetime of a Xen host, this may lead to problems when newer user space >>> builds are staged. Then, the running xenstored will no longer match the >>> version of the installed xenstored. >>> >>> To allow users to always identify the running version of xenstored, add >>> a linker-generated unique build ID to every xenstored build. Add >>> functionality to log this build ID into a file upon service startup. >>> >>> Signed-off-by: Bjoern Doebel >>> Reviewed-by: Martin Mazein >>> Reviewed-by: Paul Durrant >> I understand the problem you're trying to solve, but why is this >> anything more than just enabling build-id's by default across tools/ ? >> >> There are already standard ways of interacting with the build id of >> running executables on the system.  I'd strongly discourage doing >> anything custom in xenstored specifically. > May I ask what tooling you would use to interact with a running > process' buildid? Amongst other things, yes.  Although as Juergen points out, we want something which works with stub domains as well, and "normal userspace tools" won't cut it there. I still think a first patch in this series should be to turn build-id's on by default if supported by the toolchain, generally. ~Andrew