From: "Souza, Jose" Subject: Re: [PATCH v3 02/10] drm/i915/psr: Always wait for idle state when disabling PSR Date: Fri, 26 Oct 2018 17:10:37 +0000 Message-ID: References: <20181026011737.23684-1-jose.souza@intel.com> <20181026011737.23684-2-jose.souza@intel.com> <20181026164517.GD2232@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 982D86E4E3 for ; Fri, 26 Oct 2018 17:10:40 +0000 (UTC) In-Reply-To: <20181026164517.GD2232@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "intel-gfx@lists.freedesktop.org" , "Pandiyan, Dhinakaran" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTI2IGF0IDA5OjQ1IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6DQo+ IE9uIFRodSwgT2N0IDI1LCAyMDE4IGF0IDA2OjE3OjI5UE0gLTA3MDAsIEpvc8OpIFJvYmVydG8g ZGUgU291emENCj4gd3JvdGU6DQo+ID4gSXQgc2hvdWxkIGFsd2F5cyB3YWl0IGZvciBpZGxlIHN0 YXRlIHdoZW4gZGlzYWJsaW5nIFBTUiBiZWNhdXNlIFBTUg0KPiA+IGNvdWxkIGJlIGluYWN0aXZl IGR1ZSBhIGNhbGwgdG8gaW50ZWxfcHNyX2V4aXQoKSBhbmQgd2hpbGUgUFNSIGlzDQo+ID4gc3Rp bGwgYmVpbmcgZGlzYWJsZWQgYXN5bmNocm9ub3VzbHkgdXNlcnNwYWNlIGNvdWxkIGNoYW5nZSB0 aGUNCj4gPiBtb2Rlc2V0IGNhdXNpbmcgYSBjYWxsIHRvIHBzcl9kaXNhYmxlKCkgdGhhdCB3aWxs IG5vdCB3YWl0IGZvciBQU1INCj4gPiBpZGxlIGFuZCB0aGVuIFBTUiB3aWxsIGJlIGVuYWJsZWQg YWdhaW4gd2hpbGUgUFNSIGlzIHN0aWxsIG5vdA0KPiA+IGlkbGUuDQo+ID4gDQo+ID4gdjI6IHJl YmFzZWQgb24gdG9wIG9mIHRoZSBwYXRjaCByZXVzaW5nIHBzcl9leGl0KCkNCj4gPiANCj4gPiBD YzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPg0KPiA+IENjOiBEaGluYWth cmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4NCj4gPiBSZXZpZXdl ZC1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+ DQo+ID4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBp bnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5j IHwgNDEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0NCj4gPiAtLS0tLS0NCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYw0KPiA+IGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMNCj4gPiBpbmRleCBmNjk4YjNmNDVjNmQuLjRjMjI2 Yjc4YzNmYyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3Iu Yw0KPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jDQo+ID4gQEAgLTY2 MSw4ICs2NjEsMTIgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4aXQoc3RydWN0DQo+ID4gZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpDQo+ID4gIHsNCj4gPiAgCXUzMiB2YWw7DQo+ID4gIA0K PiA+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLmFjdGl2ZSkNCj4gPiArCWlmICghZGV2X3ByaXYtPnBz ci5hY3RpdmUpIHsNCj4gPiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQ0KPiANCj4g VGhpcyBzaG91bGQgYmUgUFNSMiBjaGVjayBpbnN0ZWFkIG9mIHBsYXRmb3JtIG5vPyENCg0KSSBk aWQgbm90IGNoYW5nZWQgdGhpcyBiZWNhdXNlIHRoaXMgY29kZSB3YXMganVzdCBtb3ZlZCBidXQg eWVzIHdlDQpzaG91bGQgY2hlY2sgaWYgcHNyMiBpcyBlbmFibGVkLg0KDQo+IA0KPiA+ICsJCQlX QVJOX09OKEk5MTVfUkVBRChFRFBfUFNSMl9DVEwpICYNCj4gPiBFRFBfUFNSMl9FTkFCTEUpOw0K PiA+ICsJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmIEVEUF9QU1JfRU5BQkxFKTsN Cj4gPiAgCQlyZXR1cm47DQo+ID4gKwl9DQo+ID4gIA0KPiA+ICAJaWYgKGRldl9wcml2LT5wc3Iu cHNyMl9lbmFibGVkKSB7DQo+ID4gIAkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCk7DQo+ ID4gQEAgLTY4MCwzMiArNjg0LDIzIEBAIHN0YXRpYyB2b2lkDQo+ID4gIGludGVsX3Bzcl9kaXNh YmxlX3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQ0KPiA+ICB7DQo+ID4gIAlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGludGVsX2RwKTsNCj4g PiArCWk5MTVfcmVnX3QgcHNyX3N0YXR1czsNCj4gPiArCXUzMiBwc3Jfc3RhdHVzX21hc2s7DQo+ ID4gIA0KPiA+IC0JaWYgKGRldl9wcml2LT5wc3IuYWN0aXZlKSB7DQo+ID4gLQkJaTkxNV9yZWdf dCBwc3Jfc3RhdHVzOw0KPiA+IC0JCXUzMiBwc3Jfc3RhdHVzX21hc2s7DQo+ID4gLQ0KPiA+IC0J CWludGVsX3Bzcl9leGl0KGRldl9wcml2KTsNCj4gPiArCWludGVsX3Bzcl9leGl0KGRldl9wcml2 KTsNCj4gPiAgDQo+ID4gLQkJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7DQo+ID4g LQkJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFUVVM7DQo+ID4gLQkJCXBzcl9zdGF0dXNfbWFz ayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOw0KPiA+IC0JCX0gZWxzZSB7DQo+ID4gLQkJ CXBzcl9zdGF0dXMgPSBFRFBfUFNSX1NUQVRVUzsNCj4gPiAtCQkJcHNyX3N0YXR1c19tYXNrID0g RURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsNCj4gPiAtCQl9DQo+ID4gLQ0KPiA+IC0JCS8qIFdh aXQgdGlsbCBQU1IgaXMgaWRsZSAqLw0KPiA+IC0JCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3Rl cihkZXZfcHJpdiwNCj4gPiAtCQkJCQkgICAgcHNyX3N0YXR1cywNCj4gPiBwc3Jfc3RhdHVzX21h c2ssIDAsDQo+ID4gLQkJCQkJICAgIDIwMDApKQ0KPiA+IC0JCQlEUk1fRVJST1IoIlRpbWVkIG91 dCB3YWl0aW5nIGZvciBQU1IgSWRsZQ0KPiA+IFN0YXRlXG4iKTsNCj4gPiArCWlmIChkZXZfcHJp di0+cHNyLnBzcjJfZW5hYmxlZCkgew0KPiA+ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNSMl9TVEFU VVM7DQo+ID4gKwkJcHNyX3N0YXR1c19tYXNrID0gRURQX1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7 DQo+ID4gIAl9IGVsc2Ugew0KPiA+IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkN Cj4gPiAtCQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmDQo+ID4gRURQX1BTUjJf RU5BQkxFKTsNCj4gPiAtCQllbHNlDQo+ID4gLQkJCVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1Jf Q1RMKSAmDQo+ID4gRURQX1BTUl9FTkFCTEUpOw0KPiA+ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNS X1NUQVRVUzsNCj4gPiArCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9N QVNLOw0KPiA+ICAJfQ0KPiA+ICsNCj4gPiArCS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLw0K PiA+ICsJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBwc3Jfc3RhdHVzLA0K PiA+IHBzcl9zdGF0dXNfbWFzaywgMCwNCj4gPiArCQkJCSAgICAyMDAwKSkNCj4gPiArCQlEUk1f RVJST1IoIlRpbWVkIG91dCB3YWl0aW5nIFBTUiBpZGxlIHN0YXRlXG4iKTsNCj4gPiAgfQ0KPiA+ ICANCj4gPiAgc3RhdGljIHZvaWQgaW50ZWxfcHNyX2Rpc2FibGVfbG9ja2VkKHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHApDQo+ID4gLS0gDQo+ID4gMi4xOS4xDQo+ID4gDQo+ID4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0DQo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPiA+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4DQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK