Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDDD3C433F5 for ; Thu, 26 May 2022 14:11:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0777C8432D; Thu, 26 May 2022 16:11:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="hN1mBKJQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 74D9284348; Thu, 26 May 2022 16:11:08 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 58F308432D for ; Thu, 26 May 2022 16:11:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 471192223B; Thu, 26 May 2022 16:11:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1653574263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e6WHabq0cTVXINVlM47Hwm4hG+bGg265daqTtkptqyw=; b=hN1mBKJQtQoCT5f4IuDagZe9s6BxjIYleAm4WjlUWlfx51mdC/3VTAj1D4lQRnwwq3VKa0 t+4JnRM3QquJanTZt9emwQ8q1bas+7hOGZFY4AlGbbp1+nka62U9RT+s8A5WbQixOCRPWb QAMTgFtpJW5NC4tM+87LyrX0FJHnuz0= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 26 May 2022 16:11:02 +0200 From: Michael Walle To: Eugen Hristev Cc: hs@denx.de, rasmus.villemoes@prevas.dk, u-boot@lists.denx.de, claudiu.beznea@microchip.com Subject: Re: [PATCH 1/3] ARM: dts: at91: replace microchip,24aa02e48 with atmel,at24c02 In-Reply-To: <20220526140456.53776-1-eugen.hristev@microchip.com> References: <20220526140456.53776-1-eugen.hristev@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Am 2022-05-26 16:04, schrieb Eugen Hristev: > microchip,24aa025e48 does not exist in the bindings of this driver. > It can be replaced with atmel,at24c02 which is a standard compatible > and the memory is compatible with this one, depending on the page size. > microchip 24aa02e48 has a page size of 8, while 24aa025e48 has a page > size of 16 bytes. Nice. Thanks for taking care! One minor nit below. > Signed-off-by: Eugen Hristev Reviewed-by: Michael Walle > --- > arch/arm/dts/at91-sama5d2_icp.dts | 6 +++--- > arch/arm/dts/at91-sama7g5ek.dts | 4 ++-- > arch/arm/dts/sama5d27_som1.dtsi | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/dts/at91-sama5d2_icp.dts > b/arch/arm/dts/at91-sama5d2_icp.dts > index 44522197ff..0b0db1b2be 100644 > --- a/arch/arm/dts/at91-sama5d2_icp.dts > +++ b/arch/arm/dts/at91-sama5d2_icp.dts > @@ -68,19 +68,19 @@ > status = "okay"; > > eeprom@50 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x50>; > pagesize = <16>; > }; > > eeprom@52 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x52>; > pagesize = <16>; > }; > > eeprom@53 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x53>; > pagesize = <16>; > }; > diff --git a/arch/arm/dts/at91-sama7g5ek.dts > b/arch/arm/dts/at91-sama7g5ek.dts > index 086ee45005..eaba0de3f7 100644 > --- a/arch/arm/dts/at91-sama7g5ek.dts > +++ b/arch/arm/dts/at91-sama7g5ek.dts > @@ -405,13 +405,13 @@ > status = "okay"; > > eeprom@52 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x52>; > pagesize = <16>; > }; > > eeprom@53 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x53>; > pagesize = <16>; > }; > diff --git a/arch/arm/dts/sama5d27_som1.dtsi > b/arch/arm/dts/sama5d27_som1.dtsi > index ea7540bcfc..db4fefadcd 100644 > --- a/arch/arm/dts/sama5d27_som1.dtsi > +++ b/arch/arm/dts/sama5d27_som1.dtsi > @@ -92,7 +92,7 @@ > status = "okay"; > > i2c_eeprom: i2c_eeprom@50 { Nit: that one should actually be just "eeprom@50". -michael > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa02e48 */ > reg = <0x50>; > }; > };