Return-Path: Received: from mail-it1-f196.google.com ([209.85.166.196]:34673 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726816AbfABUcz (ORCPT ); Wed, 2 Jan 2019 15:32:55 -0500 Received: by mail-it1-f196.google.com with SMTP id x124so39598573itd.1 for ; Wed, 02 Jan 2019 12:32:55 -0800 (PST) Subject: Re: [PATCH 16/22] aio: add support for submission/completion rings From: Jens Axboe To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-block@vger.kernel.org, hch@lst.de, viro@zeniv.linux.org.uk References: <20181221192236.12866-1-axboe@kernel.dk> <20181221192236.12866-17-axboe@kernel.dk> <20181227134737.GA24160@infradead.org> <91c8d717-37ab-9696-ff41-700f339a1960@kernel.dk> Message-ID: Date: Wed, 2 Jan 2019 13:32:52 -0700 MIME-Version: 1.0 In-Reply-To: <91c8d717-37ab-9696-ff41-700f339a1960@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 1/2/19 9:28 AM, Jens Axboe wrote: >> We'd much rather allocate a file descriptor using anon_inode_getfd >> and operate on that. That also means we can just close that fd >> instead of needing the magic io_destroy, and save all the checks for >> which kind of FD we operate on. > > I'm not against doing something else for setup, but we still need some > way of passing in information about what we want. Things like ring > sizing. The actual rings we could mmap from known offsets if we went the > anon route. OK, so we could go the anon_inode_getfd() route and make it ioctls. Move the gup stuff to mmap off that inode. I'll try and play with it a bit. -- Jens Axboe