From: "mrbff (Code Review)"
Date: Wed, 23 Jul 2025 17:12:03 +0000
In-Reply-To:
References:
Reply-To: marco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277..., gert@...1296...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="1kPKWGS6BGo="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added
update_option() function.
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: stipa , plaisthos , flichtenheld , openvpn-devel
--1kPKWGS6BGo=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/810?usp=3Demail )
Change subject: PUSH_UPDATE: Added update_option() function.
......................................................................
Patch Set 22:
(3 comments)
File src/openvpn/options.c:
http://gerrit.openvpn.net/c/openvpn/+/810/comment/edf64e35_8ed4afac :
PS21, Line 5897: }
> I find this duplication of syntax checking, mmmh, sub-optimal. [=E2=80=A6]
idk, i thought it were nice to make some checks before deleting the options=
. :)
http://gerrit.openvpn.net/c/openvpn/+/810/comment/6c0edd1d_f8769a03 :
PS21, Line 5927: }
> same here
Done
http://gerrit.openvpn.net/c/openvpn/+/810/comment/af06b38c_73d23b39 :
PS21, Line 6009:
> same here... lots of code that needs to be in sync with the add_option() =
checks...
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9b3577984ecdc2
Gerrit-Change-Number: 810
Gerrit-PatchSet: 22
Gerrit-Owner: mrbff
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--1kPKWGS6BGo=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos, s=
tipa.
View C=
hange
3 comments:
idk, i thought it were nice to make some checks before deletin=
g the options. :)
Patch Set #21, Line 5927: }
s=
ame here
Done
Patch Set #21, Line 6009:
same here... lots =
of code that needs to be in sync with the add_option() checks...Done
=
li>
To view, visit change 810. To unsubscribe, or for help writ=
ing mail filters, visit sett=
ings.
<=
link itemprop=3D"url" href=3D"http://gerrit.openvpn.net/c/openvpn/+/810?usp=
=3Demail"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9=
b3577984ecdc2
Gerrit-Change-Number: 810
Gerrit-PatchSet: 22
Gerrit-Owner: mrbff <marco@...2726...> <=
/div>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...=
>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:12:03=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--1kPKWGS6BGo=--