From: Dmitry Osipenko Subject: Re: [PATCH v3 03/10] partitions: Introduce NVIDIA Tegra Partition Table Date: Wed, 25 Mar 2020 03:27:13 +0300 Message-ID: References: <20200323163431.7678-1-digetx@gmail.com> <20200323163431.7678-4-digetx@gmail.com> <20200323191748.GB30585@qmqm.qmqm.pl> <67140755-c829-5c58-3fbf-efd496e225df@gmail.com> <20200323213520.GA16587@qmqm.qmqm.pl> <20200324205221.GA22063@qmqm.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200324205221.GA22063-cHozx32mtrEEUmgCuDUIdw@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Jens Axboe , Thierry Reding , Jonathan Hunter , David Heidelberg , Peter Geis , Stephen Warren , Nicolas Chauvet , Ulf Hansson , Adrian Hunter , Billy Laws , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrey Danin , Gilles Grandou , Ryan Grachek , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 24.03.2020 23:52, Michał Mirosław пишет: > On Tue, Mar 24, 2020 at 02:22:34AM +0300, Dmitry Osipenko wrote: >> 24.03.2020 00:35, Michał Mirosław пишет: >>> On Mon, Mar 23, 2020 at 10:59:52PM +0300, Dmitry Osipenko wrote: >>>> 23.03.2020 22:17, Michał Mirosław пишет: >>>>> On Mon, Mar 23, 2020 at 07:34:24PM +0300, Dmitry Osipenko wrote: >>>>>> All NVIDIA Tegra devices use a special partition table format for the >>>>>> internal storage partitioning. Most of Tegra devices have GPT partition >>>>>> in addition to TegraPT, but some older Android consumer-grade devices do >>>>>> not or GPT is placed in a wrong sector, and thus, the TegraPT is needed >>>>>> in order to support these devices properly in the upstream kernel. This >>>>>> patch adds support for NVIDIA Tegra Partition Table format that is used >>>>>> at least by all NVIDIA Tegra20 and Tegra30 devices. >>>>>> >>>>>> Signed-off-by: Dmitry Osipenko >>>>>> --- >>>>>> arch/arm/mach-tegra/tegra.c | 54 ++++ >>>>> [...] >>>>> >>>>> Please split off this part and make the information available to >>>>> userspace (pt_addr + pt_size) if found. This would make it easier >>>>> to support use the partition table later in initrd instead. >>>> >>>> Please clarify what do you mean by "use the partition table later in >>>> initrd instead". >>> >>> Configure device-mapper to span eMMC boot+data partitions and then ask >>> (modified) kpartx to partition the resulting device. All before rootfs >>> is mounted and switched to in initrd. >> >> The whole point of this series is to make partition handling generic in >> the kernel, avoiding the need to customize anything. > > Yes, but at least for diagnostic purposes, it would be nice to have the > values from BCT exposed somewhere in /sys. It could be useful indeed, but for now I'm not sure that it should be a part of this patchset. I'll keep it mind, thank you for the suggestion.