From: Vincenzo Frascino Subject: Re: [PATCH v2 5/8] lib: vdso: Remove checks on return value for 32 bit vDSO Date: Fri, 30 Aug 2019 15:16:47 +0100 Message-ID: References: <20190830135902.20861-1-vincenzo.frascino@arm.com> <20190830135902.20861-6-vincenzo.frascino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190830135902.20861-6-vincenzo.frascino@arm.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: catalin.marinas@arm.com, 0x7f454c46@gmail.com, salyzyn@android.com, paul.burton@mips.com, luto@kernel.org, tglx@linutronix.de, will@kernel.org List-Id: linux-arch.vger.kernel.org On 30/08/2019 14:58, Vincenzo Frascino wrote: > Since all the architectures that support the generic vDSO library have > been converted to support the 32 bit fallbacks it is not required > anymore to check the return value of __cvdso_clock_get*time32_common() > before updating the old_timespec fields. > > Remove the related checks from the generic vdso library. > > Cc: Thomas Gleixner > CC: Andy Lutomirski Forgot to add to this patch: Suggested-by: Andy Lutomirski > References: c60a32ea4f45 ("lib/vdso/32: Provide legacy syscall fallbacks") > Signed-off-by: Vincenzo Frascino > --- > lib/vdso/gettimeofday.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c > index 2c4b311c226d..d5bc16748f81 100644 > --- a/lib/vdso/gettimeofday.c > +++ b/lib/vdso/gettimeofday.c > @@ -129,10 +129,10 @@ __cvdso_clock_gettime32(clockid_t clock, struct old_timespec32 *res) > if (unlikely(ret)) > return clock_gettime32_fallback(clock, res); > > - if (likely(!ret)) { > - res->tv_sec = ts.tv_sec; > - res->tv_nsec = ts.tv_nsec; > - } > + /* For ret == 0 */ > + res->tv_sec = ts.tv_sec; > + res->tv_nsec = ts.tv_nsec; > + > return ret; > } > #endif /* BUILD_VDSO32 */ > @@ -238,10 +238,10 @@ __cvdso_clock_getres_time32(clockid_t clock, struct old_timespec32 *res) > if (unlikely(ret)) > return clock_getres32_fallback(clock, res); > > - if (likely(!ret)) { > - res->tv_sec = ts.tv_sec; > - res->tv_nsec = ts.tv_nsec; > - } > + /* For ret == 0 */ > + res->tv_sec = ts.tv_sec; > + res->tv_nsec = ts.tv_nsec; > + > return ret; > } > #endif /* BUILD_VDSO32 */ > -- Regards, Vincenzo