From: "flichtenheld (Code Review)"
Date: Wed, 9 Jul 2025 14:42:10 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="Sca7hymJ5vc="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Do not compile mbed
key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--Sca7hymJ5vc=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1081?usp=3Demail )
Change subject: Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATE=
RIAL_EXPORT
......................................................................
Patch Set 1: -Code-Review
(1 comment)
Patchset:
PS1:
> Why should we include that? The fix is also for older version as we compi=
le in functions that are no [=E2=80=A6]
Okay, I will put it in #1079 and rebase that on top of your change
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Wed, 09 Jul 2025 14:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--Sca7hymJ5vc=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Patch set 1:-Code-Review
<=
p>View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">Patchset:
To view, visit change 1081. To unsubscribe, =
or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c=
5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Wed, 09 Jul 2025 14:42:10=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--Sca7hymJ5vc=--