Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B78C433E0 for ; Mon, 25 May 2020 02:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B517720787 for ; Mon, 25 May 2020 02:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388375AbgEYCVA convert rfc822-to-8bit (ORCPT ); Sun, 24 May 2020 22:21:00 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:59798 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388151AbgEYCVA (ORCPT ); Sun, 24 May 2020 22:21:00 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.69 with qID 04P2KoUwA000792, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmb06.realtek.com.tw[172.21.6.99]) by rtits2.realtek.com.tw (8.15.2/2.66/5.86) with ESMTPS id 04P2KoUwA000792 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 25 May 2020 10:20:50 +0800 Received: from RTEXMB01.realtek.com.tw (172.21.6.94) by RTEXMB06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Mon, 25 May 2020 10:20:49 +0800 Received: from RTEXMB04.realtek.com.tw (172.21.6.97) by RTEXMB01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Mon, 25 May 2020 10:20:49 +0800 Received: from RTEXMB04.realtek.com.tw ([fe80::8001:f5f5:a41e:f8d4]) by RTEXMB04.realtek.com.tw ([fe80::8001:f5f5:a41e:f8d4%3]) with mapi id 15.01.1779.005; Mon, 25 May 2020 10:20:49 +0800 From: Tony Chuang To: Kalle Valo CC: "linux-wireless@vger.kernel.org" , "kevlo@kevlo.org" Subject: RE: [PATCH] Revert "rtw88: no need to set registers for SDIO" Thread-Topic: [PATCH] Revert "rtw88: no need to set registers for SDIO" Thread-Index: AQHWLmsSvo/G/WdZGka1GdX2HzARfaiz6otjgAQuoEA= Date: Mon, 25 May 2020 02:20:49 +0000 Message-ID: References: <20200520055350.23328-1-yhchuang@realtek.com> <871rncb6xu.fsf@codeaurora.org> In-Reply-To: <871rncb6xu.fsf@codeaurora.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.68.175] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > writes: > > > From: Yan-Hsuan Chuang > > > > This reverts commit 07d0f5534935e2daf63a4e1012af13d68e089fed. > > > > For rtw88 driver, the SDIO is going to be supported, so there is > > no need to remove the SDIO related power sequence settings. And > > while the power sequence parser will pass in the mask of the HCI, > > the SDIO part will not be used to set registers accordingly. > > > > Moreover, the power sequence table is released as a whole package, > > so the next time if we are going to update, the SDIO settings will > > be overwritten. So, revert this now. > > > > Signed-off-by: Yan-Hsuan Chuang > > Oops, I was supposed to drop that patch but somehow I did apply it > anyway. Sorry about that, I'll apply this revert. > It's fine :). Thanks. Yan-Hsuan