Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B650DC48260 for ; Thu, 8 Feb 2024 10:45:40 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.678107.1055157 (Exim 4.92) (envelope-from ) id 1rY1uN-00077R-Sl; Thu, 08 Feb 2024 10:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 678107.1055157; Thu, 08 Feb 2024 10:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rY1uN-00077K-Pe; Thu, 08 Feb 2024 10:45:31 +0000 Received: by outflank-mailman (input) for mailman id 678107; Thu, 08 Feb 2024 10:45:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rY1uM-00075l-Ll for xen-devel@lists.xenproject.org; Thu, 08 Feb 2024 10:45:30 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c7b0b4e-c66f-11ee-98f5-efadbce2ee36; Thu, 08 Feb 2024 11:45:28 +0100 (CET) Received: from [192.168.1.15] (host-87-16-84-78.retail.telecomitalia.it [87.16.84.78]) by support.bugseng.com (Postfix) with ESMTPSA id EE9674EE0739; Thu, 8 Feb 2024 11:45:27 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c7b0b4e-c66f-11ee-98f5-efadbce2ee36 Message-ID: Date: Thu, 8 Feb 2024 11:45:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v2 2/3] x86/uaccess: replace __{get,put}_user_bad() with STATIC_ASSERT_UNREACHABLE() To: Jan Beulich Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org, Stefano Stabellini References: <22ee2311-1e6b-4f2e-86e4-12d20b5ba4a2@suse.com> <6451696b-0366-4069-b82b-094e63eced8d@bugseng.com> <0b0b5a50-7692-4500-baa4-68df8f1c5d7a@suse.com> <04a2c7b2-07e5-46fd-835e-42b3c6307547@bugseng.com> Content-Language: en-US, it From: Federico Serafini Organization: BUGSENG srl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/02/24 17:19, Jan Beulich wrote: > On 07.02.2024 16:58, Federico Serafini wrote: >> On 07/02/24 16:24, Jan Beulich wrote: >>> On 07.02.2024 16:08, Federico Serafini wrote: >>>> On 07/02/24 15:16, Jan Beulich wrote: >>>>> On 07.02.2024 14:51, Federico Serafini wrote: >>>>>> On 07/02/24 08:38, Jan Beulich wrote: >>>>>>> On 07.02.2024 02:08, Stefano Stabellini wrote: >>>>>>>> On Tue, 6 Feb 2024, Jan Beulich wrote: >>>>>>>>> On 26.01.2024 11:05, Federico Serafini wrote: >>>>>>>>>> @@ -208,7 +205,7 @@ do { \ >>>>>>>>>> case 8: \ >>>>>>>>>> put_unsafe_asm(x, ptr, grd, retval, "q", "", "ir", errret); \ >>>>>>>>>> break; \ >>>>>>>>>> - default: __put_user_bad(); \ >>>>>>>>>> + default: STATIC_ASSERT_UNREACHABLE(); \ >>>>>>>>>> } \ >>>>>>>>>> clac(); \ >>>>>>>>>> } while ( false ) >>>>>>>>>> @@ -227,7 +224,7 @@ do { \ >>>>>>>>>> case 2: get_unsafe_asm(x, ptr, grd, retval, "w", "=r", errret); break; \ >>>>>>>>>> case 4: get_unsafe_asm(x, ptr, grd, retval, "k", "=r", errret); break; \ >>>>>>>>>> case 8: get_unsafe_asm(x, ptr, grd, retval, "", "=r", errret); break; \ >>>>>>>>>> - default: __get_user_bad(); \ >>>>>>>>>> + default: STATIC_ASSERT_UNREACHABLE(); \ >>>>>>>>>> } \ >>>>>>>>>> clac(); \ >>>>>>>>>> } while ( false ) >>>>>>>>> >>>>>>>>> Related to my remark on patch 1 - how is one to know the macro this was >>>>>>>>> invoked from, when seeing the resulting diagnostic? >>>>>>>> >>>>>>>> I am not sure what do you mean here... we do get an error like the >>>>>>>> following (I added a STATIC_ASSERT_UNREACHABLE for case 4): >>>>>>>> >>>>>>>> ./arch/x86/include/asm/uaccess.h:262: Error: static assertion failed: unreachable >>>>>>> >>>>>>> Right - and how do I know what _user_ of the macro actually triggered >>>>>>> it? ISTR suggesting to use one or more of __FILE__ / __LINE__ / >>>>>>> __FUNCTION__ here, for that specific purpose ... >>>>>> >>>>>> To test the macro and its diagnostics, >>>>>> I modified the first "git grep" occurrence of ASSERT_UNREACHABLE() >>>>>> on the x86 code with STATIC_ASSERT_UNREACHABLE(), >>>>>> that is in file arch/x86/alternative.c, line 312, >>>>>> function _apply_alternatives(). >>>>>> >>>>>> What I got is the following build error: >>>>>> >>>>>> ... >>>>>> arch/x86/alternative.c: Assembler messages: >>>>>> arch/x86/alternative.c:312: Error: static assertion failed: unreachable >>>>>> CC arch/x86/copy_page.o >>>>>> make[2]: *** [Rules.mk:247: arch/x86/alternative.o] Error 1 >>>>> >>>>> But that's not what my request was about. Here sufficient context is >>>>> given, even if it would be nice if the function was also visible right >>>>> away. But that's not the same as the case above, where the new macro >>>>> is used inside another macro. >>>> >>>> An example of that is the get_unsafe_size() macro, >>>> whose body uses STATIC_ASSERT_UNREACHABLE(). >>>> A wrong use of get_unsafe_size() at line n >>>> leads to a build error pointing to the line n, >>>> isn't this the desired behavior? >>> >>> Aiui this would point to the line in the header file, when what you need >>> to spot the bad use of the macro is the line in the source file actually >>> using the macro. Quoting from an earlier mail of yours: >>> >>> ./arch/x86/include/asm/uaccess.h:262: Error: static assertion failed: unreachable >> >> It points to the header file uaccess.h because at line 262 there is >> an intentional wrong use of put_guest_size(), within the body of >> __copy_to_guest_pv() function. > > Yet that's again only a helper function being inlined into the ultimate > caller. That ultimate caller is what wants identifying in the diag. Not > the least because of ... > >> This example can be misleading because {get,put}_unsafe_size() are >> defined in the same file but the diagnostics is doing the >> right thing. > > ... this. And really __copy_to_guest_pv() is the wrong place to put a > wrong put_guest_size() in, to try out how diagnostics would look like > in reality: That function falls back to copy_to_guest_ll() for all > cases it can't handle directly. You want to place a bogus put_guest() > somewhere in a .c file to see what results. I added a bogus call to put_guest() at line 387 of file xen/arch/x86/mm.c, inside function page_is_ram_type(). Assuming I did not choose another wrong place, the diagnostic seems appropriate: arch/x86/mm.c: Assembler messages: arch/x86/mm.c:387: Error: static assertion failed: unreachable -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com)