Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C394DC61DA4 for ; Mon, 6 Mar 2023 05:18:01 +0000 (UTC) Subject: [Kirkstone][Patch review] harfbuzz: CVE-2023-25193 doesn't fix the issue and still exhibits O(n^2) behaviour #kirkstone To: openembedded-core@lists.openembedded.org From: "DC" X-Originating-Location: Ahmedabad, Gujarat, IN (49.34.248.198) X-Originating-Platform: Linux Chrome 110 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Sun, 05 Mar 2023 21:17:53 -0800 Message-ID: Content-Type: multipart/alternative; boundary="Te3SMd1PRR7Wwsn998Kp" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 06 Mar 2023 05:18:01 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/178056 --Te3SMd1PRR7Wwsn998Kp Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The patches submitted to dunfell -> https://lists.openembedded.org/g/openembedded-core/message/17776= 8 Kirkstone -> https://lists.openembedded.org/g/openembedded-core/message/177= 767 ( https://lists.openembedded.org/g/openembedded-core/message/177767 ) Still exhibits=C2=A0O(n^2) behaviour upon testing with applications and fon= ts and in worst cases Harfbuzz is not printing anything. Upon closer examination, looks to me that a wrong fix is pushed for the iss= ue. The patch [ https://github.com/harfbuzz/harfbuzz/commit/85be877925ddbf34f74= a1229f3ca1716bb6170dc ] is known to causes erroneous results and regression= already reverted by Behdad as a developer of Harfbuzz in the commit [ http= s://github.com/harfbuzz/harfbuzz/commit/661050b4659ee490dfe622821bc7fde7d1c= 40510 ]. (ref-> https://github.com/harfbuzz/harfbuzz/commit/85be877925ddbf34f74a1229= f3ca1716bb6170dc#commitcomment-101326711 ) The new fix was already introduced ( https://github.com/harfbuzz/harfbuzz/c= ommit/85be877925ddbf34f74a1229f3ca1716bb6170dc#commitcomment-101335712 ) an= d needs to be backported properly. It doesn't look correct to patch Harfbuzz with code already reverted. --Te3SMd1PRR7Wwsn998Kp Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

The patches submitted to 
dunfell -> https://lists.openembedded.org/g/openembedded-core/mes= sage/177768
Kirkstone -> https://lists.openembedded.org/g/openembedded-core/message/177767 = ;

Still exhibits O(n^2) behaviour upon testing with app= lications and fonts and in worst cases Harfbuzz is not printing anything.Upon closer examination, looks to me that a wrong fix is pushed for the= issue.

The patch [ https://github.com/harfbuzz/harfbuzz/commit/85be877925ddbf34f= 74a1229f3ca1716bb6170dc ] is known to causes erroneous results and regr= ession already reverted by Behdad as a developer of Harfbuzz in the commit = [ https://github.c= om/harfbuzz/harfbuzz/commit/661050b4659ee490dfe622821bc7fde7d1c40510 ].=

(ref-> https://github.com/harfbuzz/harfbuzz/commit/85be877= 925ddbf34f74a1229f3ca1716bb6170dc#commitcomment-101326711)

T= he new fix was already introduced (https://github.com/harfbuzz/harfbu= zz/commit/85be877925ddbf34f74a1229f3ca1716bb6170dc#commitcomment-101335712<= /a>) and needs to be backported properly.

It doesn't look correct to patch Harfbuzz with code already reverted. --Te3SMd1PRR7Wwsn998Kp--