From: ShaunR Subject: [PATCH] tools/xenstat/xentop/xentop.c -- fix xentop so it returns the correct exit code on invalid argument Date: Fri, 22 Oct 2010 15:27:04 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This patch fixes the problem with xentop where it returns an exit code of 0 when passing it invalid options when it should return 1. The issue comes from getopt() returning '?' and the case from switch matching it. The solution was to remove the case '?' so that the default match could be triggered. Quote from `man 3 getopt` "If getopt() does not recognize an option character, it prints an error message to stderr, stores the character in optopt, and returns '?'." --- tools/xenstat/xentop/xentop.c-orig 2010-10-22 15:20:13.000000000 -0700 +++ tools/xenstat/xentop/xentop.c 2010-10-22 15:20:21.000000000 -0700 @@ -1135,7 +1135,6 @@ default: usage(argv[0]); exit(1); - case '?': case 'h': usage(argv[0]); exit(0);